Change in ovirt-engine[master]: restapi: No NPE when no linked exception
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: No NPE when no linked exception
......................................................................
restapi: No NPE when no linked exception
Some exceptions generated when posting an incorrect XML document don't
contain a linked exception. In those cases we try to reference them and
thus a NPE is produced, for example, if we post a valid but incorrect
XML document to a collection:
# curl \
--insecure \
--request POST \
--header "Accept: application/xml" \
--header "Content-Type: application/xml" \
--user "${user}:${password}" \
--data "<garbage/>" \
${url}/tags
To avoid this issue this patch adds a check to the XML message body
reader, so that when these type of exceptions occur it will generate the
expected usage message instead of the NPE.
Change-Id: I7158c3d5c9d3c928209444d27c369e8753b2c840
Bug-Url: https://bugzilla.redhat.com/1091981
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/XmlMessageBodyReader.java
1 file changed, 9 insertions(+), 4 deletions(-)
Approvals:
Ravi Nori: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27161
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7158c3d5c9d3c928209444d27c369e8753b2c840
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: engine: Check for conflicting address when hotplugging a disk
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: Check for conflicting address when hotplugging a disk
......................................................................
engine: Check for conflicting address when hotplugging a disk
When a disk image is hotplugged and it has a stored address we have to
check if that address is not taken by another plugged disk and if that's
the case we should remove the address from the disk that's going to be
hotplugged.
The rationale behind this is: when a disk is hotunplugged qemu may free the
disk's address for further use. If another disk is hotplugged that
address may be given to the new device. Thus would cause that when the
first disk is hotplugged again its address will be rejected because
it's in use by the second disk.
Change-Id: Id5850fd4c15a230dbc27e8c22d47935083da21c2
Bug-Url: https://bugzilla.redhat.com/1079697
Signed-off-by: Xavi Francisco <xfrancis(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java
M packaging/dbscripts/vm_device_sp.sql
5 files changed, 49 insertions(+), 1 deletion(-)
Approvals:
Xavi Francisco: Verified
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Looks good to me, approved
Liron Ar: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/26598
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5850fd4c15a230dbc27e8c22d47935083da21c2
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xavi Francisco <xfrancis(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: Activate host doesn't set return value
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Activate host doesn't set return value
......................................................................
core: Activate host doesn't set return value
ActivateVds defacto works but doesn't set the return value to true,
which result REST calls to believe it failed.
Change-Id: Id6802431ebc4239e46ab7df30355e18ebf368e86
Bug-Url: https://bugzilla.redhat.com/1077300
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27253
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6802431ebc4239e46ab7df30355e18ebf368e86
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: restapi: Avoid NPE with empty app list
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Avoid NPE with empty app list
......................................................................
restapi: Avoid NPE with empty app list
Currently we don't check the list of applications installed in a VM to
make sure that the application names aren't empty. This patch fixes
that in order to prevent NPEs.
Change-Id: Ieed7a5b90732f510973bedd7306d236ade4b2b3a
Bug-Url: https://bugzilla.redhat.com/1092380
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmApplicationsResource.java
1 file changed, 6 insertions(+), 8 deletions(-)
Approvals:
Ravi Nori: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27192
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieed7a5b90732f510973bedd7306d236ade4b2b3a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: Provide confirmation prompt while unplugging a Vnic
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Provide confirmation prompt while unplugging a Vnic
......................................................................
webadmin: Provide confirmation prompt while unplugging a Vnic
When the user clicks "ok" on edit vnic dialog-
1. If the user changed the vnic to be unplugged a confrimation window
should be shown.
2. Otherwise, the dialog should be saved.
Change-Id: Iaf1c384f0205bb8b30cda038963eb49eba1dae55
Bug-Url: https://bugzilla.redhat.com/859024
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditVmInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
3 files changed, 57 insertions(+), 5 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27198
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf1c384f0205bb8b30cda038963eb49eba1dae55
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: reorder storage iso storage models
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: reorder storage iso storage models
......................................................................
webadmin: reorder storage iso storage models
AsyncDataProvider -> getIsoStorageModels:
reorder storage models to accomodate data storage models order
(affects new/import domain).
Change-Id: I687720abe78a41ed6e360add039c8609b6d7de71
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/27219
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I687720abe78a41ed6e360add039c8609b6d7de71
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.4]: backend: Lessen permissions needed for VmPool creation
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: backend: Lessen permissions needed for VmPool creation
......................................................................
backend: Lessen permissions needed for VmPool creation
Changed AddVmPoolWithVmsCommand to require only CREATE_VM permission
for the template instead of CREATE_VM_POOL to make it consistent with
user's ability to create VMs.
Change-Id: Ib28ae681a91d7b11455283041062779733e61f2b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1058290
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Martin Betak: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27237
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib28ae681a91d7b11455283041062779733e61f2b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: aaa: put failure as result only if there is no result alread...
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: put failure as result only if there is no result already set
......................................................................
aaa: put failure as result only if there is no result already set
Change-Id: I32c71b854fde5c0734a6c1739eaaa3745a250273
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapAuthenticateUserCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27248
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32c71b854fde5c0734a6c1739eaaa3745a250273
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[master]: utils: introduce universal utilities (uutils)
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: utils: introduce universal utilities (uutils)
......................................................................
utils: introduce universal utilities (uutils)
a package of packages that may be split out of engine, not directly
related to engine and can be split even to own jars.
this will enable components that should not pull the engine 'common'
part to enjoy these utilities.
Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHClient.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHDialog.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java
M backend/manager/modules/builtin-extensions/pom.xml
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsArguments.java
M backend/manager/modules/builtin-extensions/src/main/modules/org/ovirt/engine/extensions/builtin/main/module.xml
M backend/manager/modules/pom.xml
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/EngineLocalConfig.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java
M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml
A backend/manager/modules/uutils/exclude-filters.xml
A backend/manager/modules/uutils/pom.xml
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/Argument.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/ArgumentBuilder.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/ExtendedCliParser.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ConstraintByteArrayOutputStream.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtils.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ProgressInputStream.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ProgressOutputStream.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHClient.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHDialog.java
A backend/manager/modules/uutils/src/main/modules/org/ovirt/engine/core/uutils/main/module.xml
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/cli/ArgumentBuilderTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/cli/ExtendedCliParserTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/config/ShellLikeConfdTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/BasicTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/CommandTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/ConstraintByteArrayOutputStreamTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtilsTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/PropertiesTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHD.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHDialogTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TimeoutTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TransferTest.java
R backend/manager/modules/uutils/src/test/resources/config.conf
R backend/manager/modules/uutils/src/test/resources/config.conf.ref
A backend/manager/modules/uutils/src/test/resources/key.p12
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java
M backend/manager/tools/src/main/modules/org/ovirt/engine/core/tools/main/module.xml
M ear/src/main/resources/META-INF/MANIFEST.MF
M ovirt-engine.spec.in
49 files changed, 216 insertions(+), 79 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yair Zaslavsky: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: aaa: fix ovirt-engine-roll usage typo
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: fix ovirt-engine-roll usage typo
......................................................................
aaa: fix ovirt-engine-roll usage typo
Topic: AAA
Change-Id: I85c3ee6777757ac08fd1f78450d3939a7848618a
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/bin/ovirt-engine-role.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27196
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I85c3ee6777757ac08fd1f78450d3939a7848618a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months