April 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-reports[master]: reports: br5 report - added comments to queries

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: reports: br5 report - added comments to queries ...................................................................... reports: br5 report - added comments to queries Changed the code structure so it will be more readable and added commets. Change-Id: Ie771e476688c5dfc2bf432c11f96631db2b1a658 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Trend/Hosts/five_least_utilized_hosts_br5_files/br7 full details.jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Hosts/five_least_utilized_hosts_br5_files/five_least_utilized_hosts_br5_jrxml.data 2 files changed, 661 insertions(+), 453 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie771e476688c5dfc2bf432c11f96631db2b1a658 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Activate host doesn't set return value

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: core: Activate host doesn't set return value ...................................................................... core: Activate host doesn't set return value ActivateVds defacto works but doesn't set the return value to true, which result REST calls to believe it failed. Change-Id: Id6802431ebc4239e46ab7df30355e18ebf368e86 Bug-Url: https://bugzilla.redhat.com/1077300 Signed-off-by: Roy Golan <rgolan(a)redhat.com> (cherry picked from commit 977a612194013378bc4868f44f9b1ab5170a2453) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6802431ebc4239e46ab7df30355e18ebf368e86 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: Avoid NPE with empty app list

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: Avoid NPE with empty app list ...................................................................... restapi: Avoid NPE with empty app list Currently we don't check the list of applications installed in a VM to make sure that the application names aren't empty. This patch fixes that in order to prevent NPEs. Change-Id: Ieed7a5b90732f510973bedd7306d236ade4b2b3a Bug-Url: https://bugzilla.redhat.com/1092380 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit a1c36428498b56234d6293e2392a861260ab91f6) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmApplicationsResource.java 1 file changed, 6 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieed7a5b90732f510973bedd7306d236ade4b2b3a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4.1]: backend: Lessen permissions needed for VmPool creation

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: backend: Lessen permissions needed for VmPool creation ...................................................................... backend: Lessen permissions needed for VmPool creation Changed AddVmPoolWithVmsCommand to require only CREATE_VM permission for the template instead of CREATE_VM_POOL to make it consistent with user's ability to create VMs. Change-Id: Ib28ae681a91d7b11455283041062779733e61f2b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1058290 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Martin Betak: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib28ae681a91d7b11455283041062779733e61f2b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.1 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 7 months

1
0
0 / 0

Change in ovirt-reports[master]: reports: br47 report - added comments to queries

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: reports: br47 report - added comments to queries ...................................................................... reports: br47 report - added comments to queries Changed the code structure so it will be more readable and added commets. Change-Id: I4ce5b40141765d1e25637741b6c5a02b12b208b7 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Inventory/storage_domains_inventory_br47_files/chart.data M packaging/ovirt-reports/resources/Reports/Inventory/storage_domains_inventory_br47_files/full details.jrxml.data M packaging/ovirt-reports/resources/Reports/Inventory/storage_domains_inventory_br47_files/storage_domains_inventory_br47_jrxml.data 3 files changed, 833 insertions(+), 618 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ce5b40141765d1e25637741b6c5a02b12b208b7 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Fix canDoActionFailedUpdateReadOnly Test

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix canDoActionFailedUpdateReadOnly Test ...................................................................... core: Fix canDoActionFailedUpdateReadOnly Test In UpdateVmDiskCommandTest, above test assigned RO=true property to existing disk-vm configuration ("oldDisk in the command"), which is irrelevant to the test. This fix removes the above assignment and adds the relevant one - to the new configuration. Change-Id: Ic304ab235776b3db823522a9219a00d7c8df1017 Relates-To: https://bugzilla.redhat.com/1092087 Relates-To: https://bugzilla.redhat.com/1092371 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic304ab235776b3db823522a9219a00d7c8df1017 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Disallow RO disks resize in CDA

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: Disallow RO disks resize in CDA ...................................................................... core: Disallow RO disks resize in CDA Resizing RO disks is now disallowed in UpdateVmDiskCommad.validateCanResizeDisk(), which is called by CDA. Added VdcBllMessages.ACTION_TYPE_FAILED_CANNOT_RESIZE_READ_ONLY_DISK and relevant test. Change-Id: Ibd1b9ec592cacab0156bdede6081b375b7dae935 Bug-Url: https://bugzilla.redhat.com/1092087 Bug-Url: https://bugzilla.redhat.com/1092371 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 35 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/27252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd1b9ec592cacab0156bdede6081b375b7dae935 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Add AuditLogDirectorDelegator as a non-static versio...

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: engine: Add AuditLogDirectorDelegator as a non-static version of AuditLogDirector ...................................................................... engine: Add AuditLogDirectorDelegator as a non-static version of AuditLogDirector AuditLogDirectorDelegator provide the non-static log methods which can be mocked in unit tests. Change-Id: I82f6b81c10da58bdf6e84934a6388e43f095179f Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirectorDelegator.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogger.java 2 files changed, 40 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82f6b81c10da58bdf6e84934a6388e43f095179f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: fix instance types permissions

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: fix instance types permissions ...................................................................... engine: fix instance types permissions If the VM is created from instance type, the user needs to have either create instance permission on the specific instance type or the proper getActionType().getActionGroup() on it (either is OK). Same comes for image type. Change-Id: Ibf039b0ea2d4488e243416832703bfc6a55b7337 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 32 insertions(+), 11 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf039b0ea2d4488e243416832703bfc6a55b7337 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Warning when deleting an instance type which is attach...

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: core: Warning when deleting an instance type which is attached to a VM ...................................................................... core: Warning when deleting an instance type which is attached to a VM Backend part - adds a query to get all the VMs which are based on an instance type. Change-Id: I5ed11ee1b543bda00f41b00c5726a907eaf498de Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsByInstanceTypeIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/vms_sp.sql 7 files changed, 60 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ed11ee1b543bda00f41b00c5726a907eaf498de Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits April 2014