April 2014 - Engine-commits - oVirt List Archives

Change in ovirt-dwh[ovirt-engine-3.4]: history: fixed issue with upgrade script
by ydary＠redhat.com 23 Apr '14

23 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: history: fixed issue with upgrade script ...................................................................... history: fixed issue with upgrade script Change-Id: I58e468c6d547f465a1989e55a9bd712dd4c516da Signed-off-by: Yaniv Dary <ydary(a)redhat.com> (cherry picked from commit 7b19bf2342df7d7080b02d3361213be39236667f) --- M packaging/dbscripts/upgrade/03_04_0080_updated_enums.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58e468c6d547f465a1989e55a9bd712dd4c516da Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[master]: history: fixed issue with upgrade script
by ydary＠redhat.com 23 Apr '14

23 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: history: fixed issue with upgrade script ...................................................................... history: fixed issue with upgrade script Change-Id: I58e468c6d547f465a1989e55a9bd712dd4c516da Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/dbscripts/upgrade/03_04_0080_updated_enums.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58e468c6d547f465a1989e55a9bd712dd4c516da Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Prevent VM suspend in the ppc64 arch
by tjelinek＠redhat.com 23 Apr '14

23 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Prevent VM suspend in the ppc64 arch ...................................................................... webadmin: Prevent VM suspend in the ppc64 arch This change prevents the suspension of VMs in architectures that do not support it by disabling the suspend button in the frontend. Change-Id: Ibe6a5fd5ad1679045582afcc16aebbfba34f7429 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1070189 Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 3 files changed, 15 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe6a5fd5ad1679045582afcc16aebbfba34f7429 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-engine-3.4]: packaging: added release notes
by ydary＠redhat.com 23 Apr '14

23 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: added release notes ...................................................................... packaging: added release notes Change-Id: I95c5ee9cc70978967c5dcdd341e9b7d60f842734 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M ovirt-engine-reports.spec.in 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95c5ee9cc70978967c5dcdd341e9b7d60f842734 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Add labels to network and host_nic
by juan.hernandez＠redhat.com 23 Apr '14

23 Apr '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add labels to network and host_nic ...................................................................... restapi: Add labels to network and host_nic Change-Id: I36f3833b8eb3878c5eac996f7c9b38d4ae8a683a Bug-Url: https://bugzilla.redhat.com/1084937 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36f3833b8eb3878c5eac996f7c9b38d4ae8a683a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: EnterIgnoringFocusHandler catch ONKEYDOWN
by oourfali＠redhat.com 23 Apr '14

23 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: EnterIgnoringFocusHandler catch ONKEYDOWN ...................................................................... webadmin: EnterIgnoringFocusHandler catch ONKEYDOWN EnterIgnoringFocusHandler -> onPreviewNativeEvent: execute 'enterPressed' on ONKEYDOWN event instead of ONKEYPRESS to overcome an issue in newer Chrome/FF browsers, in which the textarea doesn't catch the ONKEYPRESS event. Consequently, pressing enter key in a textarea won't break to a new line (e.g. 'Custom Script' textarea). Change-Id: I064f74e79dedb20ab305ef238c7ff2a6fed743fe Bug-Url: https://bugzilla.redhat.com/1064567 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnterIgnoringFocusHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/26978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I064f74e79dedb20ab305ef238c7ff2a6fed743fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: tools: Fix LDAP servers issue in engine-manage-domains
by oourfali＠redhat.com 23 Apr '14

23 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: tools: Fix LDAP servers issue in engine-manage-domains ...................................................................... tools: Fix LDAP servers issue in engine-manage-domains LDAP servers discovered using DNS query will not be written to database (they will be rediscovered using DNS query when needed). LDAP servers entered in --ldap-servers argument will be always written to database (they will be used then and no LDAP DNS discovery will be executed). Change-Id: I4ab5bd3a27787615c7430ce2f3a120261f4cd300 Bug-Url: https://bugzilla.redhat.com/1084479 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Verified Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ab5bd3a27787615c7430ce2f3a120261f4cd300 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: findbugs warning
by awels＠redhat.com 23 Apr '14

23 Apr '14

Alexander Wels has submitted this change and it was merged. Change subject: engine: findbugs warning ...................................................................... engine: findbugs warning - Fixed 'unusual equals' findbug warning - Fixed 'comparing string with '='' warning. Change-Id: I25f0be9e319aec078fadabfa426d1e4b7c170493 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ServerCpu.java M frontend/webadmin/modules/uicommonweb/exclude-filters.xml 2 files changed, 14 insertions(+), 7 deletions(-) Approvals: Alexander Wels: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25f0be9e319aec078fadabfa426d1e4b7c170493 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Validate dest when importing template
by mlipchuk＠redhat.com 23 Apr '14

23 Apr '14

Maor Lipchuk has submitted this change and it was merged. Change subject: restapi: Validate dest when importing template ...................................................................... restapi: Validate dest when importing template When importing a template it is mandatory to specify the destination storage domain. The RESTAPI doesn't currently validate this, and thus the request is accepted and eventually it generates a NPE since AbstractBackendStorageDomainContentResource#getDestStorageDomainId is counting on the storage id. This patch changes the RESTAPI so that it validates that the id or name of the destination storage domain has been provided. If it isn't provided it will generate the following error response: <?xml version="1.0" encoding="UTF-8" standalone="yes"?> <fault> <reason>Incomplete parameters</reason> <detail>Action [storageDomain.id|name] required for doImport</detail> </fault> The patch should keep backward compatibility since before it, we got an NPE, and now it is being replaced with an informative message. Change-Id: I2cf2d94514b159c34f19a7f0377fcb2a9afd1c19 Bug-Url: https://bugzilla.redhat.com/1081173 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResourceTest.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/26127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cf2d94514b159c34f19a7f0377fcb2a9afd1c19 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Validate dest when importing VM
by mlipchuk＠redhat.com 23 Apr '14

23 Apr '14

Maor Lipchuk has submitted this change and it was merged. Change subject: restapi: Validate dest when importing VM ...................................................................... restapi: Validate dest when importing VM When importing a VM it is mandatory to specify the destination storage domain. The RESTAPI doesn't currently validate this, and thus the request is accepted and eventually it generates a NPE since AbstractBackendStorageDomainContentResource#getDestStorageDomainId is counting on the storage id. This patch changes the RESTAPI so that it validates that the id or name of the destination storage domain has been provided. If it isn't provided it will generate the following error response: <?xml version="1.0" encoding="UTF-8" standalone="yes"?> <fault> <reason>Incomplete parameters</reason> <detail>Action [storageDomain.id|name] required for doImport</detail> </fault> The patch should keep backward compatibility since before it, we got an NPE, and now it is being replaced with an informative message. Change-Id: Id9f0e743de7260b0a838b1da2bd94ac48b28d6be Bug-Url: https://bugzilla.redhat.com/1081173 Signed-off-by: MAor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResourceTest.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/26960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9f0e743de7260b0a838b1da2bd94ac48b28d6be Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0