April 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: restapi: Add labels to network and host_nic
by oourfali＠redhat.com 24 Apr '14

24 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: Add labels to network and host_nic ...................................................................... restapi: Add labels to network and host_nic (cherry picked from commit ff1735a66c561c249148ed71b7ce6ad17cff7a57) Change-Id: I36f3833b8eb3878c5eac996f7c9b38d4ae8a683a Bug-Url: https://bugzilla.redhat.com/1084937 Bug-Url: https://bugzilla.redhat.com/1085736 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/27011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36f3833b8eb3878c5eac996f7c9b38d4ae8a683a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-engine-3.4]: packaging: setup: Ask whether to backup the database
by ydary＠redhat.com 24 Apr '14

24 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Ask whether to backup the database ...................................................................... packaging: setup: Ask whether to backup the database Also rollback db at cleanup stage (env overridable) to allow starting the engine service early if needed. Change-Id: I8e113bddaeeb71b00f5a524db0be3a24fa6f9907 Bug-Url: https://bugzilla.redhat.com/1059286 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 98c2062406a0c0b4acd74cae7279c3ff5b91730f) --- M packaging/setup/ovirt_engine_setup/dwhconstants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/schema.py 2 files changed, 203 insertions(+), 37 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e113bddaeeb71b00f5a524db0be3a24fa6f9907 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[master]: packaging: setup: Ask whether to backup the database
by ydary＠redhat.com 24 Apr '14

24 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Ask whether to backup the database ...................................................................... packaging: setup: Ask whether to backup the database Also rollback db at cleanup stage (env overridable) to allow starting the engine service early if needed. Change-Id: I8e113bddaeeb71b00f5a524db0be3a24fa6f9907 Bug-Url: https://bugzilla.redhat.com/1059286 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/dwhconstants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/schema.py 2 files changed, 203 insertions(+), 37 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e113bddaeeb71b00f5a524db0be3a24fa6f9907 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: UI plugins - SystemTreeSelectionChange
by vszocs＠redhat.com 24 Apr '14

24 Apr '14

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: UI plugins - SystemTreeSelectionChange ...................................................................... webadmin: UI plugins - SystemTreeSelectionChange This patch adds 'SystemTreeSelectionChange' event handler function that gets called whenever System Tree node selection changes. Example usage: api.register({ SystemTreeSelectionChange: function(selectedItem) { // Currently using SystemTreeItemType enum name // e.g. 'System', 'DataCenters', 'DataCenter', etc. alert(selectedItem.type); // Defined if there is business entity associated // e.g. for 'DataCenter' -> { id: '..', name:'..' } // See EntityObject#from for details on mapping alert(selectedItem.entity); } }); It also fixes some issues in JsArrayHelper and adds JsMutableObjectWithProperties to deal with mutable native JS objects within UI plugin infrastructure. Change-Id: Ib01721c309912526f8d7f8252e94b44e0dbfd423 Bug-Url: https://bugzilla.redhat.com/1066425 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/TabModelProvider.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginEventHandler.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/entity/EntityObject.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/entity/SystemTreeItemObject.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/jsni/JsArrayHelper.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/jsni/JsMutableObjectWithProperties.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/SystemTreeModelProvider.java 7 files changed, 131 insertions(+), 32 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit http://gerrit.ovirt.org/25186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib01721c309912526f8d7f8252e94b44e0dbfd423 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix build break
by masayag＠redhat.com 24 Apr '14

24 Apr '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fix build break ...................................................................... engine: Fix build break Change-Id: I7f2080dd527688bafebd92b8b1dd8eecf9ee40c8 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f2080dd527688bafebd92b8b1dd8eecf9ee40c8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Rename all management networks and profiles
by lvernia＠redhat.com 24 Apr '14

24 Apr '14

Lior Vernia has submitted this change and it was merged. Change subject: core: Rename all management networks and profiles ...................................................................... core: Rename all management networks and profiles The rename stored procedure used to only rename one management network, but there actually may be multiple ones (in case multiple DCs exist). Also, the procedure neglected to rename the corresponding vNIC profiles. This patch aims to correct these. Change-Id: I59e6278f283cafdc2f865e18129349f5905f6d3a Bug-Url: https://bugzilla.redhat.com/1077772 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M packaging/dbscripts/network_sp.sql 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59e6278f283cafdc2f865e18129349f5905f6d3a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Consider removed bonds in CollectVdsNetworkData
by lvernia＠redhat.com 24 Apr '14

24 Apr '14

Lior Vernia has submitted this change and it was merged. Change subject: engine: Consider removed bonds in CollectVdsNetworkData ...................................................................... engine: Consider removed bonds in CollectVdsNetworkData Changes to removed bonds should also be considered in the CollectVdsNetworkData command, because they won't necessarily be torn down by VDSM, in which case their label changes should still be persisted. There existed code to clear labels from removed bonds in SetupNetworksCommand, but it was pretty much dead code, as removed bonds by definition don't appear in the passed interfaces collection. Change-Id: I44f1d5c0702e5062fe29bc89e12ff2400b46921b Bug-Url: https://bugzilla.redhat.com/1085819 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java 3 files changed, 14 insertions(+), 24 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26926 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44f1d5c0702e5062fe29bc89e12ff2400b46921b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: fix findbugs violation in VmListModel
by tjelinek＠redhat.com 24 Apr '14

24 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: fix findbugs violation in VmListModel ...................................................................... frontend: fix findbugs violation in VmListModel this patch removes unused property in VmListModel Change-Id: Ic053f2276e86b18e8c3055ebb2edc62fd301933c Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/27036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic053f2276e86b18e8c3055ebb2edc62fd301933c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[ovirt-3.4]: agent: Report number of CPU cores visible online on the gues...
by vfeenstr＠redhat.com 24 Apr '14

24 Apr '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: agent: Report number of CPU cores visible online on the guest OS ...................................................................... agent: Report number of CPU cores visible online on the guest OS This patches a new message and increases the Guest Agent API to version 1. The new message has this format: {"__name__": "number-of-cpus", "count": <int>} The reported number 'count' is the number of visible online CPU cores on the guest OS system. Change-Id: Ief777608519a35319665c4cd0f580b7b38305b3e Guest-Agent-API-Version: 1 Bug-URL: https://bugzilla.redhat.com/show_bug.cgi?id=1063280 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/OVirtAgentLogic.py M ovirt-guest-agent/ovirt-guest-agent.conf M ovirt-guest-agent/ovirt-guest-agent.ini M tests/guest_agent_test.py M tests/message_validator.py 5 files changed, 54 insertions(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief777608519a35319665c4cd0f580b7b38305b3e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[ovirt-3.4]: agent: Implement basics for API Versioning
by vfeenstr＠redhat.com 24 Apr '14

24 Apr '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: agent: Implement basics for API Versioning ...................................................................... agent: Implement basics for API Versioning This commit introduces the basics needed to support API versioning between the ovirt-guest-agent and VDSM. How the negotiation works: - VDSM has as a default the apiVersion value set to _DISABLED_API_VALUE marking it as unsupported - The guest agent sends its max supported version with every `heartbeat` message - VDSM checks that `apiVersion` exists in the `heartbeat` message arguments - If it exists it retrieves the minimum common version and sends the `api-version` message with the common version as `apiVersion` argument - If it does NOT exist it and the apiVersion is not set to _DISABLED_API_VALUE it will set it to _DISABLED_API_VALUE, with the meaning that it is not supported at all by the guest agent on the other end. - The guest agent on receiving this message makes it own check and sets the `apiVersion` to the commonVersion - If VDSM sends the `refresh` command it also sends its `apiVersion` value however if it does not, capable guest agents are disabling the versioning support and will know it in pre-supported state as well. NOTE: VDSM will never send an api-version message without being triggered. This is to ensure backwards compatibility. Change-Id: I754d52009538914dd0143894b24ad48fbf13cb38 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/OVirtAgentLogic.py M tests/guest_agent_test.py M tests/message_validator.py 3 files changed, 170 insertions(+), 24 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I754d52009538914dd0143894b24ad48fbf13cb38 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0