April 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin, userportal: translations update
by ecohen＠redhat.com 22 Apr '14

22 Apr '14

Einav Cohen has submitted this change and it was merged. Change subject: webadmin, userportal: translations update ...................................................................... webadmin, userportal: translations update pulled translation from Zanata oVirt project, master version. Change-Id: I26bbe85385ebdccc5517699e728adda55f3479b9 Signed-off-by: Einav Cohen <ecohen(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_pt_BR.properties M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationMessages_ja_JP.properties M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationMessages_pt_BR.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_pt_BR.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_ja_JP.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_pt_BR.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_pt_BR.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationConstants_pt_BR.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationMessages_ja_JP.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_pt_BR.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants_ja_JP.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants_pt_BR.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_ja_JP.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_pt_BR.properties 14 files changed, 47 insertions(+), 47 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Einav Cohen: Verified -- To view, visit http://gerrit.ovirt.org/26939 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26bbe85385ebdccc5517699e728adda55f3479b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Add VM pool description to RSDL
by juan.hernandez＠redhat.com 22 Apr '14

22 Apr '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add VM pool description to RSDL ...................................................................... restapi: Add VM pool description to RSDL The "description" property of the operation to update a VM pool isn't documented in the metadata file, thus it doesn't appear in the RSDL document and isn't available in the CLI. Change-Id: If0ece6b092eed72ccb1fa04ea05308f046e5755e Bug-Url: https://bugzilla.redhat.com/1085386 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0ece6b092eed72ccb1fa04ea05308f046e5755e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Warning about display network change. (tooltip in ...
by alkaplan＠redhat.com 22 Apr '14

22 Apr '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Warning about display network change. (tooltip in the UI) ...................................................................... webadmin: Warning about display network change. (tooltip in the UI) The warning that let the user to understand that the changes in display network will be applied not instantly, but on the next VM restart. Change-Id: I93151d3893aedeccb7e6e7cd7a06d907f1b36d83 Bug-Url: https://bugzilla.redhat.com/1078836 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java 3 files changed, 10 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/26537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93151d3893aedeccb7e6e7cd7a06d907f1b36d83 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Use current name when updating pool
by juan.hernandez＠redhat.com 22 Apr '14

22 Apr '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use current name when updating pool ...................................................................... restapi: Use current name when updating pool When updating a VM pool the RESTAPI tries to find the VM data using the name of the pool, but it uses the name provided by the caller, which may not be provided, or different to the current one. The effect of this is that any update not containing the name of the pool fails with a 404 response code. This patch changes that logic to use the current name of the pool. Change-Id: Icfd4ae9bf7efed8db6b22cfa7e5dbdbd62cd1136 Related: https://bugzilla.redhat.com/1085386 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfd4ae9bf7efed8db6b22cfa7e5dbdbd62cd1136 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Set default vNIC type according to OsInfo
by lvernia＠redhat.com 22 Apr '14

22 Apr '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Set default vNIC type according to OsInfo ...................................................................... webadmin: Set default vNIC type according to OsInfo Only set the vNIC type to VirtIO by default if it exists in the OsInfo vNIC types; if not, pick the first one among the existing values. This had to be changed for both the vNIC dialog and the VM dialog (where the vNIC type can't be edited by the user but it is implicitly set when adding a new vNIC). Change-Id: I4f09986e661d820b3c10301fa35c840fd9cfe0d8 Bug-Url: https://bugzilla.redhat.com/996044 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseEditVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModelNetworkAsyncCallback.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceCreatingManager.java 5 files changed, 35 insertions(+), 12 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/26925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f09986e661d820b3c10301fa35c840fd9cfe0d8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix type-casting warnings in ClusterManageNetworkP...
by alkaplan＠redhat.com 22 Apr '14

22 Apr '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Fix type-casting warnings in ClusterManageNetworkPopupView and re-arrange it. ...................................................................... webadmin: Fix type-casting warnings in ClusterManageNetworkPopupView and re-arrange it. In ClusterManageNetworkPopupView class: 1. Change all generic EntityModel occurencies to a specific model class (i.e. ClusterNetworkModel). 2. Remove all type type castings. 3. Convert anonymous classes into inner ones. Define ClusterNetworkModel class as an extetion of EntityModel<Network> (add Network as a type parameter). Change-Id: If0a72f5530388d1abb6758e0d9cc9e5c8ebdb3e9 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java 2 files changed, 261 insertions(+), 221 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/26159 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0a72f5530388d1abb6758e0d9cc9e5c8ebdb3e9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove image configuration check on disk move/copy
by tnisan＠redhat.com 22 Apr '14

22 Apr '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove image configuration check on disk move/copy ...................................................................... core: Remove image configuration check on disk move/copy Since the destination format type is determined by VDSM, there is no reason to check whether the image to be moved/copied configration is supported by the destination domain Change-Id: Ic774155b0811faf8607f735f19f9b785cf15e610 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1063996 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java 2 files changed, 0 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic774155b0811faf8607f735f19f9b785cf15e610 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Have minus button on every row in AddRemoveRowWidget
by lvernia＠redhat.com 22 Apr '14

22 Apr '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Have minus button on every row in AddRemoveRowWidget ...................................................................... webadmin: Have minus button on every row in AddRemoveRowWidget Modified AddRemoveRowWidget to have a minus button on every entry, including the last one. This to enable removing the last row without adding a new one first. When removing the last row though, a plus button needs to be added to the previous one. Also made sure to add a new ghost entry if the removed entry was the only one (this is equivalent to reseting the entry's value to a ghost value). Some styling changes were required to properly display two buttons per entry, where this couldn't happen before. Change-Id: I6f6af3c5a94f7786a9b1e6191f1c36d3181983cf Bug-Url: https://bugzilla.redhat.com/1065978 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelEditor.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.ui.xml 8 files changed, 58 insertions(+), 24 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f6af3c5a94f7786a9b1e6191f1c36d3181983cf Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Generalize console shortcut config values
by ahadas＠redhat.com 22 Apr '14

22 Apr '14

Arik Hadas has submitted this change and it was merged. Change subject: engine: Generalize console shortcut config values ...................................................................... engine: Generalize console shortcut config values This patch generalizes configuration names for shortcuts for: - releasing cursor from remote-viewer - toggling fullscreen in remote-viewer. The configuration names were originaly intended to be used with SPICE only, but they are actually valid for VNC as well. Change-Id: Icd339a326222e3910d835db21ac459540dc74f14 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1083766 --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 4 files changed, 10 insertions(+), 8 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd339a326222e3910d835db21ac459540dc74f14 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: tools: Remove debug log when parsing args in engine-config
by oourfali＠redhat.com 22 Apr '14

22 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: tools: Remove debug log when parsing args in engine-config ...................................................................... tools: Remove debug log when parsing args in engine-config Removes debug log messages when parsing args in engine-config. This is needed to enable logging setup that uses command line arguments. Change-Id: I3b549b8216c3e1af2cf167fac978673c9528894d Bug-Url: https://bugzilla.redhat.com/1063901 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java 1 file changed, 0 insertions(+), 24 deletions(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b549b8216c3e1af2cf167fac978673c9528894d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0