Change in ovirt-engine[ovirt-engine-3.4]: core: Add common methods for runtime log4j setup
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Add common methods for runtime log4j setup
......................................................................
core: Add common methods for runtime log4j setup
Adds Log4jUtils class which contains methods for runtime log4j setup
used in engine-config and engine-manage-domains.
Change-Id: Ic00ea0af643e8c978fd67eb8c56e2329d43e776d
Bug-Url: https://bugzilla.redhat.com/1063901
Bug-Url: https://bugzilla.redhat.com/1083411
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/Log4jUtils.java
1 file changed, 61 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26818
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic00ea0af643e8c978fd67eb8c56e2329d43e776d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: tools: Remove logging when parsing args in engine-manage-dom...
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: tools: Remove logging when parsing args in engine-manage-domains
......................................................................
tools: Remove logging when parsing args in engine-manage-domains
Removes log messages when parsing args in engine-manage-domains.
This is needed to enable logging setup that uses command line
arguments.
Change-Id: I3b1c5e76e6dbd2bc2c3d49abac03e10d4dc6faf6
Bug-Url: https://bugzilla.redhat.com/1083411
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsArguments.java
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Martin Peřina: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26822
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b1c5e76e6dbd2bc2c3d49abac03e10d4dc6faf6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: tools: Remove EngineConfigCLIParser instance variable from E...
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: tools: Remove EngineConfigCLIParser instance variable from EngineConfig
......................................................................
tools: Remove EngineConfigCLIParser instance variable from EngineConfig
Removes EngineConfigCLIParser instance variable from EngineConfig since
it's needed only in EngineConfig.setUpAndExecute() method.
Change-Id: I1390755096670c7ed21882a487280d85426e576f
Bug-Url: https://bugzilla.redhat.com/1063901
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfig.java
1 file changed, 6 insertions(+), 11 deletions(-)
Approvals:
Martin Peřina: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26819
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1390755096670c7ed21882a487280d85426e576f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: frontend: Fix incorrect text wrap
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: frontend: Fix incorrect text wrap
......................................................................
frontend: Fix incorrect text wrap
In Japanese, caption for remaping control-alt-del is broken into two
lines.
Change-Id: I0c62c286d2c85d43da5aec89df01f3d43e63171d
Bug-Url: https://bugzilla.redhat.com/1080322
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.ui.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Frank Kobzik: Verified
--
To view, visit http://gerrit.ovirt.org/26890
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c62c286d2c85d43da5aec89df01f3d43e63171d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Store rest api session id in http session
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Store rest api session id in http session
......................................................................
webadmin: Store rest api session id in http session
- REST API stores a session id for the UI plugins.
Moved the session id location from LocalStorage to
HTTP session.
Change-Id: I6fe9af54054aefe694876b1805a4a44f9bba0482
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1077448
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/CommunicationProvider.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/GWTRPCCommunicationProvider.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/OperationProcessor.java
A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/StorageCallback.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/VdcOperationManager.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/gwtservices/GenericApiGWTService.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java
9 files changed, 183 insertions(+), 10 deletions(-)
Approvals:
Alexander Wels: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26807
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6fe9af54054aefe694876b1805a4a44f9bba0482
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: core: Distinguish between manual fence resulted..
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Distinguish between manual fence resulted..
......................................................................
core: Distinguish between manual fence resulted..
Distinguish between manual fence resulted from user action and manual
fence called internally by auto fence
Manual fence currently can be executed in 2 flows
1) As part of the non responding treatment when host is restart via its
PM agent.
2) As a result of a manual host stopping and choosing "confirm Host has
been rebooted" from the right-click popup menu
The messages generated by both to the log are of the format:
Manual fence for host ${VdsName} was started.
Manual fence for host ${VdsName} failed.
When this occurs in scenario 1) above, the term "manual" in the audit
log is confusing and should be changed to reflect the fact that was done
internally by the engine code and not by the user
This patch logs different messages to the audit log when resulted from
scenario 1) above.
Change-Id: I274ec95bb3f2c217bd9871afa9d761a1b975d793
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1083750
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
3 files changed, 20 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26743
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I274ec95bb3f2c217bd9871afa9d761a1b975d793
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: [RFE] Allow to perform fence operations from...
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: [RFE] Allow to perform fence operations from...
......................................................................
[RFE] Allow to perform fence operations from...
[RFE] Allow to perform fence operations from a host in another DC
Adding to the pm_proxy_preferences field which is defaulted now to
"cluster,DC" another option named otherdc.
(The pm_proxy_preferences value is available via the UI Host New/Edit PM
TAB in the field named "source" , in the API it is under <pm_proxies>)
The default will stay "cluster,DC" and the admin can change this value
per host using the API
Feature wiki page was updated with this information:
http://www.ovirt.org/Features/Design/DetailedHostPMProxyPreferences#oVirt...
Change-Id: Ifab8ec441751a33272fd7355029295bd1141c1ac
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1054778
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PmProxyType.java
3 files changed, 29 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26513
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifab8ec441751a33272fd7355029295bd1141c1ac
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-node-plugin-vdsm[node-3.0]: ovirt-node-plugin-vdsm: Bump release to 0.1.2-0
by dougsland@redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: ovirt-node-plugin-vdsm: Bump release to 0.1.2-0
......................................................................
ovirt-node-plugin-vdsm: Bump release to 0.1.2-0
- spec: remove uneeded sed's (BZ#1088218)
- engine_page: add compatiblePort() to src
- engine_page: Display correctly proto for Manage by (BZ#1065401)
- engine_page: Remove Retrieve Certificate button (BZ#1081042)
- engine_page: network is required to register tab (BZ#1064206)
Change-Id: I3a63fbb45bf6fc2888daa3f636094a90e2a62725
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M configure.ac
M ovirt-node-plugin-vdsm.spec.in
2 files changed, 9 insertions(+), 2 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26938
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a63fbb45bf6fc2888daa3f636094a90e2a62725
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: node-3.0
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: restapi: Simplify "combine" implementation in LinkHelper
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Simplify "combine" implementation in LinkHelper
......................................................................
restapi: Simplify "combine" implementation in LinkHelper
Change-Id: I21615f3036083fef2f83cc3cbc67f678a9b406ff
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java
1 file changed, 2 insertions(+), 7 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Sergey Gotliv: Verified
--
To view, visit http://gerrit.ovirt.org/26935
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21615f3036083fef2f83cc3cbc67f678a9b406ff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-reports[master]: packaging: setup: pep8-1.5 fixups
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: pep8-1.5 fixups
......................................................................
packaging: setup: pep8-1.5 fixups
Change-Id: I993a58fd43493c0959ca3e7067ce2c97f9da5fae
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26714
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I993a58fd43493c0959ca3e7067ce2c97f9da5fae
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 8 months