April 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: system tree item selection
by awels＠redhat.com 16 Apr '14

16 Apr '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: system tree item selection ...................................................................... webadmin: system tree item selection - Automatically select the first item in a grid when refreshing the grid AND there is only one item in the grid. Change-Id: Ibee9fc961a1e65606934e4f25d4a4e6fff0024b8 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/autocomplete/SearchSuggestionDisplay.java 3 files changed, 10 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibee9fc961a1e65606934e4f25d4a4e6fff0024b8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Store rest api session id in http session
by awels＠redhat.com 16 Apr '14

16 Apr '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Store rest api session id in http session ...................................................................... webadmin: Store rest api session id in http session - REST API stores a session id for the UI plugins. Moved the session id location from LocalStorage to HTTP session. Change-Id: I6fe9af54054aefe694876b1805a4a44f9bba0482 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/CommunicationProvider.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/GWTRPCCommunicationProvider.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/OperationProcessor.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/StorageCallback.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/VdcOperationManager.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/gwtservices/GenericApiGWTService.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java 9 files changed, 183 insertions(+), 10 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fe9af54054aefe694876b1805a4a44f9bba0482 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: rename gwt-extension.
by awels＠redhat.com 16 Apr '14

16 Apr '14

Alexander Wels has submitted this change and it was merged. Change subject: engine: rename gwt-extension. ...................................................................... engine: rename gwt-extension. - Renamed gwt-extension.jar to ovirt-gwt-extension.jar Change-Id: Ic53dbae3a56e0a3451c295e05f358a8cc782df4e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1013752 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-extension/pom.xml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic53dbae3a56e0a3451c295e05f358a8cc782df4e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.4]: man page: Adding undocumented options to the man page
by sbonazzo＠redhat.com 16 Apr '14

16 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: man page: Adding undocumented options to the man page ...................................................................... man page: Adding undocumented options to the man page Completing the man page and the help text to coherently document all the command line options Bug-Url: https://bugzilla.redhat.com/951097 (cherry picked from commit 19ffd90f13416bdf029af568d68ffa72d00e3038) Change-Id: Ife72ae4b2a222937bddae01926ca3266d0536c65 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py M src/engine-image-uploader.8 2 files changed, 17 insertions(+), 11 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/26788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife72ae4b2a222937bddae01926ca3266d0536c65 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.4 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: bookmarks
by juan.hernandez＠redhat.com 15 Apr '14

15 Apr '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: bookmarks ...................................................................... restapi: bookmarks - Add support for bookmarks to the REST api. - The following URLs/verbs are now available: - /ovirt-engine/api/bookmarks (GET) get a list of book marks. - /ovirt-engine/api/bookmarks/{id} (GET) get book mark details. - /ovirt-engine/api/bookmarks/{id} (PUT) update book mark. - /ovirt-engine/api/bookmarks/{id} (DELETE) remove book mark. - /ovirt-engine/api/bookmarks (POST) add new book mark - The standard json and xml are available. The format is the following: <bookmark> <name>The name</name> <value>host.name=something</value> </bookmark> or { "name": "The name", "value": "host.name=something" } Change-Id: I068194732a45223dae22c18ffee5aaa0f3ec930d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1075556 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetBookmarkByBookmarkIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetBookmarkByBookmarkNameQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/BookmarkResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/BookmarksResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ApiRootLinksCreator.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/jyaml.yml M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendBookmarkResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendBookmarksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendBookmarkResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendBookmarksResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/BookmarkMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/BookmarkMapperTest.java 19 files changed, 717 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Alexander Wels: Verified -- To view, visit http://gerrit.ovirt.org/26769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I068194732a45223dae22c18ffee5aaa0f3ec930d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[master]: Modifying ovirt snapshot repo name
by sbonazzo＠redhat.com 15 Apr '14

15 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Modifying ovirt snapshot repo name ...................................................................... Modifying ovirt snapshot repo name * Also changed from https to https fedora repo to avoid issues with * tunnels Change-Id: I7423620793fd290dcebc846f46a8b0ee84b15e00 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M centos/kickstart/ovirt-live-base.ks.in 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved David Caro: Verified -- To view, visit http://gerrit.ovirt.org/26784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7423620793fd290dcebc846f46a8b0ee84b15e00 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Return additional info for 400 messages
by juan.hernandez＠redhat.com 15 Apr '14

15 Apr '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Return additional info for 400 messages ...................................................................... restapi: Return additional info for 400 messages This was already done for JAXB exceptions, but is missing for RESTEasy JAXB marshall exceptions. Change-Id: I31a7a5f487c662cbcba3734153e9fcb120ba330d Bug-Url: https://bugzilla.redhat.com/867794 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/JaxbExceptionMapper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/JaxbMarshallExceptionMapper.java 2 files changed, 7 insertions(+), 11 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31a7a5f487c662cbcba3734153e9fcb120ba330d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[master]: sdk: Check SSL server name
by juan.hernandez＠redhat.com 15 Apr '14

15 Apr '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Check SSL server name ...................................................................... sdk: Check SSL server name Currently we don't check that the host name provided in the URL matches the host name contained in the server certificate. This is a common feature of most SSL clients, but it isn't well supported by the SSL implementation in Python 2.6. To improve security this patch explicitly checks the host name given in the URL against the subject common name attribute and the subject alternative names extension. This check will be enabled by default and disabled when using "insecure=True" in the constructor of the entry point object. Change-Id: I6a08179288fd564fbb79f5731c3e32251e560d81 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtsdk/web/connection.py M src/ovirtsdk/web/httpsconnection.py 2 files changed, 107 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a08179288fd564fbb79f5731c3e32251e560d81 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-image-uploader[master]: man page: Adding undocumented options to the man page
by sbonazzo＠redhat.com 15 Apr '14

15 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: man page: Adding undocumented options to the man page ...................................................................... man page: Adding undocumented options to the man page Completing the man page and the help text to coherently document all the command line options Change-Id: I43f1e4a3e9a82bc1e907a1362d5f54ed3dc041a1 Bug-Url: https://bugzilla.redhat.com/951097 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py M src/engine-image-uploader.8 2 files changed, 25 insertions(+), 20 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/26785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43f1e4a3e9a82bc1e907a1362d5f54ed3dc041a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-log-collector[master]: nit: pep8 fixes
by sbonazzo＠redhat.com 15 Apr '14

15 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: nit: pep8 fixes ...................................................................... nit: pep8 fixes Change-Id: I1e1b39482b6c94150a69bada02cd80d95505a3ae Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py M src/sos/plugins/engine.py M src/sos/plugins/ovirt_engine_dwh.py M src/sos/plugins/ovirt_engine_reports.py 4 files changed, 39 insertions(+), 39 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e1b39482b6c94150a69bada02cd80d95505a3ae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0