May 2014 - Engine-commits - oVirt List Archives

Change in ovirt-node-plugin-vdsm[master]: engine_page: replace netinfo to xmlrpc
by dougsland＠redhat.com 18 May '14

18 May '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: replace netinfo to xmlrpc ...................................................................... engine_page: replace netinfo to xmlrpc Currently ovirt-node-plugin-vdsm uses vdsm netinfo module to consult data. However, if for some reason the connection between vdsm and libvirt is not available vdsm kills the caller. This patch will replace the uses of netinfo to use xmlrpc via vdscli module. Change-Id: I2a1243342a5f46861940dda353798e3413587969 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1097645 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 19 insertions(+), 8 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27779 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a1243342a5f46861940dda353798e3413587969 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core : Allow redirection of all logs using extension
by yzaslavs＠redhat.com 17 May '14

17 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core : Allow redirection of all logs using extension ...................................................................... core : Allow redirection of all logs using extension A custom handler in a new module org.ovirt.engine.core.logger handles all logging using extensions. Change-Id: Ia0dae8ffe53c3489af06d6684c72e6b431002404 Bug-Url: https://bugzilla.redhat.com/1078738 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/logger/Logger.java A backend/manager/modules/logger/pom.xml A backend/manager/modules/logger/src/main/java/org/ovirt/engine/core/logger/LoggerHandler.java A backend/manager/modules/logger/src/main/modules/org/ovirt/engine/core/logger/main/module.xml M backend/manager/modules/pom.xml M packaging/services/ovirt-engine/ovirt-engine.xml.in 6 files changed, 177 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ravi Nori: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0dae8ffe53c3489af06d6684c72e6b431002404 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: GetHostListFromExternalProvider test asserts
by amureini＠redhat.com 17 May '14

17 May '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetHostListFromExternalProvider test asserts ...................................................................... core: GetHostListFromExternalProvider test asserts Use proper JUnit assertEquals statements instead of Java's asserts. Change-Id: I3a542ca5cb806a931f4606312932d2de22cbf4cf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetHostListFromExternalProviderQueryTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a542ca5cb806a931f4606312932d2de22cbf4cf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ActionGroupDAOTest#testRemoveActionVersionMap
by amureini＠redhat.com 17 May '14

17 May '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: ActionGroupDAOTest#testRemoveActionVersionMap ...................................................................... core: ActionGroupDAOTest#testRemoveActionVersionMap The current implementation of this test removes existingActionMap from the database. Since there is no rollback performed between tests, and since other tests in this class assume this object will be present in the database, this implementation caused sporadic failures on various environments [1], depending on the order the tests were executed. This patch rewrites the test to be safer. It now creates a dummy record in the table, inserts it (and asserts it was indeed inserted), and then removes it (again, asserting it was properly removed). [1] Details of the system where a failure was spotted: Apache Maven 3.0.4 (r1232337; 2012-01-17 10:44:56+0200) Maven home: /usr/local/apache-maven-3.0.4 Java version: 1.7.0_51, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-1.7.0-openjdk-1.7.0.51.x86_64/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "2.6.32-431.11.2.el6.x86_64", arch: "amd64", family: "unix" Change-Id: Icba824009bec7763c38b3040eb9b1be88558f037 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ActionGroupDAOTest.java 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icba824009bec7763c38b3040eb9b1be88558f037 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: extapi: add extension notes field
by yzaslavs＠redhat.com 17 May '14

17 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: extapi: add extension notes field ...................................................................... extapi: add extension notes field extra information extension would like to present, such as display version, build options. Change-Id: I2d061a08531849b5d85af9c8e403f73f89497304 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java 2 files changed, 9 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d061a08531849b5d85af9c8e403f73f89497304 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: packaging: fix conflicts with ovirt-release34
by sbonazzo＠redhat.com 16 May '14

16 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: fix conflicts with ovirt-release34 ...................................................................... packaging: fix conflicts with ovirt-release34 fixes file /etc/pki/rpm-gpg/RPM-GPG-ovirt from install of ovirt-release35-001-0.0.alpha1.noarch conflicts with file from package ovirt-release34-1.0.0-1.noarch Change-Id: I0b07bd273b9dc88224d4582e3d9c976230ce0c73 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-release-3.5/ovirt-release35.spec.in M ovirt-release-3.5/ovirt.repo.in 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve David Caro: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b07bd273b9dc88224d4582e3d9c976230ce0c73 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fixed right-click context menu spacing
by awels＠redhat.com 16 May '14

16 May '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fixed right-click context menu spacing ...................................................................... webadmin: fixed right-click context menu spacing PatternFly patch caused the right-click context menu spacing to be 2 pixels too much. Fixed. Change-Id: I69b9d04fb18fa77ce3760ce6ca97c45dd6638bbb Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/WebAdmin.css 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/27761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69b9d04fb18fa77ce3760ce6ca97c45dd6638bbb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fixed misc broken spacings
by awels＠redhat.com 16 May '14

16 May '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fixed misc broken spacings ...................................................................... webadmin: fixed misc broken spacings PatternFly introduced border-box model which breaks hardcoded cell spacings and paddings. Added some css classes to fix, and changed attributes and method calls for spacings and paddings to use the css classes. Change-Id: Ifdf31a1ffe7698c08e9fbfc008c75ae9c03ecc56 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/GlusterHookResolveConflictsPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/MultipleHostsPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/BondPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkLabelPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NicPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/UnassignedNetworksPanel.java M packaging/branding/ovirt.brand/patternfly-custom-hacks.css 10 files changed, 49 insertions(+), 18 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdf31a1ffe7698c08e9fbfc008c75ae9c03ecc56 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fixed contrast issue in search bar prefix label
by awels＠redhat.com 16 May '14

16 May '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fixed contrast issue in search bar prefix label ...................................................................... webadmin: fixed contrast issue in search bar prefix label PatternFly update introduced a change to the search bar, and the prefix label was hard to read because it was gray on gray. This updates that label to be black text in a light gray box, which is much easier to read. Change-Id: I50cc91a5943f350291b5e1d8938a0912dbe30a7b Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/SearchPanelView.ui.xml M packaging/branding/ovirt.brand/patternfly-custom-hacks.css 2 files changed, 23 insertions(+), 8 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/27701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50cc91a5943f350291b5e1d8938a0912dbe30a7b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: build: ovirt-release35-001_alpha1
by sbonazzo＠redhat.com 16 May '14

16 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-release35-001_alpha1 ...................................................................... build: ovirt-release35-001_alpha1 Provide oVirt pre release repository for oVirt 3.5.0 alpha1 Change-Id: If75f973c737818a113a6e79a641c12773419af45 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M .gitignore A ovirt-release-3.5/Makefile.am A ovirt-release-3.5/RPM-GPG-ovirt A ovirt-release-3.5/autogen.sh A ovirt-release-3.5/configure.ac A ovirt-release-3.5/ovirt-el-deps.repo.in A ovirt-release-3.5/ovirt-f19-deps.repo.in A ovirt-release-3.5/ovirt-release35.spec.in A ovirt-release-3.5/ovirt.repo.in 9 files changed, 262 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve David Caro: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27755 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If75f973c737818a113a6e79a641c12773419af45 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0