May 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: aaa: Introduce application_name key
by yzaslavs＠redhat.com 15 May '14

15 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Introduce application_name key ...................................................................... aaa: Introduce application_name key Change-Id: I6ba68584362c85b1e73763ab07cb41c792c0254b Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java 3 files changed, 19 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ba68584362c85b1e73763ab07cb41c792c0254b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: VdsNotRespondingTreatment Job is not marked as finished.
by emesika＠redhat.com 15 May '14

15 May '14

Eli Mesika has submitted this change and it was merged. Change subject: core: VdsNotRespondingTreatment Job is not marked as finished. ...................................................................... core: VdsNotRespondingTreatment Job is not marked as finished. When a hypervisor gets into non responding state and it is fenced the job VdsNotRespondingTreatment is not marked as finished and get stuck in the tasks list. Change-Id: I956c8f8d51e8c9569013973044494a8c95a58454 Bug-Url: https://bugzilla.redhat.com/1075500 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Liran Zelkha: Verified Yair Zaslavsky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I956c8f8d51e8c9569013973044494a8c95a58454 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: uutils: fix typo
by yzaslavs＠redhat.com 15 May '14

15 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: uutils: fix typo ...................................................................... uutils: fix typo Change-Id: Ie03ace70dafbd9fab6889efbb3b9c3e46265606c Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsArguments.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/ArgumentBuilder.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/cli/ArgumentBuilderTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/cli/ExtendedCliParserTest.java 4 files changed, 18 insertions(+), 18 deletions(-) Approvals: Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie03ace70dafbd9fab6889efbb3b9c3e46265606c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: frontend: rename Pool to Type in vm popup widget
by tjelinek＠redhat.com 15 May '14

15 May '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: rename Pool to Type in vm popup widget ...................................................................... frontend: rename Pool to Type in vm popup widget This small patch renames "Pool" label to "Type" in side tabs of vm popup widget. Change-Id: I94573205659f7411cf882ff23eeb73b343d4c39a Bug-Url: https://bugzilla.redhat.com/1092379 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/27727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94573205659f7411cf882ff23eeb73b343d4c39a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: set 'preferred' as default numa tune mode
by ahadas＠redhat.com 15 May '14

15 May '14

Arik Hadas has submitted this change and it was merged. Change subject: core: set 'preferred' as default numa tune mode ...................................................................... core: set 'preferred' as default numa tune mode Set 'preferred' as numa tune mode for VMs that were created before Numa was supported Change-Id: I441c53d686513f73ff2ee4acb6946021f507bef8 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- A packaging/dbscripts/upgrade/03_05_0450_set_default_value_for_numa_tune_mode.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/27721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I441c53d686513f73ff2ee4acb6946021f507bef8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: [RFE] Add periodic power management health check..
by emesika＠redhat.com 15 May '14

15 May '14

Eli Mesika has submitted this change and it was merged. Change subject: [RFE] Add periodic power management health check.. ...................................................................... [RFE] Add periodic power management health check.. Add periodic power management health check to detect/warn about link-down detection of power management Feature pages: http://www.ovirt.org/Features/PMHealthCheck http://www.ovirt.org/index.php?title=Features/Design/DetailedPMHealthCheck Change-Id: Ib1dfeab92a35793ebb421db8e3be94587dfe85e2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1090800 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AlertDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 8 files changed, 150 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1dfeab92a35793ebb421db8e3be94587dfe85e2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add time tolerance to websocket proxy
by sbonazzo＠redhat.com 15 May '14

15 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: add time tolerance to websocket proxy ...................................................................... core: add time tolerance to websocket proxy This small patch adds 5 second tolerance to the past in ovirt-websocket-proxy. This is to prevent really small time drifts between clocks of the engine and the machine where the proxy is deployed in situations when the proxy clock is ahead of the engine clock (and therefore the ticket is not yet valid from the proxy POV). Change-Id: I811f6c3c4413576c1dc8d209408767367b3687ad Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1052921 --- M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/27643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I811f6c3c4413576c1dc8d209408767367b3687ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: return an unmodifiable map for ShellLikeConfd.getProp...
by oourfali＠redhat.com 15 May '14

15 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: utils: return an unmodifiable map for ShellLikeConfd.getProperties() ...................................................................... utils: return an unmodifiable map for ShellLikeConfd.getProperties() Without wrapping users can unexpectedly change internal values after calling getProperties(). Change-Id: I33c5e05b5e433634575285e19b435127dd0ae968 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33c5e05b5e433634575285e19b435127dd0ae968 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fixed header position in Hosts > Network subtab
by alkaplan＠redhat.com 15 May '14

15 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: fixed header position in Hosts > Network subtab ...................................................................... webadmin: fixed header position in Hosts > Network subtab PatternFly patch caused the header to be badly positioned in Hosts > Network Interfaces subtab, only in Firefox. It was a div clear issue. Fixed. Change-Id: I1db1830a203cb8c4ebb3b6d7c140676213506b35 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.ui.xml 1 file changed, 101 insertions(+), 97 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/27710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1db1830a203cb8c4ebb3b6d7c140676213506b35 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: fix coverity issues
by yzaslavs＠redhat.com 15 May '14

15 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: fix coverity issues ...................................................................... aaa: fix coverity issues Change-Id: I057929e0f2dc7672bc5d06457d14c548f4726112 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Domain.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/SimpleLdapTemplateWrapper.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/RootDSEData.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/DetectMixedMode.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KrbConfCreator.java 7 files changed, 99 insertions(+), 88 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I057929e0f2dc7672bc5d06457d14c548f4726112 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0