Change in samples-uiplugins[master]: gluster-nagios-monitoring : messageOrigin url formation fixed
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: gluster-nagios-monitoring : messageOrigin url formation fixed
......................................................................
gluster-nagios-monitoring : messageOrigin url formation fixed
This patch fixes the message origin url formation by appending
the port address to the url if and only if the the $location has
port address and the port address is present in the $location
absolute url.
Change-Id: I2dd11b3accc83fe4a603a930c4fcaf9c3261a271
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M gluster-nagios-monitoring/src/js/dashboard-init.js
M gluster-nagios-monitoring/src/js/trends.js
2 files changed, 20 insertions(+), 22 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27396
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2dd11b3accc83fe4a603a930c4fcaf9c3261a271
Gerrit-PatchSet: 5
Gerrit-Project: samples-uiplugins
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
10 years, 4 months
Change in ovirt-engine[master]: restapi: Split SELinuxMode enum between businessentities and...
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Split SELinuxMode enum between businessentities and models.
......................................................................
restapi: Split SELinuxMode enum between businessentities and models.
In the patch that introduced the SELinuxMode, same enum was used for
both backend and restapi. This change splits the 2 enums so each may
implement the functionality it needs in api/backend.
Change-Id: I5c09dfcb89f8cdd4c75d8215693779157bf2cd8e
Signed-off-by: Dima Kuznetsov <dkuznets(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SELinuxMode.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/SELinuxMode.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
4 files changed, 32 insertions(+), 7 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Dima Kuznetsov: Verified
--
To view, visit http://gerrit.ovirt.org/27625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c09dfcb89f8cdd4c75d8215693779157bf2cd8e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: suppress logging of VM password
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: suppress logging of VM password
......................................................................
packaging: setup: suppress logging of VM password
Also use LOG_FILTER_KEYS for other cases, so that we can do that
right at the beginning.
Bug-Url: https://bugzilla.redhat.com/1096838
Change-Id: I92ef0a1516d7a6dd70d3fd53ceac3c71ce1eaf24
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M ovirt-hosted-engine-setup.spec.in
M src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py
M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py
M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
4 files changed, 12 insertions(+), 7 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/27591
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92ef0a1516d7a6dd70d3fd53ceac3c71ce1eaf24
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin, userportal: Support column sorting
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Support column sorting
......................................................................
webadmin,userportal: Support column sorting
This patch introduces support for both server-side
and client-side sorting of UI table columns.
Similar to column resize feature, column sorting
must be enabled per-column for the given table.
SortableColumn provides API to enable both kinds
of sorting (this patch makes TextColumnWithTooltip
extend SortableColumn, we might want to do this
for more custom column types if necessary):
// Enables server-side sorting via search query
// ... SORTBY name ASC|DESC
column.makeSortable('name');
// Enables client-side sorting using comparator
column.makeSortable(comparator);
In order for server-side sorting to work properly,
corresponding SearchableListModel must apply the
search options while executing "Search" query.
For example, in DataCenterListModel:
@Override
public boolean supportsServerSideSorting() {
return true;
}
@Override
protected void syncSearch() {
String search;
// search = getSearchString();
search = applySortOptions(getSearchString());
...
}
If a model doesn't support server-side sorting,
client-side sorting will be used as fall back.
It is the responsibility of UI developers to
ensure that columns marked as sortable are in
sync with sorting capability of the given model,
i.e. if the model doesn't support server-side
sorting, comparator must be used.
Change-Id: I141ea068fe90409852d34bea6fedb45d0d8a07ae
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ObjectUtils.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SortableColumn.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextColumnWithTooltip.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/HasResizableColumns.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ResizableHeader.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SortedListModel.java
9 files changed, 294 insertions(+), 88 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25910
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I141ea068fe90409852d34bea6fedb45d0d8a07ae
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin: Fix raw type warning in EntityModelWidgetWithInfo
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: webadmin: Fix raw type warning in EntityModelWidgetWithInfo
......................................................................
webadmin: Fix raw type warning in EntityModelWidgetWithInfo
Change-Id: If629a8bfced240486d3831357a538d9de3601fb4
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/NeutronAgentWidget.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Lior Vernia: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/27605
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If629a8bfced240486d3831357a538d9de3601fb4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: engine: Introduce RabbitMQ broker type
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Introduce RabbitMQ broker type
......................................................................
engine: Introduce RabbitMQ broker type
RabbitMQ is a popular messaging broker which is
being supported by OpenStack. oVirt engine should
support configuring RabbitMQ in addition to Qpid,
so users can select their desired messaging broker.
Change-Id: Ic3fa551c1d416a53df47e940518c933722a80867
Bug-Url: https://bugzilla.redhat.com/1078862
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
3 files changed, 11 insertions(+), 2 deletions(-)
Approvals:
Lior Vernia: Looks good to me, but someone else must approve
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27568
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3fa551c1d416a53df47e940518c933722a80867
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: hardening postgresql password
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: hardening postgresql password
......................................................................
packaging: setup: hardening postgresql password
Use random.SystemRandom instead of random and
extend password lenght to 22 chars in order to have at least 128 bits of entropy.
Change-Id: I76769e7eb65df35f982b1ef9e36bc81d1f42b79a
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit 78d5316978a2a078683819a94891d09d403d46b0)
---
M packaging/setup/ovirt_engine_setup/postgres.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27633
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I76769e7eb65df35f982b1ef9e36bc81d1f42b79a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
10 years, 4 months
Change in ovirt-engine[master]: packaging: setup: hardening postgresql password
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: hardening postgresql password
......................................................................
packaging: setup: hardening postgresql password
Use random.SystemRandom instead of random and
extend password lenght to 22 chars in order to have at least 128 bits of entropy.
Change-Id: I76769e7eb65df35f982b1ef9e36bc81d1f42b79a
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/postgres.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
Michael Samuel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/27615
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I76769e7eb65df35f982b1ef9e36bc81d1f42b79a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Samuel <mik(a)miknet.net>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: engine: Extract Qpid specific notation
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Extract Qpid specific notation
......................................................................
engine: Extract Qpid specific notation
The Qpid notation within host installation module is
being extracted to enable additional broker type to be
supported (i.e. RabbitMQ which is introduced in the next
patch).
Change-Id: I74eadd63cb66231ee240792cebca83d19db9bccb
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java
2 files changed, 54 insertions(+), 12 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/27567
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74eadd63cb66231ee240792cebca83d19db9bccb
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin: fixed Coverity Scan errors
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: fixed Coverity Scan errors
......................................................................
webadmin: fixed Coverity Scan errors
removed some NPE vulnerabilities and unchecked casts
Change-Id: I9e3a6438f23c530e637d557039131442ea3a73e3
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CustomInstanceType.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
3 files changed, 19 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Verified
Alexander Wels: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27450
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e3a6438f23c530e637d557039131442ea3a73e3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months