May 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: resolve duplicate upgrade script
by emesika＠redhat.com 28 May '14

28 May '14

Eli Mesika has submitted this change and it was merged. Change subject: core: resolve duplicate upgrade script ...................................................................... core: resolve duplicate upgrade script Change-Id: Ie71a4717c2c79beebab935a47e1e952afb05b6dc Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- R packaging/dbscripts/upgrade/03_05_0530_remove_unused_event.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie71a4717c2c79beebab935a47e1e952afb05b6dc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: removing unused event from DB
by emesika＠redhat.com 28 May '14

28 May '14

Eli Mesika has submitted this change and it was merged. Change subject: core: removing unused event from DB ...................................................................... core: removing unused event from DB This patch removes the VDS_INITIATED_RUN_VM_FAIL event which was replaced with the VDS_INITIATED_RUN_VM_FAILED event. The patch that introduced the event rename did not clean the old name from the event_map table. Change-Id: I199843e37254fee058147795683dce58c3475a55 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072527 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- A packaging/dbscripts/upgrade/03_05_0510_remove_unused_event.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28158 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I199843e37254fee058147795683dce58c3475a55 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: post 3.4.2 branching
by oourfali＠redhat.com 28 May '14

28 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: post 3.4.2 branching ...................................................................... packaging: post 3.4.2 branching Change-Id: I75ba427635b0cecd11cf7deeec2091e440a5c76e Related-To: https://bugzilla.redhat.com/1069193 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M backend/manager/dependencies/pom.xml M backend/manager/modules/authentication/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M pom.xml M version.mak 44 files changed, 48 insertions(+), 48 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75ba427635b0cecd11cf7deeec2091e440a5c76e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix the description of two weight PolicyUnits
by dfediuck＠redhat.com 28 May '14

28 May '14

Doron Fediuck has submitted this change and it was merged. Change subject: engine: Fix the description of two weight PolicyUnits ...................................................................... engine: Fix the description of two weight PolicyUnits The description of Power Saving Weight policy unit and Even Distribution Weight policy unit was wrong. Change-Id: I2cbf1b4e1b959637293f45a4d19417f27c937bae Bug-Url: https://bugzilla.redhat.com/1098591 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- A packaging/dbscripts/upgrade/03_05_0520_fix_description_of_balancing_policy_units.sql 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Verified Gilad Chaplik: Looks good to me, approved Kobi Ianko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28172 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cbf1b4e1b959637293f45a4d19417f27c937bae Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Replace inner variable references in failure messages
by dfediuck＠redhat.com 28 May '14

28 May '14

Doron Fediuck has submitted this change and it was merged. Change subject: webadmin: Replace inner variable references in failure messages ...................................................................... webadmin: Replace inner variable references in failure messages Currently the message processing code ignores variables that were added by expanding other variables. This is not consistent with the handling in AuditLog. This patch fixes that and makes the behaviour the same. The only risk here is that we have an expansion cycle, but that is under our control and should not happen. As an usage example think about the expansion of the following messages: "$filterType internal" "$hostName dev-03" "$filterName Network" "$networkNames test" "$detailMessage network(s) ${networkNames} are missing" "The host ${hostName} did not satisfy ${filterType} filter ${filterName} because ${detailMessage}." This is related to the our improvement of how we report scheduling failures. Change-Id: If70582ae35b8f94b4101dfc33865cc7976fd625c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1077627 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: Martin Sivák: Verified Doron Fediuck: Looks good to me, approved Kobi Ianko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If70582ae35b8f94b4101dfc33865cc7976fd625c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Improve messages in scheduling
by dfediuck＠redhat.com 28 May '14

28 May '14

Doron Fediuck has submitted this change and it was merged. Change subject: engine: Improve messages in scheduling ...................................................................... engine: Improve messages in scheduling Add a way of adding more detailed explanations to the host was filtered out messages. Also change the message for the situation where no host was available from the beginning. Change-Id: I0d3c4d50c3a7a8cd11b46b19c1167daace8461be Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1077627 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CPUPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuLevelFilterPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/HostedEngineHAClusterFilterPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MemoryPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MigrationPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PinToHostPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityWeightPolicyUnit.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/PerHostMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/PolicyUnit.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 18 files changed, 196 insertions(+), 49 deletions(-) Approvals: Martin Sivák: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d3c4d50c3a7a8cd11b46b19c1167daace8461be Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Change how Affinity behaves if the assumptions are inv...
by dfediuck＠redhat.com 28 May '14

28 May '14

Doron Fediuck has submitted this change and it was merged. Change subject: core: Change how Affinity behaves if the assumptions are invalid ...................................................................... core: Change how Affinity behaves if the assumptions are invalid This fixes the situation when VMs belonging to the same hard constraint positive affinity group are actually running on more than one host. It used to fail the scheduling task for any VM belonging to the same affinity group (both new VMs and migrating ones). This patch just passes all hosts with VM from that group to the weighting mechanism making it possible for the balancer or administrator to recover from this situation. This change also makes it easier to report per host scheduling information which we need for the following patches. Change-Id: I506bcb6e96c622694e6bf7b8ce7a0f54a82e5713 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1080521 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java 1 file changed, 43 insertions(+), 48 deletions(-) Approvals: Martin Sivák: Verified Jiří Moskovčák: Looks good to me, but someone else must approve Doron Fediuck: Looks good to me, approved Kobi Ianko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I506bcb6e96c622694e6bf7b8ce7a0f54a82e5713 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: support custom preview snapshot
by derez＠redhat.com 28 May '14

28 May '14

Daniel Erez has submitted this change and it was merged. Change subject: restapi: support custom preview snapshot ...................................................................... restapi: support custom preview snapshot Accept optional 'restore_memory' and 'disks' tags in preview_snapshot action. Preview Snapshot: POST /api/vms/{vm_id}/preview_snapshot <action> <snapshot id="{snapshot_id}"/> <restore_memory>true|false</restore_memory> <disks> <disk id="{disk_id}"> <image_id>{image_id}</image_id> <snapshot id="{snapshot_id}"/> </disk> </disks> </action> Feature-Page: http://www.ovirt.org/Features/Single_Disk_Snapshot#REST-API Change-Id: I89d004dec75aa23c6a7105ddb064e93d7f4652ed Bug-Url: https://bugzilla.redhat.com/1095494 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java 3 files changed, 8 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89d004dec75aa23c6a7105ddb064e93d7f4652ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Wait before clearing gluster tasks
by ofrenkel＠redhat.com 28 May '14

28 May '14

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Wait before clearing gluster tasks ...................................................................... engine: Wait before clearing gluster tasks Introduced a wait time before clearing any orphan gluster tasks to take care of possible race condition in returning task list from gluster CLI Change-Id: I3a8a4878abb7ef46adedfdb099404884419f89de Bug-Url: https://bugzilla.redhat.com/1065227 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJobTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 4 files changed, 37 insertions(+), 11 deletions(-) Approvals: Sahina Bose: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a8a4878abb7ef46adedfdb099404884419f89de Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: simplify CommonVmPoolWithVmsCommand#executeCommand
by ofrenkel＠redhat.com 28 May '14

28 May '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: simplify CommonVmPoolWithVmsCommand#executeCommand ...................................................................... core: simplify CommonVmPoolWithVmsCommand#executeCommand The method CommonVmPoolWithVmsCommand#executeCommand was too long with a lot of responsibilities inside. This patch extracts the name generation for the VMs and the creation of the parameters for AddVmAndAttachToPool to separate methods. In addition, we are now taking the pool's name from the VmPool object in the parameters class as we should do, and not from the VM object. Change-Id: I10b7bd20780f734cbe7c9b7c102b2e5442a722ac Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NameForVmInPoolGenerator.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NameForVmInPoolGeneratorTest.java 3 files changed, 83 insertions(+), 45 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/26363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10b7bd20780f734cbe7c9b7c102b2e5442a722ac Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0