Change in ovirt-engine[master]: webadmin: warning on move disks from file to block
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: warning on move disks from file to block
......................................................................
webadmin: warning on move disks from file to block
Moving raw/thin disks that reside on a file domain
to a block domain will cause them to become preallocated.
Hence, it may consume considerably more space on
the target domain. To warn the user, added an
appropriate message to the move disks dialog.
Screenshot - http://i.imgur.com/gyMwXy9.jpg
Change-Id: I08fb316c76a9132467d26bbc5305a30a9883d38e
Bug-Url: https://bugzilla.redhat.com/1099083
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelTextAreaLabel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MoveDiskModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml
6 files changed, 153 insertions(+), 5 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27916
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08fb316c76a9132467d26bbc5305a30a9883d38e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: extract PrepareSnapshotConfig method to ImagesHandler
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: extract PrepareSnapshotConfig method to ImagesHandler
......................................................................
core: extract PrepareSnapshotConfig method to ImagesHandler
Extracted PrepareSnapshotConfigWithoutImageSingleImage
from BaseImagesCommand into ImagesHandler for reusability
in other commands.
Change-Id: I8c5e8d2763df3bcf18fb13a030148de352f57846
Bug-Url: https://bugzilla.redhat.com/1056935
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveImageCommandTest.java
5 files changed, 50 insertions(+), 50 deletions(-)
Approvals:
Daniel Erez: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c5e8d2763df3bcf18fb13a030148de352f57846
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in otopi[master]: readme.dialog: fixed typo and improved CLI section
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: readme.dialog: fixed typo and improved CLI section
......................................................................
readme.dialog: fixed typo and improved CLI section
Added info how to prompt command line interface.
Change-Id: I19922b07813604d97797eb8351351597b2c69e72
Signed-off-by: Lukas Bednar <lbednar(a)redhat.com>
---
M README.dialog
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28167
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19922b07813604d97797eb8351351597b2c69e72
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Lukas Bednar <lbednar(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[master]: webadmin: VM dialog - organize resource allocation section
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: VM dialog - organize resource allocation section
......................................................................
webadmin: VM dialog - organize resource allocation section
VM dialog -> Resource Allocation:
To improve tab display, added 'Disks Allocation'
section which contains disks related widgets:
- Disks table.
- VirtIO-SCSI checkbox.
Screenshot: http://i.imgur.com/J5TypMQ.jpg
Change-Id: Ic16354dcfc7cc50a8e1969b54e0ca32722e54e8f
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
2 files changed, 23 insertions(+), 26 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28080
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic16354dcfc7cc50a8e1969b54e0ca32722e54e8f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: disable format selection on thin provisioning
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: disable format selection on thin provisioning
......................................................................
webadmin: disable format selection on thin provisioning
VM dialog -> resource allocation:
disk format should be unchangeable when storage
thin provisioning is selected (changing format is
applicable only on clone template provisioning).
Change-Id: I6b270bb753bcceb4c085db79e413cf9ed3bc04e3
Bug-Url: https://bugzilla.redhat.com/1101003
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/28079
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b270bb753bcceb4c085db79e413cf9ed3bc04e3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: custom preview dialog - close on success
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: custom preview dialog - close on success
......................................................................
webadmin: custom preview dialog - close on success
Custom preview dialog:
close dialog only on return value success;
i.e. keep dialog open after canDoAction popup
(to allow selection amend).
Change-Id: I7c35c03bd1fdd7b8b2a46c7ff7596d344ab729e0
Related-To: https://bugzilla.redhat.com/1096884
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/27818
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c35c03bd1fdd7b8b2a46c7ff7596d344ab729e0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: adding DAO support for unregistered VMs/Templates.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: adding DAO support for unregistered VMs/Templates.
......................................................................
core: adding DAO support for unregistered VMs/Templates.
* Add new BE OvfEntityData
* Adding new table unregistered_ovf_of_entities
* Add stored procedures support
* Adding UnregisteredOVFDataDAO and implementation
This patch is part of the feature ImportStorageDomain
(see http://www.ovirt.org/Features/ImportStorageDomain)
Change-Id: I385fac757f46131ae0c0048b6cf39b78f037e852
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OvfEntityData.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAO.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
A packaging/dbscripts/unregistered_OVF_data_sp.sql
A packaging/dbscripts/upgrade/03_05_0510_unregistered_ovf_of_entities.sql
9 files changed, 498 insertions(+), 1 deletion(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26480
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I385fac757f46131ae0c0048b6cf39b78f037e852
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: Add snapshot to the OVF generation
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add snapshot to the OVF generation
......................................................................
core: Add snapshot to the OVF generation
Adding also snapshots when building the VM OVF.
We are already incrementing the generation in the end command when
deleting/creating a new snapshot
Change-Id: I8ba05c2e362fb9b22d6b4fb5a14698ad99d7bd1e
Bug-Url: https://bugzilla.redhat.com/1069780
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/OvfDataUpdaterTest.java
3 files changed, 71 insertions(+), 26 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified; Looks good to me, approved
Liron Ar: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/25947
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ba05c2e362fb9b22d6b4fb5a14698ad99d7bd1e
Gerrit-PatchSet: 35
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: Detach storage domain when remove Storage Pool.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Detach storage domain when remove Storage Pool.
......................................................................
core: Detach storage domain when remove Storage Pool.
Allowing to detach domain with entities when removing Storage Pool.
The entities (VM/Template/Disks) should be removed from the setup and
only the VMs/Templates' OVF, should be part of the unregistered table.
Change-Id: I120c6b001a197e65528edb73375b379f76d24cd5
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 3 insertions(+), 36 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27307
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I120c6b001a197e65528edb73375b379f76d24cd5
Gerrit-PatchSet: 25
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: Support detach Storage Domain containing entities.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Support detach Storage Domain containing entities.
......................................................................
core: Support detach Storage Domain containing entities.
Adding support for detaching a Data Storage Domain which contains disks, VMs
or Templates.
We should not allow detach of Storage Domain if it contains VM from
pools or VM in preview.
When detaching a Storage Domain, disk snapshots/shareable disks will not be saved
since they are not contained in the OVF.
This patch is part of the feature ImportStorageDomain
(see http://www.ovirt.org/Features/ImportStorageDomain)
Change-Id: I971fe6acd4a2667a09487c5e1108cf7c759587f1
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M packaging/dbscripts/disk_images_sp.sql
M packaging/dbscripts/storages_sp.sql
M packaging/dbscripts/vm_templates_sp.sql
M packaging/dbscripts/vms_sp.sql
23 files changed, 391 insertions(+), 38 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24286
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I971fe6acd4a2667a09487c5e1108cf7c759587f1
Gerrit-PatchSet: 34
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
