May 2014 - Engine-commits - oVirt List Archives

Change in mom[master]: Revert "Adding support in CPU monitoring"
by alitke＠redhat.com 28 May '14

28 May '14

Adam Litke has submitted this change and it was merged. Change subject: Revert "Adding support in CPU monitoring" ...................................................................... Revert "Adding support in CPU monitoring" This reverts commit a7fa2ec418c65c881362950a4e680fa56afe63cc. Build Failure: http://jenkins.ovirt.org/job/mom_create-rpms/45/label=centos64/console Also, API was not agreed to by vdsm developers. Change-Id: If26228ca6219927534abde90ac600f1eafc7f729 Signed-off-by: Adam Litke <alitke(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/27940 --- M mom/Collectors/Collector.py D mom/Collectors/GuestCpuTune.py D mom/Collectors/HostCpu.py D mom/Controllers/CpuTune.py M mom/HypervisorInterfaces/libvirtInterface.py M mom/HypervisorInterfaces/vdsmInterface.py 6 files changed, 0 insertions(+), 225 deletions(-) Approvals: Adam Litke: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If26228ca6219927534abde90ac600f1eafc7f729 Gerrit-PatchSet: 4 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Storage main-tab - support column sorting
by derez＠redhat.com 28 May '14

28 May '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Storage main-tab - support column sorting ...................................................................... webadmin: Storage main-tab - support column sorting Applied 'makeSortable' method to columns that are supported by search mechanism. ToDo: implement custom comparators for columns that are not supported by search (e.g. 'Total Space'). Change-Id: I689c86d2fb0e0b9070434d17aa4977a64d660cc1 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StorageDomainFieldAutoCompleter.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java 3 files changed, 54 insertions(+), 32 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27658 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I689c86d2fb0e0b9070434d17aa4977a64d660cc1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: send domains map on connectStoragePool
by amureini＠redhat.com 28 May '14

28 May '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: send domains map on connectStoragePool ...................................................................... core: send domains map on connectStoragePool This patch adds the support for the new connectStoragePool API introduced in vdsm for the data center level 3.4: connectStoragePool(hostId, scsiKey, mstUUID, masterVersion, domainsMap) domainMap is a dictionary of domains UUID and their current status [Attached|Active], e.g.: domainMap = { sdUUID1: "Attached", sdUUID2: "Active", ... } Now that connectStoragePool contains all the information about the pool domains the refreshStoragePool call is obsolete and in fact in data center level 3.4 should never be used. Feature page at: http://wiki.ovirt.org/Features/StoragePool_Metadata_Removal Change-Id: Ic16034c6757959e5d0445814a8acc2221a74f6aa Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConntectVDSToPoolAndDomains.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshStoragePoolAndDisconnectAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ConnectStoragePoolVDSCommandParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/RefreshStoragePoolVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStoragePoolVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/RefreshStoragePoolVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 19 files changed, 236 insertions(+), 161 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic16034c6757959e5d0445814a8acc2221a74f6aa Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: synchronize pool storage domain operations
by amureini＠redhat.com 28 May '14

28 May '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: synchronize pool storage domain operations ...................................................................... core: synchronize pool storage domain operations Storage domain activation and deactivation were historically synchronized on the SPM. In preparation for the storage pool metadata removal we need to move this synchronization on the engine side in order to send consistent domains map information when connecting or refreshing the storage pool. Change-Id: Ie2d90d9589181802a2722b0e841a6342af0a807c Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/EventType.java 5 files changed, 65 insertions(+), 7 deletions(-) Approvals: Federico Simoncelli: Verified Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2d90d9589181802a2722b0e841a6342af0a807c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add the domain activating state
by amureini＠redhat.com 28 May '14

28 May '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: add the domain activating state ...................................................................... core: add the domain activating state This patch adds an additional "Activating" domain state used to track the ongoing operation so that we can do more informed decisions (for example building the storage pool domains map). Change-Id: I537dd962d16fa602f101b91fb68c037be4fa307d Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatus.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/StorageDomainStatus.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/StorageDomainStatusColumn.java 9 files changed, 17 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I537dd962d16fa602f101b91fb68c037be4fa307d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[master]: Fix SSO on RHEL6
by vfeenstr＠redhat.com 28 May '14

28 May '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Fix SSO on RHEL6 ...................................................................... Fix SSO on RHEL6 The new pam implementation needs the ask_secret to be answered as well. Change-Id: I21f5da545d4fa26f816c4e25c88eccb09d4cfd56 Bug-Url: https://bugzilla.redhat.com/1102095 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M gdm-plugin/gdm-ovirtcred-extension.c M gdm2-plugin/gdm-ovirtcred-extension.c 2 files changed, 15 insertions(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21f5da545d4fa26f816c4e25c88eccb09d4cfd56 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in samples-portals[master]: License, Change copyright owner
by shavivi＠redhat.com 28 May '14

28 May '14

Shahar Havivi has submitted this change and it was merged. Change subject: License, Change copyright owner ...................................................................... License, Change copyright owner Change-Id: I51e5192ab2015ff8c8b825d4cdbafde8d798686f Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M java/LICENSE M python/LICENSE M ruby/LICENSE 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51e5192ab2015ff8c8b825d4cdbafde8d798686f Gerrit-PatchSet: 2 Gerrit-Project: samples-portals Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in samples-portals[master]: Setting Apache License - Version 2.0
by shavivi＠redhat.com 28 May '14

28 May '14

Shahar Havivi has submitted this change and it was merged. Change subject: Setting Apache License - Version 2.0 ...................................................................... Setting Apache License - Version 2.0 Change-Id: I3dab8316f9d98f47e413baf82867afd925883981 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- A java/LICENSE A python/LICENSE A ruby/LICENSE 3 files changed, 39 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3dab8316f9d98f47e413baf82867afd925883981 Gerrit-PatchSet: 2 Gerrit-Project: samples-portals Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in samples-portals[master]: [userportal-basic-gtk] First commit.
by shavivi＠redhat.com 28 May '14

28 May '14

Shahar Havivi has submitted this change and it was merged. Change subject: [userportal-basic-gtk] First commit. ...................................................................... [userportal-basic-gtk] First commit. Change-Id: I90ae1b0f7f734532ea6eb1cd97ab07fed25d55e1 Signed-off-by: Amador Pahim <apahim(a)redhat.com> --- A python-gtk/LICENSE A python-gtk/README A python-gtk/dispatcher.py A python-gtk/images/linux.png A python-gtk/images/ovirt.png A python-gtk/images/rhel.png A python-gtk/images/ubuntu.png A python-gtk/images/win.png A python-gtk/userportalgtk.glade A python-gtk/userportalgtk.py 10 files changed, 879 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90ae1b0f7f734532ea6eb1cd97ab07fed25d55e1 Gerrit-PatchSet: 5 Gerrit-Project: samples-portals Gerrit-Branch: master Gerrit-Owner: Amador Pahim <apahim(a)redhat.com> Gerrit-Reviewer: Amador Pahim <apahim(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: backend: spice: add support to control the user data transfer
by ofrenkel＠redhat.com 28 May '14

28 May '14

Omer Frenkel has submitted this change and it was merged. Change subject: backend: spice: add support to control the user data transfer ...................................................................... backend: spice: add support to control the user data transfer spice supports agent based file transfer support and clipboard copy-paste. Those features are enabled by default, but can be turned off independently. This patch adds support on the backend to control those features and allows to disable them whenever it is needed. Default is enabled for backward compatibility. Change-Id: I945e6b23df2b9d0f7c18a4f1e73c64e12e9e1a78 Bug-Url: https://bugzilla.redhat.com/1082479 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/AbstractVmRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_05_0540_add_spice_transfer_toggle.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/dbscripts/vm_templates_sp.sql M packaging/dbscripts/vms_sp.sql 25 files changed, 239 insertions(+), 26 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I945e6b23df2b9d0f7c18a4f1e73c64e12e9e1a78 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0