June 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: remove RemoveVmCommand#isVmRunning
by ahadas＠redhat.com 25 Jun '14

25 Jun '14

Arik Hadas has submitted this change and it was merged. Change subject: core: remove RemoveVmCommand#isVmRunning ...................................................................... core: remove RemoveVmCommand#isVmRunning Change-Id: Icec8d587a10d76e138c09cc1b94358a359506d5a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolCommand.java 3 files changed, 5 insertions(+), 13 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icec8d587a10d76e138c09cc1b94358a359506d5a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: update task details in stop remove brick
by ofrenkel＠redhat.com 25 Jun '14

25 Jun '14

Omer Frenkel has submitted this change and it was merged. Change subject: gluster: update task details in stop remove brick ...................................................................... gluster: update task details in stop remove brick Gluster async task details like files moved, scanned, failed are not getting updated as part of task description when user tries stop or commit the operartion. This patch helps to update the task description correctly. It makes use of the task status returned as part of stop operation from gluster. Bug-Url: https://bugzilla.redhat.com/1061813 Change-Id: I90be6a98470f0cb72bc7508f2cb2364f77e02077 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CommitRemoveGlusterVolumeBricksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CommitRemoveGlusterVolumeBricksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommandTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StopRemoveGlusterVolumeBricksVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 10 files changed, 49 insertions(+), 33 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/24319 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90be6a98470f0cb72bc7508f2cb2364f77e02077 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add an audit log entry when number of LVs on a domain ...
by tnisan＠redhat.com 25 Jun '14

25 Jun '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add an audit log entry when number of LVs on a domain exceeded max ...................................................................... core: Add an audit log entry when number of LVs on a domain exceeded max When creating a new image/snapshot on a block domain, if the number of LVs on this domain exceeded the maximum value defined in the config, an audit log entry will be added to warn the admin Change-Id: Ie701a4b622b4f93690020922f96279d28903abc8 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1015186 --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CloneImageGroupStructureVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CopyImageVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateImageVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateSnapshotVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MoveImageGroupVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StorageDomainHelper.java 8 files changed, 44 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29057 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie701a4b622b4f93690020922f96279d28903abc8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Added a query to fetch the number of images in a stora...
by tnisan＠redhat.com 25 Jun '14

25 Jun '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Added a query to fetch the number of images in a storage domain ...................................................................... core: Added a query to fetch the number of images in a storage domain Change-Id: Id771444bc7d8916faa5e98fd54afb3d43157da15 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java M packaging/dbscripts/storages_sp.sql 4 files changed, 45 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id771444bc7d8916faa5e98fd54afb3d43157da15 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.3]: packaging: added release notes.
by ydary＠redhat.com 25 Jun '14

25 Jun '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: added release notes. ...................................................................... packaging: added release notes. Change-Id: I70cdfeda9411bd76fb25aa19864d61de9077d619 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-engine-dwh.spec.in 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70cdfeda9411bd76fb25aa19864d61de9077d619 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.3 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: avoid duplicates in summary
by sbonazzo＠redhat.com 25 Jun '14

25 Jun '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: avoid duplicates in summary ...................................................................... packaging: setup: avoid duplicates in summary Avoid to show duplicate entries in the summary when an env key need to be replicated in more than one package. Change-Id: I8736504372884fb6e77ba78f38a7fe24e9e793b1 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/dialog/preview.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8736504372884fb6e77ba78f38a7fe24e9e793b1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi : Fix for volume profile export to pdf
by juan.hernandez＠redhat.com 25 Jun '14

25 Jun '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi : Fix for volume profile export to pdf ...................................................................... restapi : Fix for volume profile export to pdf Fix for volume profile export to pdf Change-Id: I00353730fd70adebc4705a800515498937c85b91 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/GlusterVolumeProfileDetailsAsPdf.xsl 1 file changed, 86 insertions(+), 45 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved anmolbabu: Verified -- To view, visit http://gerrit.ovirt.org/29144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00353730fd70adebc4705a800515498937c85b91 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Fix eclipse warnings
by masayag＠redhat.com 25 Jun '14

25 Jun '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fix eclipse warnings ...................................................................... engine: Fix eclipse warnings Type safety: The expression of type Pair needs unchecked conversion to conform to Pair<VdcActionType,VdcActionParametersBase> Change-Id: Ibfe184bbf73291f56bbd340138e8cf9eea3071e3 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfe184bbf73291f56bbd340138e8cf9eea3071e3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix coverity complaints
by masayag＠redhat.com 25 Jun '14

25 Jun '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fix coverity complaints ...................................................................... engine: Fix coverity complaints CID 1223216 (#1 of 1): Using invalid iterator (INVALIDATE_ITERATOR) invalid_loop: Attempting to obtain another element from cmdCallBackMap.keySet() after it's been modified Change-Id: I5a80932a9ac16c08fac9faa290f844f22b2f0825 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a80932a9ac16c08fac9faa290f844f22b2f0825 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Implement infrastructure for default text column s...
by lvernia＠redhat.com 25 Jun '14

25 Jun '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Implement infrastructure for default text column sorting ...................................................................... webadmin: Implement infrastructure for default text column sorting The logic for sorting text columns is actually trivial, as it's already included in the column's getValue() method which renders the underlying entity. Change-Id: I0a935c42a499981d35d4725ff3b4789110fa9520 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextColumnWithTooltip.java 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Vojtech Szocs: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/28670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a935c42a499981d35d4725ff3b4789110fa9520 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0