June 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: tools : Upgrades from 3.5 on should look for Command Coordin...
by sbonazzo＠redhat.com 24 Jun '14

24 Jun '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: tools : Upgrades from 3.5 on should look for Command Coordinator related changes to Aysc Tasks ...................................................................... tools : Upgrades from 3.5 on should look for Command Coordinator related changes to Aysc Tasks >From 3.5 on Async Tasks exists in two different tables, async_tasks and command_entities. When upgrading from 3.5.x to higher versions we need to check if there any rows in command_entities table where callback_enabled is true and callback_notified is false. If there are any rows upgrades should not be allowed. Change-Id: Ib2c240301cd37df195d60fd8949cd45de78f183e Bug-Url: https://bugzilla.redhat.com/1108162 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py 1 file changed, 79 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, but someone else must approve Ravi Nori: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2c240301cd37df195d60fd8949cd45de78f183e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[master]: packaging: spec: cleanups
by sbonazzo＠redhat.com 24 Jun '14

24 Jun '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: cleanups ...................................................................... packaging: spec: cleanups Fixed rpmlint issues Change-Id: I2bba16464191bae9ac512646dcc9857b901139ea Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-log-collector.spec.in 1 file changed, 5 insertions(+), 23 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bba16464191bae9ac512646dcc9857b901139ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-image-uploader[master]: packaging: spec: cleanups
by sbonazzo＠redhat.com 24 Jun '14

24 Jun '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: cleanups ...................................................................... packaging: spec: cleanups Fixed rpmlint issues Change-Id: Ic082df9e762c1021ac523d3fb29b0bed8f12aa93 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-image-uploader.spec.in 1 file changed, 1 insertion(+), 19 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic082df9e762c1021ac523d3fb29b0bed8f12aa93 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-engine-reports-3.4]: packaging: added release notes
by ydary＠redhat.com 24 Jun '14

24 Jun '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: added release notes ...................................................................... packaging: added release notes Change-Id: I316591c4dde67694442f83a36907149b87168bc0 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-reports.spec.in 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I316591c4dde67694442f83a36907149b87168bc0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.4 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: data domain - hide import tabs when not relevant
by derez＠redhat.com 24 Jun '14

24 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: data domain - hide import tabs when not relevant ...................................................................... webadmin: data domain - hide import tabs when not relevant When a data domain doesn't contain unregistered entities (VMs/Templates), 'VM/Template import' tabs should be hidden. Change-Id: Ie8c9cef939e45d701224dc228f8fd964bd06b7bf Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8c9cef939e45d701224dc228f8fd964bd06b7bf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: StorageDomain - containsUnregisteredEntities flag
by derez＠redhat.com 24 Jun '14

24 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: core: StorageDomain - containsUnregisteredEntities flag ...................................................................... core: StorageDomain - containsUnregisteredEntities flag * Added 'containsUnregisteredEntities' flag to StorageDomain business entity for indicating an existence of unregistered VMs/Templates in the domain. * Added a relevant column in storage domains views. * Added tests to StorageDomainDAOTest. * Created an index for 'storage_domain_id' column in 'unregistered_ovf_of_entities' table. Change-Id: I436b81634786de1c56fb3a89358ee9837e82307b Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_05_0720_index_for_stoarge_domain_id_in_unregistered_ovf_of_entities.sql 6 files changed, 57 insertions(+), 9 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I436b81634786de1c56fb3a89358ee9837e82307b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove VmPoolDAO#getVmPoolMapByVmGuid
by ofrenkel＠redhat.com 24 Jun '14

24 Jun '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: remove VmPoolDAO#getVmPoolMapByVmGuid ...................................................................... core: remove VmPoolDAO#getVmPoolMapByVmGuid There is no need for this method since the VM object includes the VM's pool id. Change-Id: I67314513ed9cece3df937271c547c7286c2dd5a4 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmPoolDAOTest.java M packaging/dbscripts/vm_pool_maps_sp.sql 7 files changed, 13 insertions(+), 59 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/28865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67314513ed9cece3df937271c547c7286c2dd5a4 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: Revert Tooltip infrastructure
by alkaplan＠redhat.com 24 Jun '14

24 Jun '14

Alona Kaplan has submitted this change and it was merged. Change subject: userportal,webadmin: Revert Tooltip infrastructure ...................................................................... userportal,webadmin: Revert Tooltip infrastructure This reverts commit 6e4f68c2cdef0c8b2eb7b18893398013cd41fc98. - This significantly reduces the time GWT debug mode takes. Change-Id: I282d7e855d167e02a68b7a2b3807e20c6b78acba Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ElementAwareDecoratedPopupPanel.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/TooltipPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionButton.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/DropdownActionButton.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/InfoIcon.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelTextBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/TextBoxLabelBase.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/BaseRefreshPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractCellWithTooltip.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SafeHtmlWithSafeHtmlTooltipColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StyledImageResourceCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/LabelWithToolTip.java 12 files changed, 102 insertions(+), 392 deletions(-) Approvals: Alexander Wels: Verified Alona Kaplan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I282d7e855d167e02a68b7a2b3807e20c6b78acba Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: AsyncDataProvider - removed unused methods
by derez＠redhat.com 24 Jun '14

24 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: AsyncDataProvider - removed unused methods ...................................................................... webadmin: AsyncDataProvider - removed unused methods Removed unused methods from AsyncDataProvider. Change-Id: I60116fe63ab6999bec0f86c325a41070ee584c0d Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 0 insertions(+), 55 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/29031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60116fe63ab6999bec0f86c325a41070ee584c0d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: re-enable app mode selection
by sbonazzo＠redhat.com 24 Jun '14

24 Jun '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: re-enable app mode selection ...................................................................... packaging: setup: re-enable app mode selection re-enable app mode selection, disabled by mistake in http://gerrit.ovirt.org/28413 Change-Id: I217c9d61a012863beb6f5c4617b4fc5904cbe1fb Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M .gitignore M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/appmode.py 2 files changed, 4 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Darshan N: Verified Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I217c9d61a012863beb6f5c4617b4fc5904cbe1fb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0