Change in ovirt-engine[master]: core: fixed searching disks by creation date
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: fixed searching disks by creation date
......................................................................
core: fixed searching disks by creation date
DiskConditionFieldAutoCompleter:
'CREATION_DATE' is used as a key,
hence -> s/CREATIONDATE/CREATION_DATE
Change-Id: I33ea01be04ca435cc5d8c0dc3521d7d3f557f206
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DiskConditionFieldAutoCompleter.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/29373
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I33ea01be04ca435cc5d8c0dc3521d7d3f557f206
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: core: validation error on edit instance type
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: validation error on edit instance type
......................................................................
core: validation error on edit instance type
The default instance types has been created with min_allocated_mem set to 0
which was incorrect making inpossible to edit them (due to validation error).
Fixed by setting the same min_allocated_mem as mem_size_mb for all instance
types which has the min_allocated_mem set to 0.
Change-Id: If3692e187f04c5a8e7f8c812850cc82af7bc43ab
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_05_0740_min_allocated_memory_on_instance_type.sql
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29345
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3692e187f04c5a8e7f8c812850cc82af7bc43ab
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: core: NPE on UpdateVmCommand when deleting a cdrom from a VM...
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: NPE on UpdateVmCommand when deleting a cdrom from a VM using REST
......................................................................
core: NPE on UpdateVmCommand when deleting a cdrom from a VM using REST
The problem was that the getParameters().isBalloonEnabled() is a Boolean and
was not set (e.g. it was null) causing a NPE on autoboxing to boolean in
checkPciAndIdeLimit().
Fixed the same way as all the other devices are done (e.g.
isVirtioScsiEnabled()).
Change-Id: Ib9f9d6e47dd90d2501b43587532235d14928aa64
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29353
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9f9d6e47dd90d2501b43587532235d14928aa64
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: host-deploy: add IPTablesConfigSiteCustom vdc_option
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: host-deploy: add IPTablesConfigSiteCustom vdc_option
......................................................................
host-deploy: add IPTablesConfigSiteCustom vdc_option
enables adding site specific rules without overriding entire
configuration.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1111513
Change-Id: I713a7886216c0e868fc4bc1e77077bab6548108f
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
4 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29368
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I713a7886216c0e868fc4bc1e77077bab6548108f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: core: Throwing exception instead of handle fault
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Throwing exception instead of handle fault
......................................................................
core: Throwing exception instead of handle fault
CommandBase -> executeWithoutTransaction already handles a
VdcBLLException by calling processExceptionToClient.
So AddStorageServerConnectionCommand should throw an
exception with a right error message, and this way both UI and REST api
get the same response.
Change-Id: I3e6b8282d9e2cdd6e17f21a2ef034041d68d09fc
Bug-Url: https://bugzilla.redhat.com/1108164
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
1 file changed, 7 insertions(+), 14 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit http://gerrit.ovirt.org/29259
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e6b8282d9e2cdd6e17f21a2ef034041d68d09fc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-host-deploy[master]: core: offlinepackager: fix pep8 issue
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: offlinepackager: fix pep8 issue
......................................................................
core: offlinepackager: fix pep8 issue
Change-Id: Ib6e6eadc709742cc62828b0d50e9eaf8964f07a0
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/plugins/ovirt-host-deploy/core/offlinepackager.py
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29367
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6e6eadc709742cc62828b0d50e9eaf8964f07a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 6 months
Change in ovirt-engine[master]: jsonrpc: extend image over jsonrpc
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: jsonrpc: extend image over jsonrpc
......................................................................
jsonrpc: extend image over jsonrpc
Schema file was not consistend with API.py. All the verbs should use
the same constructor param names as it is defined in API.py.
Bug-Url: https://bugzilla.redhat.com/1113670
Change-Id: I676731e9a67e1a978aeb3ed298a7cfe0eea5184d
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I676731e9a67e1a978aeb3ed298a7cfe0eea5184d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: core: fix search of SDs when filtered by host
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: fix search of SDs when filtered by host
......................................................................
core: fix search of SDs when filtered by host
Following change-id: I862873171c6753f8c8863c10c336e981e39dc8cb,
searching storage domains by an host looks like [1].
I.e. the left outer join is being made on the storage_pool_id;
which leads to multiple records of the same storage domain
(since a data-center can contain multiple hosts).
Therefore, reverted to previous search so it looks like [2].
I.e. the join is being made on the storage domain id,
hence, ensuring a distinct result set.
Similarly, it is mandatory to revert the opposite search
(hosts by storage domain) to use 'vds_with_tags' view again.
Fixed relevant tests in SyntaxCheckerTest.
[1]
SELECT storage_domains_for_search.* FROM storage_domains_for_search
LEFT OUTER JOIN vds_with_tags ON
storage_domains_for_search.storage_pool_id=vds_with_tags.storage_pool_id
WHERE vds_with_tags.vds_name ILIKE 'host1')
ORDER BY storage_name ASC
[2]
SELECT storage_domains_for_search.* FROM storage_domains_for_search
LEFT OUTER JOIN vds_with_tags ON
storage_domains_for_search.id=vds_with_tags.storage_id
WHERE vds_with_tags.vds_name ILIKE 'host1')
ORDER BY storage_name ASC
Change-Id: I04e37501b29a17a634e31e8875d63577e5f9f401
Bug-Url: https://bugzilla.redhat.com/1113891
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java
M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java
3 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Daniel Erez: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29365
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04e37501b29a17a634e31e8875d63577e5f9f401
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: engine : Fix CTOR in StorageDomainCommandBase
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine : Fix CTOR in StorageDomainCommandBase
......................................................................
engine : Fix CTOR in StorageDomainCommandBase
StorageDomainCommandBase constructor does not pass
CommandContext to super class.
Change-Id: Ib7df161c6d5c112b9bb76ee8b43fbf6f70f37645
Bug-Url: https://bugzilla.redhat.com/1114092
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ravi Nori: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29363
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7df161c6d5c112b9bb76ee8b43fbf6f70f37645
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: core: added missing constructors to shutdown VM flows
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: added missing constructors to shutdown VM flows
......................................................................
core: added missing constructors to shutdown VM flows
Constructors were missing causing issues during VM shutdown.
Change-Id: Id8f638591b339fc87fab6b34cf72391e1a5d0ad1
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
4 files changed, 24 insertions(+), 4 deletions(-)
Approvals:
Tomas Jelinek: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29352
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8f638591b339fc87fab6b34cf72391e1a5d0ad1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months