June 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: Use configuration for Import Storage Domain

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use configuration for Import Storage Domain ...................................................................... core: Use configuration for Import Storage Domain Add a new configuration value for Import Storage Domain. Import Storage Domain should be supported only for 3.5 Data Center. Change-Id: I4b1824320223c915b97e0ea487abec285cea31e5 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 11 files changed, 48 insertions(+), 29 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b1824320223c915b97e0ea487abec285cea31e5 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Initialize entities in DB from OVF disk on attach

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Initialize entities in DB from OVF disk on attach ...................................................................... core: Initialize entities in DB from OVF disk on attach Adding VMs and Templates from the most updated OVF store disk into the unregistered entity table. The operation of this is being done when the user attach a Storage Domain to the DC. Change-Id: Ica68974916821ac1c9fbe6f43400170d19d716c9 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfParser.java 3 files changed, 133 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica68974916821ac1c9fbe6f43400170d19d716c9 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Use null check for unregistered dal insert

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use null check for unregistered dal insert ...................................................................... core: Use null check for unregistered dal insert Architeture and LowestCompVersion are not part of the OVF. This patch adds a validation so we will not get an NPE when trying to insert new VMs/Templates from the OVF disk into the DB Change-Id: I5e7328464c3038d9298723e947fbf262e74c9df6 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAODbFacadeImpl.java 1 file changed, 13 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified; Looks good to me, approved Liron Aravot: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e7328464c3038d9298723e947fbf262e74c9df6 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Adding OVF utils

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Adding OVF utils ...................................................................... core: Adding OVF utils Adding OVF utils to parse OVF strings into OvfEntityData Change-Id: I3f36ccf2f865d11ef3baa1908346aa3aab1857d5 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java 1 file changed, 86 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f36ccf2f865d11ef3baa1908346aa3aab1857d5 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Change GetStorageDomainInfo return value

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Change GetStorageDomainInfo return value ...................................................................... core: Change GetStorageDomainInfo return value Use the new attribute in StorageDomainStatic to initialize SANState instead of passing it in the Pair. Also adding storagePoolId data from VDSM to the Pair result. Change-Id: I60ca10fd579b6588d57b7ce590e424ee0f8cf75e Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetExistingStorageDomainListQuery.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetStorageDomainInfoVDSCommand.java 3 files changed, 17 insertions(+), 14 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60ca10fd579b6588d57b7ce590e424ee0f8cf75e Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Add support to convert json to Map

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add support to convert json to Map ...................................................................... core: Add support to convert json to Map Adding support to convert jspn string retrieved from OVF disk to Map. Change-Id: I31a837449de1d350dae7a94a69d5d62552474284 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/JsonHelper.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31a837449de1d350dae7a94a69d5d62552474284 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Force detach a storage domain

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Force detach a storage domain ...................................................................... core: Force detach a storage domain Adding call for force detach Storage Domain before attaching the storage domain, so the SP_UUID in the storage domain meta data will before attaching it. Change-Id: Ie75293678ab08616208128ac157426d3d98c1b77 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java 2 files changed, 77 insertions(+), 10 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie75293678ab08616208128ac157426d3d98c1b77 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Adding support for detach storage from old pool

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Adding support for detach storage from old pool ...................................................................... core: Adding support for detach storage from old pool Adding a parameter for indication when we want to detach a storage domain from its old pool in the meta data. The vdsm action forcedDetachStorageDomain has been changed to indicate that only domain with empty GUID pool id, will be forced detached in the meta data. This change in the engine is related to this change Change-Id: Ieab6d838778246c2d51b7b77ba655275016148df Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DetachStorageDomainVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DetachStorageDomainVDSCommand.java 3 files changed, 17 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieab6d838778246c2d51b7b77ba655275016148df Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Support architecture type at OvfUtils

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Support architecture type at OvfUtils ...................................................................... core: Support architecture type at OvfUtils Support set of architecture type when parsing the OVF from OVF Store disks. Change-Id: I77327c3487dc80533f6127258f05acae29914879 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java 1 file changed, 45 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77327c3487dc80533f6127258f05acae29914879 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: core: update sp to initialize OVF data

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: update sp to initialize OVF data ...................................................................... core: update sp to initialize OVF data update stored procedure at unregistered stored procedure to set the OVF data from the DB, only if the ovf_data is null. Change-Id: Ibee357b84da7fd7845792f975eaa72f99f16bd67 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAODbFacadeImpl.java M packaging/dbscripts/unregistered_OVF_data_sp.sql 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibee357b84da7fd7845792f975eaa72f99f16bd67 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 6 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits June 2014