Change in ovirt-engine[ovirt-engine-3.4]: restapi: Remove /api from snapshot metadata URL
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: restapi: Remove /api from snapshot metadata URL
......................................................................
restapi: Remove /api from snapshot metadata URL
Currently the operations related to snapshots at the VM level contain an
extra /api prefix in the specification of the URL. This confuses the
generator of the RSDL metadata and needs to be removed.
Change-Id: I672aee761ad9b310cc129ce4eabebe3745b85f59
Bug-Url: https://bugzilla.redhat.com/1101405
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 142b44a5d43631048e3d83df8a29c1bf720e037a)
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/28345
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I672aee761ad9b310cc129ce4eabebe3745b85f59
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in gerrit-admin[master]: Adapted stable branches checks and python
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Adapted stable branches checks and python
......................................................................
Adapted stable branches checks and python
- Showing contact address when login error occurs
- Adapted to new login procedures from bugzilla updates
Bug-Url hook:
- Skiping bugs out of the ovirt-related products
- If the patch is in the stable branch:
* -1 if no bug-url
* -1 if any target release incorrect
* -1 if any private bug
set_POST hook:
- Warning message when not oVirt product
- Warning message when incorrect TR for the branch
set_MODIFIED hook:
- Warning message when not oVirt product
Flow changes:
* Only one review per commit, done by the dispatcher
* Hooks must output the result on stdout and the results will be
aggregated
* Added more python libraries
* New hook that updates the external tracker metadata
* Changed the directory layout
Change-Id: I233f50c77fc2d419a5bc29b2ee5b3299c4bd6293
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
A .gitignore
D hooks/bz/change-merged.bz.set_MODIFIED
D hooks/bz/patchset-created.bz.1.bug_url
D hooks/bz/patchset-created.bz.2.add_tracker
D hooks/bz/patchset-created.bz.2.set_POST
D hooks/bz/patchset-created.bz.99.review_ok
D hooks/bz/patchset-created.warn_if_not_merged_to_previous_branch
A hooks/custom_hooks/change-abandoned.update_tracker
A hooks/custom_hooks/change-merged.set_MODIFIED
A hooks/custom_hooks/change-merged.update_tracker
A hooks/custom_hooks/patchset-created.bz.0.has_bug_url
A hooks/custom_hooks/patchset-created.bz.1.is_public
A hooks/custom_hooks/patchset-created.bz.2.correct_product
A hooks/custom_hooks/patchset-created.bz.3.correct_target_release
A hooks/custom_hooks/patchset-created.bz.98.set_POST
A hooks/custom_hooks/patchset-created.bz.99.review_ok
A hooks/custom_hooks/patchset-created.update_tracker
A hooks/custom_hooks/patchset-created.warn_if_not_merged_to_previous_branch
A hooks/custom_hooks/update_tracker
M hooks/hook-dispatcher
A hooks/lib/__init__.py
A hooks/lib/bz.py
M hooks/lib/bz.sh
M hooks/lib/conf.sh
M hooks/lib/config.py
M hooks/lib/gerrit.py
M hooks/lib/gerrit.sh
A hooks/lib/tools.py
M hooks/lib/tools.sh
29 files changed, 1,367 insertions(+), 507 deletions(-)
Approvals:
David Caro: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19600
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I233f50c77fc2d419a5bc29b2ee5b3299c4bd6293
Gerrit-PatchSet: 13
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
10 years, 7 months
Change in ovirt-engine[master]: core: Fix RunVmParams Serialization
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fix RunVmParams Serialization
......................................................................
core: Fix RunVmParams Serialization
Change-Id: Ibaf3addbc1e4f06b8beb93b8732f8723622e4ee9
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializer.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonRunVmParamsMixIn.java
3 files changed, 21 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Ravi Nori: Verified; Looks good to me, but someone else must approve
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28338
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibaf3addbc1e4f06b8beb93b8732f8723622e4ee9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: restapi: API support to query gluster volume profile info
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: API support to query gluster volume profile info
......................................................................
restapi: API support to query gluster volume profile info
Added an api to return volume profile information
/api/clusters/../glustervolumes/{id}/profilestatistics[;nfsStatistics]
which returns output in format:
<volume_profileDetails>
<brick_profileDetails>
<brick_profileDetail>
<brick><brick_dir>10.70.43.53:/bricks/b2</brick_dir></brick>
<profile_detail>
<profile_type>INTERVAL</profile_type>
<duration>348</duration>
<statistic id="fa...e"><name>total.bytes.read</name> ...</statistic>
<block_statistic>
<statistic id="c2...3"><name>block.size</name> ..</statistic>
<statistic id="23...7"><name>bytes.read</name> ...</statistic>
<statistic id="40...2"><name>bytes.write</name> ...</statistic>
</block_statistic>
<block_statistic>
...
</block_statistic>
<fop_statistic>
<name>LOOKUP</name>
<statistic id="1d...7"><name>min.latency</name>< ...</statistic>
...
<fop_statistic>
</profile_detail>
</brick_profileDetail>
...
<nfs_profileDetails>
<nfs_profileDetail>
<nfsServerIp>server-ip</nfsServerIp>
<profile_detail> ... </profile_detail>
</nfs_profileDetail>
</nfs_profileDetails>
</volume_profileDetails>
Change-Id: Iff04cc30f01a7fbe9d6e48b8498d405d05c41c25
Bug-Url: https://bugzilla.redhat.com/1083583
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterVolumeResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractStatisticalQuery.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResource.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterVolumeProfileInfoMapper.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/StatisticResourceUtils.java
8 files changed, 320 insertions(+), 23 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff04cc30f01a7fbe9d6e48b8498d405d05c41c25
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: restapi: Start and stop profiling on gluster volume
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Start and stop profiling on gluster volume
......................................................................
restapi: Start and stop profiling on gluster volume
Action to start and stop profiling on gluster volume
Change-Id: Iddd7d83e753a842b688cc77c0a4f64b4b7e28de5
Bug-Url: https://bugzilla.redhat.com/1083583
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterVolumeResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResource.java
3 files changed, 52 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Sahina Bose: Verified
--
To view, visit http://gerrit.ovirt.org/27155
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddd7d83e753a842b688cc77c0a4f64b4b7e28de5
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: restapi: Validate boolean values
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Validate boolean values
......................................................................
restapi: Validate boolean values
JAXB doesn't validate boolean values, anything that isn't the string
"true" is interpreted as false. This patch introduces a custom parser
for the boolean type that only accepts the strings "true" and "false",
any other thing will be rejected.
Change-Id: Ibb3558185a46869a73115b936183cb22007c99e9
Bug-Url: https://bugzilla.redhat.com/1063876
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/BooleanParser.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xjb
2 files changed, 26 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27925
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb3558185a46869a73115b936183cb22007c99e9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine-sdk[sdk_3.5]: sdk: Replace decorators before marshal
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Replace decorators before marshal
......................................................................
sdk: Replace decorators before marshal
The code generated by the generateDS.py tool expects that all the
objects implement the "export" method that generates the XML text. The
entity and collection decorators don't implement this methods, but the
user may use them in places where simple parameter objects are expected.
To avoid issues with this we had an implementation of the "__setattr__"
method in the base class of parameter objects that replaces references
to decorators with the corresponding parameter objects. But this doesn't
work when the references are set without calling the __setattr__ method,
for example when adding an element to a list. To avoid this issue this
patch removes the __setattr__ method and instead of that the replacement
is executed recusively right before doing the conversion to XML.
Change-Id: I7843dea85c9f09de5fb3439f57dba71ce6a28898
Bug-Url: https://bugzilla.redhat.com/1024696
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 06862abc036073620ae1c724b758309e8ac98c54)
---
M src/codegen/xsd/paramsconf.py
M src/ovirtsdk/utils/parsehelper.py
2 files changed, 43 insertions(+), 52 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28366
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7843dea85c9f09de5fb3439f57dba71ce6a28898
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine-sdk[master]: sdk: Replace decorators before marshal
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Replace decorators before marshal
......................................................................
sdk: Replace decorators before marshal
The code generated by the generateDS.py tool expects that all the
objects implement the "export" method that generates the XML text. The
entity and collection decorators don't implement this methods, but the
user may use them in places where simple parameter objects are expected.
To avoid issues with this we had an implementation of the "__setattr__"
method in the base class of parameter objects that replaces references
to decorators with the corresponding parameter objects. But this doesn't
work when the references are set without calling the __setattr__ method,
for example when adding an element to a list. To avoid this issue this
patch removes the __setattr__ method and instead of that the replacement
is executed recusively right before doing the conversion to XML.
Change-Id: I7843dea85c9f09de5fb3439f57dba71ce6a28898
Bug-Url: https://bugzilla.redhat.com/1024696
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M src/codegen/xsd/paramsconf.py
M src/ovirtsdk/utils/parsehelper.py
2 files changed, 43 insertions(+), 52 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24131
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7843dea85c9f09de5fb3439f57dba71ce6a28898
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[master]: restapi: Fault detail is optional
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Fault detail is optional
......................................................................
restapi: Fault detail is optional
The "detail" field of faults is optional, but in the XML schema it isn't
defined as such because the "minOccurs" attribute isn't specified and
the default is 1, which means mandatory.
Change-Id: I3145e3e2d6a242869cfd0edee5fa70a07c6eb649
Bug-Url: https://bugzilla.redhat.com/1102050
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28322
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3145e3e2d6a242869cfd0edee5fa70a07c6eb649
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine-sdk-java[sdk_3.5]: sdk: Add X-Ovirt-Expect and Expect
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Add X-Ovirt-Expect and Expect
......................................................................
sdk: Add X-Ovirt-Expect and Expect
The HTTP Expect header is rejected by the Apache web server if its
values is anythiong other than 100-continue. To avoid problems the
engine explicitly removes it, and it accepts an alternative
X-Ovirt-Except header, with the same values and semantics. This patch
changes the SDK so that it will automatically add the alternative header
when the user adds the original one.
Change-Id: I7af6ffa51c9e5b04e6f57d749e130424e10b7eaf
Related: https://bugzilla.redhat.com/1093784
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit e09c01e685f2f1a0ca3f85ff75dbd32bbdfdc0e5)
---
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/HttpProxy.java
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28365
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7af6ffa51c9e5b04e6f57d749e130424e10b7eaf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months