Change in ovirt-engine[ovirt-engine-3.4]: core: import glance image - image locked on failure
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: import glance image - image locked on failure
......................................................................
core: import glance image - image locked on failure
ImportRepoImageCreateTaskHandler:
Ensure 'destinationImageId' member of 'ImagesActionsParametersBase'
is saved in task parameters as part of AddImageFromScratch
execution. This change is needed from retrieving 'destinationImageId'
value in case of engine crash between tasks.
Change-Id: I37eba72dabb17c5ff4c9edaca899f206440791d0
Bug-Url: https://bugzilla.redhat.com/1102785
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCreateTaskHandler.java
2 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28301
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37eba72dabb17c5ff4c9edaca899f206440791d0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.4]: core: LSM - validate identical source and dest SDs
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: LSM - validate identical source and dest SDs
......................................................................
core: LSM - validate identical source and dest SDs
LiveMigrateVmDisksCommand:
Added a canDo validation for identical source and destination
storage domain IDs.
Change-Id: I75fbc21b654a10cd1207a70b437df75df971717e
Bug-Url: https://bugzilla.redhat.com/1103499
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java
2 files changed, 37 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/28300
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75fbc21b654a10cd1207a70b437df75df971717e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-dwh[master]: build: ovirt-engine-dwh-3.5_alpha2
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: build: ovirt-engine-dwh-3.5_alpha2
......................................................................
build: ovirt-engine-dwh-3.5_alpha2
Also added release notes.
Change-Id: I3279126b5ba78b2a8396913796ea87f301903346
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M ovirt-engine-dwh.spec.in
M version.mak
2 files changed, 13 insertions(+), 2 deletions(-)
Approvals:
Shirly Radco: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3279126b5ba78b2a8396913796ea87f301903346
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine-sdk[master]: codegen: fix SERVER constant for code generation
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: codegen: fix SERVER constant for code generation
......................................................................
codegen: fix SERVER constant for code generation
main.py:
Replaced SERVER's postfix with '/ovirt-engine/api'
to accommodate the new url scheme (which is needed for rsdl codgen).
Change-Id: Id3169d919738c8c573ccade02f7443d3349211e1
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M src/codegen/main.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/28388
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3169d919738c8c573ccade02f7443d3349211e1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-engine[master]: webadmin: Vm main tab columns sorting
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Vm main tab columns sorting
......................................................................
webadmin: Vm main tab columns sorting
This patch adds sorting of (some) fields in VM main tab in webadmin. As
a part of the patch, some existing *Column implementations were adjusted
to extend SortableColumn class.
Change-Id: I718321d0721f6a64fd86288be8dacf2b05c67304
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1103715
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/ImageResourceColumn.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SafeHtmlColumn.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusColumn.java
5 files changed, 34 insertions(+), 12 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I718321d0721f6a64fd86288be8dacf2b05c67304
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: core: osinfo properties - added 3.5 values
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: osinfo properties - added 3.5 values
......................................................................
core: osinfo properties - added 3.5 values
As 3.5 cluster version has been recently introduced,
appropriate values should be manually added explicitly
(similar to: Ib4b2d3b3eb14d368814392cfcb63e6c8648d05cc).
Note:
This should be a temporary solution until implementation
of cluster versions inheritance in OsInfo infrastructure;
covered by: https://bugzilla.redhat.com/show_bug.cgi?id=1056577.
Change-Id: I82acba49f080e9250481b0a62ac66817091a1755
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M packaging/conf/osinfo-defaults.properties
1 file changed, 11 insertions(+), 0 deletions(-)
Approvals:
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Daniel Erez: Verified
Roy Golan: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82acba49f080e9250481b0a62ac66817091a1755
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: core: Extract hardcoded strings to constants
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: core: Extract hardcoded strings to constants
......................................................................
core: Extract hardcoded strings to constants
This patch pulls hardcoded strings in VmConditionFieldAutoCompleter to
constants. They are used in follow up frontend patch (sorting columns in
VM main tab in webadmin application).
Change-Id: I7d2fb964cc0c5520e37cd190e88f09d4218868d2
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1103715
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java
1 file changed, 112 insertions(+), 86 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
Frank Kobzik: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28281
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d2fb964cc0c5520e37cd190e88f09d4218868d2
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: core: Allow VM sorting according to missing fields
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: core: Allow VM sorting according to missing fields
......................................................................
core: Allow VM sorting according to missing fields
This patch makes it possible to sort search results according to fqdn,
migration_progress_percent and run_on_vds_name fields. This enhancement
was needed as we also want to sort by these fields in the ui.
Change-Id: Id3580a6ac17a1e56bf9de1de09f3ef3a22bbefd4
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1103715
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java
1 file changed, 11 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
Frank Kobzik: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28314
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3580a6ac17a1e56bf9de1de09f3ef3a22bbefd4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: core: minor refactoring in VURTI#removeVmsFromCache
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: minor refactoring in VURTI#removeVmsFromCache
......................................................................
core: minor refactoring in VURTI#removeVmsFromCache
Change-Id: I27c4fc6edec3809b9e0daa74c6ed53bd21c06af3
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 11 insertions(+), 10 deletions(-)
Approvals:
Roy Golan: Looks good to me, approved
Omer Frenkel: Looks good to me, but someone else must approve
Liran Zelkha: Looks good to me, but someone else must approve
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/28143
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I27c4fc6edec3809b9e0daa74c6ed53bd21c06af3
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: frontend: Remove redundant comments
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: Remove redundant comments
......................................................................
frontend: Remove redundant comments
Remove redundant comments from frontend modules, most of those comments are
there from the initial commit and are redundant
Change-Id: I14968ae60efd801e88af60680358bc0241ab8e46
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolVmListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/EventNotificationModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpice.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/RegexValidation.java
13 files changed, 1 insertion(+), 170 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14968ae60efd801e88af60680358bc0241ab8e46
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years