June 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Fix null dereference in CommandBase by coverity
by mkolesni＠redhat.com 26 Jun '14

26 Jun '14

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Fix null dereference in CommandBase by coverity ...................................................................... engine: Fix null dereference in CommandBase by coverity CID 1062086 (#1 of 1): Dereference null return value (NULL_RETURNS) null_method_call: Calling a method on null object getQuotaConsumptionParameters() Change-Id: I450d48d0840411db44c95fc15b62eb7ab33be91d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/29260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I450d48d0840411db44c95fc15b62eb7ab33be91d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Format CommandExecutor.invokeCallbackMethods()
by mkolesni＠redhat.com 26 Jun '14

26 Jun '14

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Format CommandExecutor.invokeCallbackMethods() ...................................................................... engine: Format CommandExecutor.invokeCallbackMethods() Change-Id: I919ce914e92f086956c2694bd2ffe74aed26c428 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java 1 file changed, 19 insertions(+), 18 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/29160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I919ce914e92f086956c2694bd2ffe74aed26c428 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: adding jboss.cer to the list of file to un...
by sbonazzo＠redhat.com 26 Jun '14

26 Jun '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: adding jboss.cer to the list of file to uninstall ...................................................................... packaging: setup: adding jboss.cer to the list of file to uninstall Adding jboss.cer to the list of file to uninstall: jboss.cer is actually created by engine-setup but is not removed by engine-cleanup Change-Id: I5cf8300b7b0b5030856e7e3b2a0c5d6a9dc009c0 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cf8300b7b0b5030856e7e3b2a0c5d6a9dc009c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : NPE is raised when accessing via REST /groups url
by yzaslavs＠redhat.com 26 Jun '14

26 Jun '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine : NPE is raised when accessing via REST /groups url ...................................................................... engine : NPE is raised when accessing via REST /groups url A NPE exception is raised when querying for user groups using restapi with filtered=true GetAllDbGroups does not have the corresponding query class it was named GetAllAdGroupsQuery Change-Id: Iff5562bdb130530b952053e72d4446c0019812aa Bug-Url: https://bugzilla.redhat.com/1099831 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDbGroupsQuery.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff5562bdb130530b952053e72d4446c0019812aa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Fix request body type definition for delete schedul...
by juan.hernandez＠redhat.com 26 Jun '14

26 Jun '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix request body type definition for delete schedulingpolicyunits ...................................................................... restapi: Fix request body type definition for delete schedulingpolicyunits delete schedulingpolicyunits command have no body, so its type should be defined as 'null' Change-Id: I1b27651773c8a4d3d6bfd0bb9af9f7cd5d26154e Bug-Url: https://bugzilla.redhat.com/1113484 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/29242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b27651773c8a4d3d6bfd0bb9af9f7cd5d26154e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: aaa: use runVdsCommand
by yzaslavs＠redhat.com 26 Jun '14

26 Jun '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: use runVdsCommand ...................................................................... aaa: use runVdsCommand Use runVdsCommand instead of [Backend.getInstnace()/getBackend()].getResourceManager().RunVdsCommand Topic: AAA Change-Id: Idcf48db5ea278a74b1bf87076d3b16af29bb416c Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractSPMAsyncTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ApproveVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CancelMigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeFloppyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearNonResponsiveVdsVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MonitorCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PauseVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveTemplateSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsKdumpDetectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AttachNetworkToVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/DetachNetworkFromVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/RemoveBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkToVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ForceRemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java 46 files changed, 81 insertions(+), 231 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idcf48db5ea278a74b1bf87076d3b16af29bb416c Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: avoid asking about engine configuration du...
by sbonazzo＠redhat.com 26 Jun '14

26 Jun '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: avoid asking about engine configuration during upgrade ...................................................................... packaging: setup: avoid asking about engine configuration during upgrade Avoid asking about engine configuation during an upgrade from 3.4. engine-setup 3.4 didn't allow to skip the engine configuration and we didn't support partial upgrades so, if it's there, we need to upgrade the engine too. Change-Id: Ibf0f6ac38c748e332336ddc1c05ec7d8b4df6014 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py 1 file changed, 19 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf0f6ac38c748e332336ddc1c05ec7d8b4df6014 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix finbugs
by yzaslavs＠redhat.com 26 Jun '14

26 Jun '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: fix finbugs ...................................................................... core: fix finbugs Change-Id: Ie256989b403263cef5f97bf049da4df2e838824a Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie256989b403263cef5f97bf049da4df2e838824a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Re: [oVirt Jenkins] ovirt-engine_master_find-bugs_merged - Build # 8444 - Unstable!
by Eyal Edri 26 Jun '14

26 Jun '14

fyi, this commit added 14 new findbugs alerts, please fix asap. once we'll have new lab up and running we will be able to run again findbugs per patch, and this will be prevented hopefully. eyal. ----- Original Message ----- > From: "Jenkins ci oVirt Server" <jenkins(a)ovirt.org> > To: eedri(a)redhat.com, engine-commits(a)ovirt.org, obasan(a)redhat.com, dcaroest(a)redhat.com, knesenko(a)redhat.com, > yzaslavs(a)redhat.com > Sent: Thursday, June 26, 2014 9:08:41 AM > Subject: [oVirt Jenkins] ovirt-engine_master_find-bugs_merged - Build # 8444 - Unstable! > > Project: http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_merged/ > Build: > http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_merged/8444/ > Build Number: 8444 > Build Status: Unstable > Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/28829 > > ------------------------------------- > Changes Since Last Success: > ------------------------------------- > Changes for Build #8444 > [Yair Zaslavsky] core: introduce context pattern > > > > > ----------------- > Failed Tests: > ----------------- > No tests ran. > >

3 2

Change in jenkins[master]: Fixed config to adapt to the jjb fixes
by dcaroest＠redhat.com 26 Jun '14

26 Jun '14

David Caro has submitted this change and it was merged. Change subject: Fixed config to adapt to the jjb fixes ...................................................................... Fixed config to adapt to the jjb fixes Test command does not read the config anymore, so recursive has to be specified explicitly each time when testing. Change-Id: I02c56a1379b21654ad32eee16ddd5d829408d7b8 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/jenkins_check_yaml.sh 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Ewoud Kohl van Wijngaarden: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02c56a1379b21654ad32eee16ddd5d829408d7b8 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0