Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Overlapped in 'New Virtual Machine - Guide Me' dialog
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Overlapped in 'New Virtual Machine - Guide Me' dialog
......................................................................
webadmin: Overlapped in 'New Virtual Machine - Guide Me' dialog
In fr_FR locale the text did not fit into buttons in new VM guide me dialog.
Fixed by changing the styles in a way that when the text is longer than 250px
(min width) than the button grows.
Change-Id: Icde29a47a3c78f73cca9eaaf0db875c5b82ea0e8
Bug-Url: https://bugzilla.redhat.com/1123762
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml
M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
3 files changed, 3 insertions(+), 12 deletions(-)
Approvals:
Tomas Jelinek: Verified
Alexander Wels: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30912
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icde29a47a3c78f73cca9eaaf0db875c5b82ea0e8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: backend: Validate cdrom images for .iso suffix
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: backend: Validate cdrom images for .iso suffix
......................................................................
backend: Validate cdrom images for .iso suffix
Check for the filename ".iso" suffix of isoPath in
UpdateVm and ChangeDisk commands.
Change-Id: I7d4e6e6464e5f23483748dcd03607612b1fc56f4
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1013737
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidationUtilsTest.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
6 files changed, 30 insertions(+), 0 deletions(-)
Approvals:
Martin Betak: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30903
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d4e6e6464e5f23483748dcd03607612b1fc56f4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin: Overlapped in 'New Virtual Machine - Guide Me' dialog
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Overlapped in 'New Virtual Machine - Guide Me' dialog
......................................................................
webadmin: Overlapped in 'New Virtual Machine - Guide Me' dialog
In fr_FR locale the text did not fit into buttons in new VM guide me dialog.
Fixed by changing the styles in a way that when the text is longer than 250px
(min width) than the button grows.
Change-Id: Icde29a47a3c78f73cca9eaaf0db875c5b82ea0e8
Bug-Url: https://bugzilla.redhat.com/1123762
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml
M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
3 files changed, 3 insertions(+), 12 deletions(-)
Approvals:
Tomas Jelinek: Verified
Alexander Wels: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30821
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icde29a47a3c78f73cca9eaaf0db875c5b82ea0e8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: Fixes StackOverflowError during fencing
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Fixes StackOverflowError during fencing
......................................................................
core: Fixes StackOverflowError during fencing
Fixes StackOverflowError appeared during execution of fencing operation.
This fix removes commandContex instance and overriden getContext() from
RestartVdsCommand, because command context in CommandBase should be set
always during creation of command and successful locks aquiring is
checked prior to executeCommand call in CommandBase.
Also when RestartVdsCommand and its inherited commands are using global
command context, VdsKdumpDetection command executed from
VdsNotRespondingTreatmentCommand should also use global command context
and not its copy.
The overriden getContext() has been introduced in
Iaf021010188e3c3662fbf8a057da4c58f2600c02.
Change-Id: Icbe5ad9194b19a390f45c99198087a9e5b68eb9c
Bug-Url: https://bugzilla.redhat.com/1124141
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsKdumpDetectionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
3 files changed, 2 insertions(+), 16 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/30836
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbe5ad9194b19a390f45c99198087a9e5b68eb9c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: engine : Transaction issues in CommandsCacheImpl updateStatus
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: engine : Transaction issues in CommandsCacheImpl updateStatus
......................................................................
engine : Transaction issues in CommandsCacheImpl updateStatus
When async tasks are executed the updateCommandStatus
is being performed from two different transaction
resulting in transcation lock.
Transaction needs to be suspended before updating
command status.
Change-Id: I3e29d516b4cdf1509ae7838731869684004e5ee9
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java
1 file changed, 16 insertions(+), 2 deletions(-)
Approvals:
Ravi Nori: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30868
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e29d516b4cdf1509ae7838731869684004e5ee9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: GWT debug mode speedup.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: GWT debug mode speedup.
......................................................................
webadmin: GWT debug mode speedup.
Debug mode would take around 4:30 to get from the login page to
the VM main tab when logging in. This is due to the proxy event
on UiCommonInitEvent in AbstractSubTabPresenter. This event would
fire and it would cause all sub classes of AbstractSubTabPresenter
to initialize and since the code was split, it would have to load
every single sub tab presenter everywhere at once. This took about
500ms-3000ms depending on the presenter. With around 200 sub tab
presenters, it would take a long long time.
This patch removes the proxy event and instead places the handler
initialization in the onBind of the presenter. This should have the
exact same effect as before (the handlers are initalized when the
presenter is activated vs when the application is initalized).
Change-Id: I8a5a038cbf7a6cfe8e462eab2e4f18c910c039cc
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1110788
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/ClientModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ClientModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterGeneralPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostHardwarePresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/virtualMachine/SubTabVirtualMachineGeneralPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/virtualMachine/SubTabVirtualMachineSnapshotPresenter.java
8 files changed, 20 insertions(+), 23 deletions(-)
Approvals:
Alexander Wels: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30866
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a5a038cbf7a6cfe8e462eab2e4f18c910c039cc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: Minor cleanup of ValidationUtilsTest
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Minor cleanup of ValidationUtilsTest
......................................................................
core: Minor cleanup of ValidationUtilsTest
Remove duplication in tests code when testing for pattern match of
multiple strings.
Change-Id: I3416939844516e3d39538221970c9caa5ca73fd7
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidationUtilsTest.java
1 file changed, 4 insertions(+), 21 deletions(-)
Approvals:
Martin Betak: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30807
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3416939844516e3d39538221970c9caa5ca73fd7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: backend: Validate cdrom images for .iso suffix
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: backend: Validate cdrom images for .iso suffix
......................................................................
backend: Validate cdrom images for .iso suffix
Check for the filename ".iso" suffix of isoPath in
UpdateVm and ChangeDisk commands.
Change-Id: I7d4e6e6464e5f23483748dcd03607612b1fc56f4
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1013737
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidationUtilsTest.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
6 files changed, 30 insertions(+), 0 deletions(-)
Approvals:
Martin Betak: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30806
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d4e6e6464e5f23483748dcd03607612b1fc56f4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Set images with Storage Pool for images already on tar...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Set images with Storage Pool for images already on target.
......................................................................
core: Set images with Storage Pool for images already on target.
Setting images with storage pool id only for images which are already on
the Storage Domain, since importing a VM from configuration through the REST
does not oblegate an initialized Storage Domain
Change-Id: I8546a2ac47dab4208da0df4c2cd7bb92fdde1d40
Bug-Url: https://bugzilla.redhat.com/1124879
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/30870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8546a2ac47dab4208da0df4c2cd7bb92fdde1d40
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: engine: Update os-info max memory sizes for x64 systems
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Update os-info max memory sizes for x64 systems
......................................................................
engine: Update os-info max memory sizes for x64 systems
64-bit RHEL and windows systems inherited max memory size from "other"
system which specified appropriate value for 32-bit systems (64000M).
Updated value of os.resource.maximum.ram for the following systems:
RHEL3x64: 128 GB
RHEL4x64: 256 GB
RHEL5x64: 1 TB
RHEL6x64: 3 TB
RHEL7x64: 3 TB
Windows2003x64: 1 TB
Windows2008x64: 1 TB
Windows2008R2x64: 2 TB
Windows2012x64 4 TB
Windows7x64: 192 GB
Windows8x64: 512 GB
Based on:
[1] https://access.redhat.com/articles/rhel-limits
[2] http://msdn.microsoft.com/en-us/library/windows/desktop/aa366778(v=vs.85)...
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1087745
Change-Id: Ib2b098fb0c05cca5d5f9638c7ac693c631317b2f
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M packaging/conf/osinfo-defaults.properties
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Martin Betak: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30891
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2b098fb0c05cca5d5f9638c7ac693c631317b2f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months