Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Reset properties when detaching network
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: Reset properties when detaching network
......................................................................
webadmin: Reset properties when detaching network
Previously the underlying network interface entity's properties were
not properly reset when a network was detached, regarding
recently-added properties (QoS, custom properties). This is now fixed
for custom properties.
Change-Id: I37f3f1bc0cc3d5353c43d628fa3b24420728236c
Bug-Url: https://bugzilla.redhat.com/1119019
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NetworkParameters.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java
2 files changed, 23 insertions(+), 43 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/30500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37f3f1bc0cc3d5353c43d628fa3b24420728236c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in jenkins[master]: jobs: ovirt-iso-uploader
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: jobs: ovirt-iso-uploader
......................................................................
jobs: ovirt-iso-uploader
Add jobs for ovirt-iso-uploader
Change-Id: I16519ba7e0f50ecafe6d04eb96f6df95d15f5e35
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
A jobs/confs/yaml/jobs/ovirt-iso-uploader/ovirt-iso-uploader_create-rpms.yaml
A jobs/confs/yaml/scms/ovirt-iso-uploader.yaml
2 files changed, 48 insertions(+), 0 deletions(-)
Approvals:
David Caro: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30512
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16519ba7e0f50ecafe6d04eb96f6df95d15f5e35
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in jenkins[master]: jobs: ovirt-image-uploader
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: jobs: ovirt-image-uploader
......................................................................
jobs: ovirt-image-uploader
Add ovirt-image-uploader jobs
Change-Id: Idd1c4f204d6b9bc4982f8d6109184f134412b711
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
A jobs/confs/yaml/jobs/ovirt-image-uploader/ovirt-image-uploader_create-rpms.yaml
A jobs/confs/yaml/scms/ovirt-image-uploader.yaml
2 files changed, 48 insertions(+), 0 deletions(-)
Approvals:
David Caro: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd1c4f204d6b9bc4982f8d6109184f134412b711
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: webadmin: Create new VM | Not all selected nics are created ...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Create new VM | Not all selected nics are created on the VM
......................................................................
webadmin: Create new VM | Not all selected nics are created on the VM
Opening and closing ghost profile instance type editor without selecting a
value causes the first acceptable value to be displayed at the header text
box (just to be displayed, not really be selected-> the real value is
still null).
It is caused because ListModelTypeAheadListBox->adjustSelectedValue()
calls in the described case-
'setValue(acceptableValues.iterator().next())' without firing valueChange
event. The displayed value is changed, but the model.selectedValue is
still null.
Calling setValue with 'true' for 'fireValueChangeEvent' fixes the issue.
But, as I understand, if the the selected value ('getValue()') was 'null'
and wasn't changed manually to another value.
There is no reason to override it here by the first item in the list.
Change-Id: Iaa8ec33db813f334f07baadac38f27c5544f0791
Bug-Url: https://bugzilla.redhat.com/1115788
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java
1 file changed, 13 insertions(+), 14 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Alona Kaplan: Verified
Lior Vernia: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/30490
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa8ec33db813f334f07baadac38f27c5544f0791
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: webadmin: Clear QoS when detaching network
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Clear QoS when detaching network
......................................................................
webadmin: Clear QoS when detaching network
Similarly to the previous fix for custom properties, QoS settings on a
host's network interface are also cleared when a network is detached.
Change-Id: Ife17c3fae94fe936aab87a4012b7133c943faf2d
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NetworkParameters.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java
2 files changed, 8 insertions(+), 2 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/30498
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife17c3fae94fe936aab87a4012b7133c943faf2d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: webadmin: Reset properties when detaching network
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Reset properties when detaching network
......................................................................
webadmin: Reset properties when detaching network
Previously the underlying network interface entity's properties were
not properly reset when a network was detached, regarding
recently-added properties (QoS, custom properties). This is now fixed
for custom properties.
Change-Id: I37f3f1bc0cc3d5353c43d628fa3b24420728236c
Bug-Url: https://bugzilla.redhat.com/1119019
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NetworkParameters.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java
2 files changed, 23 insertions(+), 43 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/30496
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37f3f1bc0cc3d5353c43d628fa3b24420728236c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-reports[master]: reports: fixed centos install with ovirt provided jboss
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: fixed centos install with ovirt provided jboss
......................................................................
reports: fixed centos install with ovirt provided jboss
Change-Id: Ie049ed840c523a6e43524186ef39c1c32adfefcd
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M ovirt-engine-reports.spec.in
M packaging/setup/ovirt_engine_setup/reports/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/__init__.py
A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/jboss.py
4 files changed, 90 insertions(+), 2 deletions(-)
Approvals:
Yedidyah Bar David: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30112
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie049ed840c523a6e43524186ef39c1c32adfefcd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.4]: core: long query response time while many simultaneously que...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: long query response time while many simultaneously queries are running
......................................................................
core: long query response time while many simultaneously queries are running
we found the postgres running this function 'getdiskbydiskid' so many
times when the engine started which makes disaster on the sys
with 100% CPU utilization
Change-Id: I94e20d782bc4e2befaf4338f51551a2855509769
Bug-Url: https://bugzilla.redhat.com/1120088
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDAOTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M packaging/dbscripts/disk_image_dynamic_sp.sql
5 files changed, 67 insertions(+), 19 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Omer Frenkel: Looks good to me, but someone else must approve
Liran Zelkha: Verified
--
To view, visit http://gerrit.ovirt.org/29043
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I94e20d782bc4e2befaf4338f51551a2855509769
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: core: UpdateVmDiskCommantTest whitespaces
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: UpdateVmDiskCommantTest whitespaces
......................................................................
core: UpdateVmDiskCommantTest whitespaces
Removed redundant whitespaces.
Change-Id: I8d724b9ea1c0d37b7117407fb1408087e51ed1c6
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/30506
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d724b9ea1c0d37b7117407fb1408087e51ed1c6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: engine: Allow custom properties on NIC without network
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: Allow custom properties on NIC without network
......................................................................
engine: Allow custom properties on NIC without network
Previously a validation failed the Setup Networks command when a NIC
had no network but had custom properties configured, which blocked
removal of networks with custom properties.
Now canDoAction() doesn't block this, but the custom properties are
ignored (similarly to boot protocol) in case no network is configured
on the NIC.
Similar changes have been made to the QoS settings, which would cause
the same problems.
Change-Id: Ibded6b7b7ffe9be960d522bd63cbf9db08b18d6e
Bug-Url: https://bugzilla.redhat.com/1119019
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 42 insertions(+), 31 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30494
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibded6b7b7ffe9be960d522bd63cbf9db08b18d6e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months