July 2014 - Engine-commits - oVirt List Archives

Change in ovirt-guest-agent[ovirt-3.5]: Filter out duplicated network adapters on Windows
by vfeenstr＠redhat.com 17 Jul '14

17 Jul '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Filter out duplicated network adapters on Windows ...................................................................... Filter out duplicated network adapters on Windows Change-Id: I19d4b91ea4fb6fcec6699ab6892ba1d6240919f6 Bug-Url: https://bugzilla.redhat.com/1113089 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> (cherry picked from commit f531f482a2b2fa03ba7ec61449f5c3539a607a03) --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 18 insertions(+), 1 deletion(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19d4b91ea4fb6fcec6699ab6892ba1d6240919f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[master]: Filter out duplicated network adapters on Windows
by vfeenstr＠redhat.com 17 Jul '14

17 Jul '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Filter out duplicated network adapters on Windows ...................................................................... Filter out duplicated network adapters on Windows Change-Id: I19d4b91ea4fb6fcec6699ab6892ba1d6240919f6 Bug-Url: https://bugzilla.redhat.com/1113089 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 18 insertions(+), 1 deletion(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19d4b91ea4fb6fcec6699ab6892ba1d6240919f6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: The labels should be displayed in lexo numeric order
by alkaplan＠redhat.com 17 Jul '14

17 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: The labels should be displayed in lexo numeric order ...................................................................... webadmin: The labels should be displayed in lexo numeric order The edit interface(nic) label window, and the tool tip on the name of the nic in the sub tab network interfaces under hosts had to be fixed. Change-Id: If25a826a3123b43f87e51537a1988209dda31fa6 Bug-Url: https://bugzilla.redhat.com/1091674 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NicLabelModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfaceLabelWithToolTip.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30217 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If25a826a3123b43f87e51537a1988209dda31fa6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: tools: support for deprecating config values.
by masayag＠redhat.com 17 Jul '14

17 Jul '14

Moti Asayag has submitted this change and it was merged. Change subject: tools: support for deprecating config values. ...................................................................... tools: support for deprecating config values. - each config value can be deprecated via setting its property '.deprecated' to true. If not specified, deprecated=false is assumed. - when someone tries to set deprecated value, following message is printed: "ConfigKey <option_name> is deprecated. Please refer to product documentation." Change-Id: I636f7fe2530acfe00d8f0487001ddc781d1745a0 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/ConfigKey.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/ConfigKeyFactory.java 3 files changed, 38 insertions(+), 5 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I636f7fe2530acfe00d8f0487001ddc781d1745a0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Error code 23 when invoking Setup Networks
by alkaplan＠redhat.com 17 Jul '14

17 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Error code 23 when invoking Setup Networks ...................................................................... engine: Error code 23 when invoking Setup Networks In case the network is not in sync, it shouldn't override the interface's vlan id. Bug-Url: https://bugzilla.redhat.com/1115001 Change-Id: Iac0252076e8fa8704ed6c5257aeb5824d71470c5 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/30170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac0252076e8fa8704ed6c5257aeb5824d71470c5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Added log when retrieving entities from tar
by tnisan＠redhat.com 17 Jul '14

17 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Added log when retrieving entities from tar ...................................................................... core: Added log when retrieving entities from tar Adding a log for the retrieve of entities process so it will be easier to understand the flow through the engine log file. Bug-Url: https://bugzilla.redhat.com/1119376 Change-Id: I11b1102b64c6951376a5242364435515b41d24fb Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/30206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11b1102b64c6951376a5242364435515b41d24fb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Use audit log only when failed to use retrieve command.
by tnisan＠redhat.com 17 Jul '14

17 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Use audit log only when failed to use retrieve command. ...................................................................... core: Use audit log only when failed to use retrieve command. Using a warning audit log only when the retrieve of OVF_STORE disks has been failed. When there are no OVF_STORE disks available we should only print a warnning log which indicates that there were no OVF_STORE in the storage domain. Bug-Url: https://bugzilla.redhat.com/1119376 Change-Id: I1eb5a687429c081f42bdc63bf3b8dd17eb295236 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 11 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/30205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1eb5a687429c081f42bdc63bf3b8dd17eb295236 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: jobs: ovirt-log-collector create rpms
by dcaroest＠redhat.com 17 Jul '14

17 Jul '14

David Caro has submitted this change and it was merged. Change subject: jobs: ovirt-log-collector create rpms ...................................................................... jobs: ovirt-log-collector create rpms Added jobs for creating rpms on master, 3.5 and 3.4 branches. Change-Id: I15d47beab5db38786bc9557473dff8c9454a68b1 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/jobs/kexec-tools/kexec-tools_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-hosted-engine-ha/ovirt-hosted-engine-ha_create-rpms.yaml A jobs/confs/yaml/jobs/ovirt-log-collector/ovirt-log-collector_create-rpms.yaml M jobs/confs/yaml/jobs/unboundid-ldapsdk/unboundid-ldapsdk_create-rpms.yaml M jobs/confs/yaml/jobs/vdsm-jsonrpc-java/vdsm-jsonrpc-java_create-rpms.yaml M jobs/confs/yaml/jobs/vdsm/vdsm_install-rpm-sanity.yaml A jobs/confs/yaml/scms/ovirt-log-collector.yaml M jobs/confs/yaml/templates/create-rpms_mock.yaml M jobs/confs/yaml/templates/install-rpm-sanity.yaml 9 files changed, 74 insertions(+), 23 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15d47beab5db38786bc9557473dff8c9454a68b1 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Added log when retrieving entities from tar
by mlipchuk＠redhat.com 17 Jul '14

17 Jul '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Added log when retrieving entities from tar ...................................................................... core: Added log when retrieving entities from tar Adding a log for the retrieve of entities process so it will be easier to understand the flow through the engine log file. Change-Id: I11b1102b64c6951376a5242364435515b41d24fb Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11b1102b64c6951376a5242364435515b41d24fb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use audit log only when failed to use retrieve command.
by mlipchuk＠redhat.com 17 Jul '14

17 Jul '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use audit log only when failed to use retrieve command. ...................................................................... core: Use audit log only when failed to use retrieve command. Using a warning audit log only when the retrieve of OVF_STORE disks has been failed. When there are no OVF_STORE disks available we should only print a warnning log which indicates that there were no OVF_STORE in the storage domain. Change-Id: I1eb5a687429c081f42bdc63bf3b8dd17eb295236 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 11 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/30061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1eb5a687429c081f42bdc63bf3b8dd17eb295236 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0