Change in ovirt-engine[master]: engine: Enable detaching network from host when a VM has an ...
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Enable detaching network from host when a VM has an unplugged VNIC profile of that network
......................................................................
engine: Enable detaching network from host when a VM has an unplugged
VNIC profile of that network
Enable detaching network from host when a VM has an unplugged VNIC
profile of that network.
Change-Id: I10db794df55b25925423166d33549b92856e9dd0
Bug-Url: https://bugzilla.redhat.com/1115101
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java
3 files changed, 32 insertions(+), 17 deletions(-)
Approvals:
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit http://gerrit.ovirt.org/29878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10db794df55b25925423166d33549b92856e9dd0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: core: add tests for AddExistingBlockStorageDomainCommand
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: add tests for AddExistingBlockStorageDomainCommand
......................................................................
core: add tests for AddExistingBlockStorageDomainCommand
Added a new unit tests class AddExistingBlockStorageDomainCommandTest.
Change-Id: Iddcb20d1dcacbbb72c37ffb89449f5451bcccbb8
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommandTest.java
2 files changed, 60 insertions(+), 2 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29781
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddcb20d1dcacbbb72c37ffb89449f5451bcccbb8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: disks sub-tab - fix columns creation
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: disks sub-tab - fix columns creation
......................................................................
webadmin: disks sub-tab - fix columns creation
Following sorting support, disks columns instantiation
should be ensured to happen once. Otherwise, the columns get
duplicated on type navigation (radio-buttons of all/images/directlun).
Hence, applied the same solution introduced in [1] on MainTabDiskView
to disks sub-tab as well.
[1] http://gerrit.ovirt.org/29375/
Change-Id: Idc774e26c9a3d954e9d7b8a4fee9206358269926
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java
1 file changed, 45 insertions(+), 14 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/30004
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc774e26c9a3d954e9d7b8a4fee9206358269926
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.4]: packaging: post 3.4.3 branching
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: packaging: post 3.4.3 branching
......................................................................
packaging: post 3.4.3 branching
Change-Id: I732f68556aa6d37dbf3f5fb1e36fc9d3ec99f201
Related-To: https://bugzilla.redhat.com/1069193
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M backend/manager/dependencies/pom.xml
M backend/manager/modules/authentication/pom.xml
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/branding/pom.xml
M backend/manager/modules/common/pom.xml
M backend/manager/modules/compat/pom.xml
M backend/manager/modules/dal/pom.xml
M backend/manager/modules/docs/pom.xml
M backend/manager/modules/pom.xml
M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml
M backend/manager/modules/restapi/interface/common/pom.xml
M backend/manager/modules/restapi/interface/definition/pom.xml
M backend/manager/modules/restapi/interface/pom.xml
M backend/manager/modules/restapi/jaxrs/pom.xml
M backend/manager/modules/restapi/pom.xml
M backend/manager/modules/restapi/types/pom.xml
M backend/manager/modules/restapi/webapp/pom.xml
M backend/manager/modules/root/pom.xml
M backend/manager/modules/scheduler/pom.xml
M backend/manager/modules/searchbackend/pom.xml
M backend/manager/modules/services/pom.xml
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/vdsbroker/pom.xml
M backend/manager/modules/welcome/pom.xml
M backend/manager/pom.xml
M backend/manager/tools/pom.xml
M backend/pom.xml
M build-tools-root/checkstyles/pom.xml
M build-tools-root/jboss-modules-maven-plugin/pom.xml
M build-tools-root/ovirt-checkstyle-extension/pom.xml
M build-tools-root/pom.xml
M ear/pom.xml
M frontend/pom.xml
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/gwt-common/pom.xml
M frontend/webadmin/modules/gwt-extension/pom.xml
M frontend/webadmin/modules/pom.xml
M frontend/webadmin/modules/uicommonweb/pom.xml
M frontend/webadmin/modules/uicompat/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
M frontend/webadmin/pom.xml
M pom.xml
M version.mak
44 files changed, 48 insertions(+), 48 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/29962
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I732f68556aa6d37dbf3f5fb1e36fc9d3ec99f201
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: restapi: Fix update VM optional parameters
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Fix update VM optional parameters
......................................................................
restapi: Fix update VM optional parameters
The metadata for the operation to update a VM doesn't include the
guaranteed memory option, thus it isn't available in the CLI.
Change-Id: I5d32fb2db5bf4b9f2f3271820ce7b0caeac9e050
Bug-Url: https://bugzilla.redhat.com/1082594
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 6103405931427d643a1e018ed8aa5536235fd142)
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30007
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d32fb2db5bf4b9f2f3271820ce7b0caeac9e050
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 5 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: build: post ovirt-hosted-engine-setup-1.2 branch
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: post ovirt-hosted-engine-setup-1.2 branch
......................................................................
build: post ovirt-hosted-engine-setup-1.2 branch
Change-Id: I9dd34f07f3deeb3e048cac84a76839065a56c26d
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M configure.ac
M ovirt-hosted-engine-setup.spec.in
2 files changed, 11 insertions(+), 8 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Jiří Moskovčák: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/29961
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9dd34f07f3deeb3e048cac84a76839065a56c26d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 5 months
Change in ovirt-hosted-engine-setup[master]: build: post ovirt-hosted-engine-setup-1.2 branch
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: post ovirt-hosted-engine-setup-1.2 branch
......................................................................
build: post ovirt-hosted-engine-setup-1.2 branch
Change-Id: Ie1af1ac79f42218670aa849ea41fff77ed7b4152
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M configure.ac
M ovirt-hosted-engine-setup.spec.in
2 files changed, 11 insertions(+), 11 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/29956
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1af1ac79f42218670aa849ea41fff77ed7b4152
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: core: renamed test to accommodate command
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: renamed test to accommodate command
......................................................................
core: renamed test to accommodate command
Renamed test to SyncLunsInfoForBlockStorageDomainCommandTest
(to reflect command's name).
Change-Id: Ie94262104c972987817957e23a4b81bfb659e8ae
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForBlockStorageDomainCommandTest.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie94262104c972987817957e23a4b81bfb659e8ae
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: webadmin: disks sub-tab - fix columns creation
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: disks sub-tab - fix columns creation
......................................................................
webadmin: disks sub-tab - fix columns creation
Following sorting support, disks columns instantiation
should be ensured to happen once. Otherwise, the columns get
duplicated on type navigation (radio-buttons of all/images/directlun).
Hence, applied the same solution introduced in [1] on MainTabDiskView
to disks sub-tab as well.
[1] http://gerrit.ovirt.org/29375/
Change-Id: Idc774e26c9a3d954e9d7b8a4fee9206358269926
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java
1 file changed, 45 insertions(+), 14 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/30003
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc774e26c9a3d954e9d7b8a4fee9206358269926
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: aaa: sort domain names a-b ascending.
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: aaa: sort domain names a-b ascending.
......................................................................
aaa: sort domain names a-b ascending.
Change-Id: Ia3d0a64c872f8d2a018be08587303b5358c3a18c
Topic: AAA
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1115549
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAAAProfileListQuery.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
mooli tayer: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29721
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3d0a64c872f8d2a018be08587303b5358c3a18c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months