July 2014 - Engine-commits - oVirt List Archives

Change in ovirt-dwh[master]: history: fixed users external_id type due to engine change
by ydary＠redhat.com 03 Jul '14

03 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: history: fixed users external_id type due to engine change ...................................................................... history: fixed users external_id type due to engine change external_id feild changed to type text on engine. update etl and history db accordingly. Change-Id: I328a5d27ca90eb4ebb338cedf41fe9d0e4f49f7e Bug-Url: https://bugzilla.redhat.com/1113193 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- A packaging/dbscripts/upgrade/03_05_0050_updated_users_history_table_external_id.sql M tos_project/process/ConfigurationSync_3.5.item M tos_project/process/ConfigurationSync_3.5.properties 3 files changed, 13 insertions(+), 9 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I328a5d27ca90eb4ebb338cedf41fe9d0e4f49f7e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: add buttons in the new cluster dialog and make it ...
by gchaplik＠redhat.com 03 Jul '14

03 Jul '14

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: add buttons in the new cluster dialog and make it closeable ...................................................................... webadmin: add buttons in the new cluster dialog and make it closeable When create a cluster from the system tree panel, e.g. select a ovirtmgmt node in the system tree and select Clusters source tab, then click the New button, the "New Cluster" dialog has no OK button, Cancel button and cannot be closed. The selected node in the system tree is not a Data Center Node, but it was converted into a Data Center Node in the codes. So the codes generated a exception and could not reach the codes that add buttons. This patch fixed the problem. Change-Id: I33802bc7d3a703e6b15b7674a8255a50cf34e4f0 Bug-Url: https://bugzilla.redhat.com/1079180 Signed-off-by: Ma Like <like.ma(a)cs2c.com.cn> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28380 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33802bc7d3a703e6b15b7674a8255a50cf34e4f0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Malike <like.ma(a)cs2c.com.cn> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Malike <like.ma(a)cs2c.com.cn> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: deleted trigger on db upgrade
by laravot＠redhat.com 03 Jul '14

03 Jul '14

Liron Aravot has submitted this change and it was merged. Change subject: core: deleted trigger on db upgrade ...................................................................... core: deleted trigger on db upgrade The upgrade script 03_05_0730_drop_disk_image_dynamic_fk.sql replaces the use of a cascade delete of a foregin key with a trigger. When performing a further update to the db, the functions are being deleted with CASCADE, which will cause the trigger and the function to be deleted and never be added again. The quick solution is to move the trigger/function creation to disk_image_dynamic_sp as we currently don't have any trigger creation infrastructure after update is performed. Upgrade script is provided as well to perform cleanup of orphand records that might have been left in disk_image_dynamic. Change-Id: I594cddb968795a5a6a0d04e2c6bed9002c025ef9 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M packaging/dbscripts/disk_image_dynamic_sp.sql A packaging/dbscripts/upgrade/03_05_0750_delete_orphand_disk_image_dynamic_records.sql 2 files changed, 16 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/29547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I594cddb968795a5a6a0d04e2c6bed9002c025ef9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: Enhance to multi line list box for discovered hosts info
by oourfali＠redhat.com 03 Jul '14

03 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: ui: Enhance to multi line list box for discovered hosts info ...................................................................... ui: Enhance to multi line list box for discovered hosts info Adding host group, discovered host and compute resource informations to multi line list box using ListModelTypeAheadListBoxEditor. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1109543 Change-Id: I3013e6c27f214c92acd50f1867ae84e2e25fcf75 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanComputerResource.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanDiscoveredHost.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostGroup.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalComputeResource.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalDiscoveredHost.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalHostGroup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 9 files changed, 147 insertions(+), 27 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified Vojtech Szocs: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3013e6c27f214c92acd50f1867ae84e2e25fcf75 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: RetrieveImageData headers - use range instead of size
by laravot＠redhat.com 03 Jul '14

03 Jul '14

Liron Aravot has submitted this change and it was merged. Change subject: core: RetrieveImageData headers - use range instead of size ...................................................................... core: RetrieveImageData headers - use range instead of size On patch http://gerrit.ovirt.org/#/c/28465/ the Size header is being replaced with the standart Range header in GET requests for downloading image data - this patch changes the engine to use the Range header as well. Change-Id: Ie15ad8b48c24d3983ae352f719267356eea16572 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/RetrieveImageDataVDSCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/29481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie15ad8b48c24d3983ae352f719267356eea16572 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Refactor shared storage options on DataCenterGuide...
by tnisan＠redhat.com 03 Jul '14

03 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Refactor shared storage options on DataCenterGuideModel ...................................................................... webadmin: Refactor shared storage options on DataCenterGuideModel Refactored the update of available actions on shared storage in DataCenterGuideModel, extracted methods, removed redundant code and such Change-Id: I0ac7b5bd949f659e5a7c008db87c708187744575 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java 1 file changed, 87 insertions(+), 108 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ac7b5bd949f659e5a7c008db87c708187744575 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: import glance image - update destinationImage status
by oourfali＠redhat.com 03 Jul '14

03 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: import glance image - update destinationImage status ...................................................................... core: import glance image - update destinationImage status Following change-id I37eba72dabb17c5ff4c9edaca899f206440791d0, ImportRepoImageCopyTaskHandler -> endSuccessfully/endWithFailure: ImageStatus should be updated according to 'destinationImageId' (as it is saved in entity_snapshot for compensation). Change-Id: I350de04cffba44ce1e394179305824d4ccaf544c Bug-Url: https://bugzilla.redhat.com/1102785 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I350de04cffba44ce1e394179305824d4ccaf544c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: setup: Allow dwh on separate host
by ydary＠redhat.com 03 Jul '14

03 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Allow dwh on separate host ...................................................................... packaging: setup: Allow dwh on separate host Change-Id: I06fc960481af258b3954a8968be3439393d3ebdb Bug-Url: https://bugzilla.redhat.com/1080997 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine-dwh.spec.in M packaging/setup/ovirt_engine_setup/dwh/constants.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/core/misc.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/config.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/misc.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/connection.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/provisioning/postgres.py 9 files changed, 196 insertions(+), 223 deletions(-) Approvals: Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06fc960481af258b3954a8968be3439393d3ebdb Gerrit-PatchSet: 21 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in samples-portals[master]: python: update the README file
by shavivi＠redhat.com 03 Jul '14

03 Jul '14

Shahar Havivi has submitted this change and it was merged. Change subject: python: update the README file ...................................................................... python: update the README file Change-Id: Ib246ca7d680ca903a650cd21406bad617b197e0a Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M python/README 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib246ca7d680ca903a650cd21406bad617b197e0a Gerrit-PatchSet: 2 Gerrit-Project: samples-portals Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: don't rely on priority
by oschreib＠redhat.com 03 Jul '14

03 Jul '14

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: don't rely on priority ...................................................................... packaging: setup: don't rely on priority Don't rely on priority for disabling plugins. Change-Id: I85c0b6f826745b7619517f3cf06a5704b61584e5 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/appmode.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/connection.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/fence_kdump_listener/config.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py 9 files changed, 19 insertions(+), 9 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85c0b6f826745b7619517f3cf06a5704b61584e5 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0