July 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: API: Interface name is not set via cloud-init api
by juan.hernandez＠redhat.com 02 Jul '14

02 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: API: Interface name is not set via cloud-init api ...................................................................... API: Interface name is not set via cloud-init api Change-Id: I2108863d9ac1463d72b5b5fb139a04fba0f99b0d Bug-Url: https://bugzilla.redhat.com/1115389 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2108863d9ac1463d72b5b5fb139a04fba0f99b0d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: bll: host-deploy: print correct paths in error message
by oourfali＠redhat.com 02 Jul '14

02 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: bll: host-deploy: print correct paths in error message ...................................................................... bll: host-deploy: print correct paths in error message Change-Id: I9e494ef19083485d9c75f839df2fce884916374e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e494ef19083485d9c75f839df2fce884916374e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add support for annotation indexes
by rgolan＠redhat.com 02 Jul '14

02 Jul '14

Roy Golan has submitted this change and it was merged. Change subject: core: Add support for annotation indexes ...................................................................... core: Add support for annotation indexes This change modifies the maven plugin that generates JBoss modules so that it creates annotation indexes. For each .jar file inside the module a new META-INF/jandex.idx resource will be added. These annotations index speeds up the deployment of the applications and are required in order to allow scanning of annotations from other modules, otherwise they are silently ignored. Change-Id: I3556fc385efc2ae138d2ad12b7d9d467bb5fff67 Related: https://bugzilla.redhat.com/1113485 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dependencies/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/jboss-modules-maven-plugin/src/main/java/org/ovirt/engine/build/Module.java M build-tools-root/jboss-modules-maven-plugin/src/main/java/org/ovirt/engine/build/ModulesMojo.java M pom.xml 5 files changed, 89 insertions(+), 11 deletions(-) Approvals: Juan Hernandez: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3556fc385efc2ae138d2ad12b7d9d467bb5fff67 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: missing links in scheduling policies resource
by gchaplik＠redhat.com 01 Jul '14

01 Jul '14

Gilad Chaplik has submitted this change and it was merged. Change subject: restapi: missing links in scheduling policies resource ...................................................................... restapi: missing links in scheduling policies resource Change-Id: I693e228efc3aeac1cee9f0d7342248713f1c5432 Bug-Url: https://bugzilla.redhat.com/1113482 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSchedulingPoliciesResource.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ori Liel: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/29399 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I693e228efc3aeac1cee9f0d7342248713f1c5432 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: double cdrom and video devices if both template and in...
by ofrenkel＠redhat.com 01 Jul '14

01 Jul '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: double cdrom and video devices if both template and instance type used ...................................................................... core: double cdrom and video devices if both template and instance type used The problem was that when both template and instance type is used, first all the devices has been copied from the instance type using the VmDeviceUtils.copyVmDevices (which creates by default also the cdrom and the video devices). Than, the disk and and CD device is copied from the template also using the VmDeviceUtils.copyVmDevices which again by default creates a new CD and video device. This way they are duplicated. Fixed by creating a new method VmDeviceUtils.copyDiskDevices() which makes sure to copy only the disks and do not create any new devices and calling this method instead of copyVmDevices. Change-Id: Id6dfbced0b702f3ce0e71283b1e7c4b4cf2604f6 Bug-Url: https://bugzilla.redhat.com/1109880 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 2 files changed, 22 insertions(+), 12 deletions(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6dfbced0b702f3ce0e71283b1e7c4b4cf2604f6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[sdk_3.5]: codegen: Naming exception for scheduling policy
by juan.hernandez＠redhat.com 01 Jul '14

01 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Naming exception for scheduling policy ...................................................................... codegen: Naming exception for scheduling policy The plural of the new SchedulingPolicy entity has to be managed as an exception to the rule that plurals are formed adding an "s" to the singular. Change-Id: Iac4e9b0b47314ce062bf87718360209bd55960f4 Bug-Url: https://bugzilla.redhat.com/1114655 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 45aa45eef0481a75cf82e024c33adb9dc73b6343) --- M src/codegen/rsdl/rsdlcodegen.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac4e9b0b47314ce062bf87718360209bd55960f4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[sdk_3.5]: codegen: Support plural exceptions
by juan.hernandez＠redhat.com 01 Jul '14

01 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Support plural exceptions ...................................................................... codegen: Support plural exceptions Currently we have a set of entity names whose corresponding collection name isn't formed by just adding an "s" to the end: the name of the entity and the collection is the same. But we will soon introduce some entities where the name of the collection can't be derived in this simple way, in particular we will introduce the SchedulingPolicy entity and the SchedulingPolicies collection. To support that, this patch changes the list of collections to a map, so that the name of the entity and the name of the collection can be different. Change-Id: I97d45d533e12723426f98dad2874de3945fd483b Related: https://bugzilla.redhat.com/1114655 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit e9d510434a94b19435440e7b0769f96c5a4d0f0c) --- M src/codegen/rsdl/rsdlcodegen.py M src/codegen/utils/stringutils.py 2 files changed, 20 insertions(+), 11 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97d45d533e12723426f98dad2874de3945fd483b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: codegen: Naming exception for scheduling policy
by juan.hernandez＠redhat.com 01 Jul '14

01 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Naming exception for scheduling policy ...................................................................... codegen: Naming exception for scheduling policy The plural of the new SchedulingPolicy entity has to be managed as an exception to the rule that plurals are formed adding an "s" to the singular. Change-Id: Iac4e9b0b47314ce062bf87718360209bd55960f4 Bug-Url: https://bugzilla.redhat.com/1114655 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/codegen/rsdl/rsdlcodegen.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Daniel Erez: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac4e9b0b47314ce062bf87718360209bd55960f4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: codegen: Support plural exceptions
by juan.hernandez＠redhat.com 01 Jul '14

01 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Support plural exceptions ...................................................................... codegen: Support plural exceptions Currently we have a set of entity names whose corresponding collection name isn't formed by just adding an "s" to the end: the name of the entity and the collection is the same. But we will soon introduce some entities where the name of the collection can't be derived in this simple way, in particular we will introduce the SchedulingPolicy entity and the SchedulingPolicies collection. To support that, this patch changes the list of collections to a map, so that the name of the entity and the name of the collection can be different. Change-Id: I97d45d533e12723426f98dad2874de3945fd483b Related: https://bugzilla.redhat.com/1114655 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/codegen/rsdl/rsdlcodegen.py M src/codegen/utils/stringutils.py 2 files changed, 20 insertions(+), 11 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97d45d533e12723426f98dad2874de3945fd483b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[ovirt-3.5]: Corrections to the build system for el5
by vfeenstr＠redhat.com 01 Jul '14

01 Jul '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Corrections to the build system for el5 ...................................................................... Corrections to the build system for el5 Change-Id: I401b4b0ff68abaf492ab31379c79a18c588cfa00 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/Makefile.am M ovirt-guest-agent/Makefile.el5 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Martin Betak: Looks good to me, but someone else must approve Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I401b4b0ff68abaf492ab31379c79a18c588cfa00 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0