Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Change disk alias suggestions to use alias recycling
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Change disk alias suggestions to use alias recycling
......................................................................
webadmin: Change disk alias suggestions to use alias recycling
In change 24061, disk alias suggestions was changed not to suggest a disk
alias that is already attached to the VM, this change now also makes sure
that the aliases will be recycled (i.e. if we had alias1 and alias2 and we
deleted alias1, the next suggestion will be alias1)
Change-Id: I8d5b8ba00a144b864208d971def7087182538be2
Bug-Url: https://bugzilla.redhat.com/1122932
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQueryTest.java
2 files changed, 13 insertions(+), 8 deletions(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31961
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d5b8ba00a144b864208d971def7087182538be2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[master]: webadmin: Validate VM disk aliases when creating template
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Validate VM disk aliases when creating template
......................................................................
webadmin: Validate VM disk aliases when creating template
When creating a template from a VM, validate the future disk aliases of the
template so they are not empty and contain only alphanumeric chars
Change-Id: I9da39e89c6ae2f289363983e235e65f1d09687ec
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1110309
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31978
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9da39e89c6ae2f289363983e235e65f1d09687ec
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin: disk dialog - capitalize casing of LUN
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: disk dialog - capitalize casing of LUN
......................................................................
webadmin: disk dialog - capitalize casing of LUN
Disk Dialog:
s/Direct Lun/Direct LUN
Change-Id: I40cce8e3f19b4e2b81d334d69ee6c2d21161be17
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31948
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40cce8e3f19b4e2b81d334d69ee6c2d21161be17
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin: warning for moving disk when VM is paused
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: warning for moving disk when VM is paused
......................................................................
webadmin: warning for moving disk when VM is paused
Added warning [1] also when VM is in Paused status.
[1] "Moving disk(s) while the VM is running"
Change-Id: I0df1dc2d466a652d4597c9a2a24e4615cd7b309e
Bug-Url: https://bugzilla.redhat.com/1110803
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/31943
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0df1dc2d466a652d4597c9a2a24e4615cd7b309e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: engine: Report domain monitoring for virt nodes only
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Report domain monitoring for virt nodes only
......................................................................
engine: Report domain monitoring for virt nodes only
Storage domain monitoring is required only for
virtualization nodes (not for gluster nodes)
Change-Id: I8731a81de756cbe0bb221f205c2a6d50c015b86b
Bug-Url: https://bugzilla.redhat.com/1105513
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Sahina Bose: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31703
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8731a81de756cbe0bb221f205c2a6d50c015b86b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: send virtio-serial device to VDSM
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: send virtio-serial device to VDSM
......................................................................
core: send virtio-serial device to VDSM
Add virtio-serial to the list of devices the engine sends to VDSM
Change-Id: Ie99dafc1495f42ffcd76592dcd9130f12c6d61bd
Bug-Url: https://bugzilla.redhat.com/1028387
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceGeneralType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java
8 files changed, 31 insertions(+), 0 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/31883
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie99dafc1495f42ffcd76592dcd9130f12c6d61bd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: use previously used address of balloon device
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: use previously used address of balloon device
......................................................................
core: use previously used address of balloon device
We should pass the previously used address of balloon device when
running VM so it won't be detected as a new device and trigger
the 'install driver for new device' dialog in the guest
Change-Id: Ie4b93a14f395c3e7bdb83dc0a25dbda0546e4e92
Bug-Url: https://bugzilla.redhat.com/1028387
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/31882
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4b93a14f395c3e7bdb83dc0a25dbda0546e4e92
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: userportal: Adjust protocol message
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: userportal: Adjust protocol message
......................................................................
userportal: Adjust protocol message
This patch corrects protocol message in Basic User Portal. Previously
the message contained confusing information.
Fixed by displaying protocol name for selected VM/Pool.
Also removed some duplicate code.
Change-Id: I12a3746c70ce9fdb84e8807fc469f8f0cdb3c812
Bug-Url: https://bugzilla.redhat.com/1078138
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java
2 files changed, 17 insertions(+), 21 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Frank Kobzik: Verified
--
To view, visit http://gerrit.ovirt.org/30538
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12a3746c70ce9fdb84e8807fc469f8f0cdb3c812
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: aaa: Engine should start even if exception occured in load o...
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: Engine should start even if exception occured in load of legacy provider
......................................................................
aaa: Engine should start even if exception occured in load of legacy provider
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1129203
Change-Id: I6ba595253c2569cf581e690b68348e6ae1c804b1
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/DirectorySearcher.java
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Utils.java
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/dns/DnsSRVLocator.java
3 files changed, 26 insertions(+), 9 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29879
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ba595253c2569cf581e690b68348e6ae1c804b1
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: aaa: Associate users only with managed groups by oVirt
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: Associate users only with managed groups by oVirt
......................................................................
aaa: Associate users only with managed groups by oVirt
This patch will store at groupNames only groups that are managed
by Ovirt (i.e - groups that exist in the groups DB table).
Change-Id: I8a5daf3c68cc04ebd4ad0ec6cfdfd6cf16ececb9
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SyncUsers.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbUserDAOTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUserResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResourceTest.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/LinqUtils.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/linq/LinqUtilsTest.java
17 files changed, 67 insertions(+), 77 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31757
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a5daf3c68cc04ebd4ad0ec6cfdfd6cf16ececb9
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months