August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: Cpu Profile CRUD commands and queries
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Cpu Profile CRUD commands and queries ...................................................................... core: Cpu Profile CRUD commands and queries Change-Id: I6be41103ad9b04fc7d0b530439ab4a2c731bbded Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetCpuProfilesByCpuQosIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddCpuProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddDiskProfileCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddProfileCommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/GetAllCpuProfilesQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/GetCpuProfileByIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/GetCpuProfilesByClusterIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/ProfileCommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/ProfileValidator.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveCpuProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveDiskProfileCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveProfileCommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/UpdateCpuProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/UpdateDiskProfileCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/UpdateProfileCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CpuProfileParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DiskProfileParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ProfileParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 29 files changed, 581 insertions(+), 135 deletions(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6be41103ad9b04fc7d0b530439ab4a2c731bbded Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core, db: Introduce CPU profile DAL
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core, db: Introduce CPU profile DAL ...................................................................... core, db: Introduce CPU profile DAL Change-Id: I9d3b9d4737d523a722a688485e45d2a77775e2ea Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcObjectType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/profiles/CpuProfileDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/profiles/CpuProfileDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/profiles/CpuProfileDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/cpu_profiles_sp.sql M packaging/dbscripts/create_functions.sql A packaging/dbscripts/upgrade/03_05_0980_add_cpu_profiles_table.sql R packaging/dbscripts/upgrade/03_05_0990_add_cpu_limit_to_qos_table.sql 13 files changed, 462 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d3b9d4737d523a722a688485e45d2a77775e2ea Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: common: Introduce CPU profile
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: common: Introduce CPU profile ...................................................................... common: Introduce CPU profile CpuProfile contains common profile fields (extends profile base: qos, name, desc, etc.) and cluster which its attached to. Change-Id: I4d4a1926d0ad99557d4752bc81e572b499577c9d Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/CpuProfile.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileType.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 3 files changed, 62 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d4a1926d0ad99557d4752bc81e572b499577c9d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add crud commands and queries for Cpu Qos
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add crud commands and queries for Cpu Qos ...................................................................... core: Add crud commands and queries for Cpu Qos Adding commands to hanle the new Cpu Qos With multiple paragraphs if necessary. Using qos infra to handle queries. Change-Id: I101b1325e89e68f548bfcf83fe7e0033b88419e6 Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QosQueryBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/AddCpuQosCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/RemoveCpuQosCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/UpdateCpuQosCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/CpuQosValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 6 files changed, 107 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I101b1325e89e68f548bfcf83fe7e0033b88419e6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core, db: Adding Cpu Qos DB config
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core, db: Adding Cpu Qos DB config ...................................................................... core, db: Adding Cpu Qos DB config Adding the Cpu Qos db config, the Cpu Qos consists of one parameter: cpu_limit. The parameter will be added to the qos table. support for this feature is for all 3.x versions. Also changed Storage Qos insert and update stored proc to fit common behavior ("insert"+"storage"/"cpu"+"qos"). Change-Id: I533bcc601ac44289c51f5d56a6da0dd2455116d6 Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DefaultGenericDaoDbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/AllQosBaseDaoFacadeImpl.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/CpuQosDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/CpuQosDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/QosBaseDaoFacadeImpl.java M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/qos/CpuQosDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/qos_sp.sql A packaging/dbscripts/upgrade/03_06_0980_add_cpu_limit_to_qos_table.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 16 files changed, 251 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I533bcc601ac44289c51f5d56a6da0dd2455116d6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: common: Adding the CpuQos entity
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: common: Adding the CpuQos entity ...................................................................... common: Adding the CpuQos entity Adding a Cpu Qos entity that will be used by the cpu profile. the cpu profile will be used to set cpu sla parameters of the vm. Change-Id: I2134a778d70b3c9ff3e78cc38282a515250b7cf2 Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/CpuQos.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 4 files changed, 66 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2134a778d70b3c9ff3e78cc38282a515250b7cf2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: attach device ioTune map
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: attach device ioTune map ...................................................................... core: attach device ioTune map Provide vdsm with device's ioTune data, when a disk has disk profile and qos object. for more info see: http://libvirt.org/formatdomain.html#elementsDisks Change-Id: I515caa7ff8996711610a77a57d6683d2655545de Bug-Url: https://bugzilla.redhat.com/1085049 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 2 files changed, 73 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I515caa7ff8996711610a77a57d6683d2655545de Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core, db: add getQosByDiskProfile
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core, db: add getQosByDiskProfile ...................................................................... core, db: add getQosByDiskProfile a single query to avoid 2: * getDiskProfile * getQos Change-Id: If8e9b246172497412b3dc13d46af85fd155713cf Bug-Url: https://bugzilla.redhat.com/1085049 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/StorageQosDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/StorageQosDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/qos/StorageQosDaoTest.java M packaging/dbscripts/qos_sp.sql 4 files changed, 37 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8e9b246172497412b3dc13d46af85fd155713cf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: extend DiskProfile.getAllForStorageDomain to a user query
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: extend DiskProfile.getAllForStorageDomain to a user query ...................................................................... core: extend DiskProfile.getAllForStorageDomain to a user query getAllForStorageDomain is extended to a user query, which will be consumed by the user portal as well. In terms of MLA hierarchy, Disk profile is a under Storage Domain (SD), so all the disk profiles attached to the SD will return if user has permission to the SD, i.e. for we rely on SD permissions (with no change from current flow). Change-Id: I3bb75728cd76bba7e39de2314275f5bc87942c6b Bug-Url: https://bugzilla.redhat.com/1085049 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/GetDiskProfilesByStorageDomainIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/profiles/DiskProfileDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/profiles/DiskProfileDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/profiles/DiskProfileDaoTest.java M packaging/dbscripts/disk_profiles_sp.sql 6 files changed, 43 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bb75728cd76bba7e39de2314275f5bc87942c6b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: add GetDiskProfilesByStorageQosIdQuery
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: add GetDiskProfilesByStorageQosIdQuery ...................................................................... core: add GetDiskProfilesByStorageQosIdQuery This query retireves all disk profiles by qos id. Added to ProfilesDao as well. Change-Id: I6a8e675506cf698d6545a69c919220835fcb835c Bug-Url: https://bugzilla.redhat.com/1085049 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskProfilesByStorageQosIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/profiles/DiskProfileDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/profiles/ProfilesDao.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/profiles/DiskProfileDaoTest.java M packaging/dbscripts/disk_profiles_sp.sql 6 files changed, 57 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a8e675506cf698d6545a69c919220835fcb835c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0