Change in ovirt-engine[ovirt-engine-3.5]: db, core: aggregate qos and storage qos impl
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: db, core: aggregate qos and storage qos impl
......................................................................
db, core: aggregate qos and storage qos impl
- DB and DAL changes: create qos table to accomodate qos objects and include
storage qos and its limits.
- added qos_sp.sql to add default sp.
For more information see: http://www.ovirt.org/Features/aggregate_QoS,
http://www.ovirt.org/Features/blkio-support
Change-Id: I1a9af59277b5055453159f002f19046c0051d63b
Bug-Url: https://bugzilla.redhat.com/1085049
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDAODbFacade.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/QosBaseDaoFacadeImpl.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/QosDao.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/StorageQosDao.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/StorageQosDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/qos/StorageQosDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
A packaging/dbscripts/qos_sp.sql
A packaging/dbscripts/upgrade/03_05_0940_add_qos_table.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
16 files changed, 439 insertions(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31804
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d63b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: common: introduce qos package, and storage qos
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: common: introduce qos package, and storage qos
......................................................................
common: introduce qos package, and storage qos
- Base Qos abstract class, in the future all QoS will inherit it.
- QosType (version >= 3.3 network, version >= 3.5 disk, cpu), to distinguish
between the types.
- StorageQos object as the first implementation.
- Handle field validation propeties.
For more information see http://www.ovirt.org/Features/aggregate_QoS,
http://www.ovirt.org/Features/blkio-support
Change-Id: I1a9af59277b5055453159f002f19046c0051d8ff
Bug-Url: https://bugzilla.redhat.com/1085049
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosBase.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/StorageQos.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 377 insertions(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d8ff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Add disk device after disk is added
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add disk device after disk is added
......................................................................
core: Add disk device after disk is added
Currently, AddDiskCommand adds the device to the DB,
before the disk is there, this cause the boot order not to take the new
disk into consideration.
In this patch the addition of the device is moved after the disk is
created by the disk is in the db.
Change-Id: I2f2fc8e6771ed2b352f2bde7b4e313481df76b90
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131018
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
1 file changed, 14 insertions(+), 10 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, but someone else must approve
Omer Frenkel: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31867
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f2fc8e6771ed2b352f2bde7b4e313481df76b90
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin: set default plugin for provider
by lvernia@redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: set default plugin for provider
......................................................................
webadmin: set default plugin for provider
set default value of external network provider to 'Open vSwitch' set
'RabbitMQ' as default broker type of Agent config
Bug-Url: https://bugzilla.redhat.com/1118253
Change-Id: I52abd0ea1a6a923374e6ab094ff2a81f145f443a
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronAgentModel.java
1 file changed, 9 insertions(+), 3 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31763
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52abd0ea1a6a923374e6ab094ff2a81f145f443a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: Add disk device after disk is added
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Add disk device after disk is added
......................................................................
core: Add disk device after disk is added
Currently, AddDiskCommand adds the device to the DB,
before the disk is there, this cause the boot order not to take the new
disk into consideration.
In this patch the addition of the device is moved after the disk is
created by the disk is in the db.
Change-Id: I2f2fc8e6771ed2b352f2bde7b4e313481df76b90
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131018
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
1 file changed, 14 insertions(+), 10 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, but someone else must approve
Omer Frenkel: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31723
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f2fc8e6771ed2b352f2bde7b4e313481df76b90
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[master]: core: add missing configuration values
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: add missing configuration values
......................................................................
core: add missing configuration values
Add missing configuration values that disable storage & cpu QOS for
cluster compatibility version 3.2.
Change-Id: Ic05f428ccdba2b9096aacef492e84820ab5c8a9d
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Gilad Chaplik: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/31862
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic05f428ccdba2b9096aacef492e84820ab5c8a9d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-reports[master]: reports: updated br7b legend
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: updated br7b legend
......................................................................
reports: updated br7b legend
updated br7b legend so the text will stretch
with overflow.
Change-Id: I54f4c1005c6531afbd04c8592db7d5e43e2e0ab0
Bug-Url: https://bugzilla.redhat.com/1031757
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/Reports/Service_level/Hosts/top_10_downtime_hosts_br7b_files/report5.jrxml.data
M packaging/ovirt-reports/resources/Reports/Service_level/Hosts/top_10_downtime_hosts_br7b_files/top_10_downtime_hosts_br7b_jrxml.data
2 files changed, 70 insertions(+), 41 deletions(-)
Approvals:
Shirly Radco: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31688
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54f4c1005c6531afbd04c8592db7d5e43e2e0ab0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[master]: webadmin: Remove redundant header splitter
by lvernia@redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Remove redundant header splitter
......................................................................
webadmin: Remove redundant header splitter
The styling of ResizableHeader added a right border, which is
redundant in the case of an EntityModelCellTable because there's
always the left border of the next column header (as opposed to
ActionCellTable whose styling works differently).
Change-Id: Ied14df6f093514e26bbeb3dc60e509d58d056dae
Bug-Url: https://bugzilla.redhat.com/1125192
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ResizableHeader.java
3 files changed, 27 insertions(+), 6 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31579
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied14df6f093514e26bbeb3dc60e509d58d056dae
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin: fixed error icon position in dialog
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: fixed error icon position in dialog
......................................................................
webadmin: fixed error icon position in dialog
Commit e9f27f4 caused the error icon to be off by a few pixels.
Fixed.
Change-Id: Ic4ebee8e86f6fdc840e5242a571b2cbc95c82dca
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M packaging/branding/ovirt.brand/common.css
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Greg Sheremeta: Verified
--
To view, visit http://gerrit.ovirt.org/31848
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4ebee8e86f6fdc840e5242a571b2cbc95c82dca
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin: fix error dialog padding
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: fix error dialog padding
......................................................................
webadmin: fix error dialog padding
Commit 2e5c0cd0 incorrectly used margin in the error dialog instead
of padding. Fixed.
Change-Id: I29c94ed143b568efb1832f129b43fd9fc420b4ae
Bug-Url: https://bugzilla.redhat.com/1127333
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ErrorPopupView.ui.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit http://gerrit.ovirt.org/31847
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29c94ed143b568efb1832f129b43fd9fc420b4ae
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months