August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: extract constant from HibernateVmCommand
by amureini＠redhat.com 31 Aug '14

31 Aug '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: extract constant from HibernateVmCommand ...................................................................... core: extract constant from HibernateVmCommand META_DATA_SIZE_IN_BYTES was extracted to MemoryUtils due to use in several vm related commands, as well as need for it in another command in bz1119022 fix. Change-Id: I1604cf4a82e3e202093acdab97939427ab335169 Bug-Url: https://bugzilla.redhat.com/1119022 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryUtils.java 5 files changed, 12 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/32174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1604cf4a82e3e202093acdab97939427ab335169 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: WARNING when failed to create OVF Store
by amureini＠redhat.com 31 Aug '14

31 Aug '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: WARNING when failed to create OVF Store ...................................................................... core: WARNING when failed to create OVF Store Changed audit log severity to WARNING to indicate that there's a problem here. Change-Id: I78171fd1890435c9f98efec88496e81e5f84b9ce Bug-Url: https://bugzilla.redhat.com/1134371 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78171fd1890435c9f98efec88496e81e5f84b9ce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: do not consider powering up -> up as powered up transi...
by ahadas＠redhat.com 31 Aug '14

31 Aug '14

Arik Hadas has submitted this change and it was merged. Change subject: core: do not consider powering up -> up as powered up transition ...................................................................... core: do not consider powering up -> up as powered up transition If the VM status is changed from powering-up to up, we should not do the handling we do for powered up VMs, as we already did it when the VM was switched to powering-up state. Checking the display as part of the check that determines whether the VM should be handled as VM that was powered-up, is not needed and thus it is also removed as part of this change. Change-Id: Ifc72aa638ca5722fe5bb50c600374f47a42511cd Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 4 insertions(+), 11 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc72aa638ca5722fe5bb50c600374f47a42511cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: set QoS href under profile
by dfediuck＠redhat.com 31 Aug '14

31 Aug '14

Doron Fediuck has submitted this change and it was merged. Change subject: engine: set QoS href under profile ...................................................................... engine: set QoS href under profile * Add a qurey to fetch all qos entities by type * For disk, cpu and vnic profile, fetch all qos objects (if needed), and set the DataCenter, inorder to map it to correct path (/DataCenter/<dc_id>/qoss/<qos_id>/) Change-Id: Ib345485d9d64d3adf28c2ea61a17c0cc0c828abb Bug-Url: https://bugzilla.redhat.com/1078863 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllQosByTypeQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/QosBaseDaoFacadeImpl.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCpuProfileResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCpuProfilesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDiskProfileResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDiskProfilesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfileResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfilesResource.java M packaging/dbscripts/qos_sp.sql 10 files changed, 199 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib345485d9d64d3adf28c2ea61a17c0cc0c828abb Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: support for adding network qos for rest-api
by dfediuck＠redhat.com 31 Aug '14

31 Aug '14

Doron Fediuck has submitted this change and it was merged. Change subject: engine: support for adding network qos for rest-api ...................................................................... engine: support for adding network qos for rest-api * NetworkQoS will override QosBase * Move NetworkQos dao to use QosBaseDao * Move network_qos data to qos table, and all its references * Move network qos CRUD command to use qos infra Change-Id: I34f43f9edc10b7b52e096b2b6f1f43d19f129ed5 Bug-Url: https://bugzilla.redhat.com/1078863 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllNetworkQosByStoragePoolIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetQosByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QosQueryBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsInterfacesByVdsIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/AddNetworkQoSCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/NetworkQoSCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/RemoveNetworkQoSCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/RemoveQosCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/UpdateNetworkQoSCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/UpdateQosCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkQosValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/QosValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VnicProfileValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkQosValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VnicProfileValidatorTest.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/NetworkQoSParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkQoS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/CpuQos.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/StorageQos.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkQoSDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkQoSDaoFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/AllQosBaseDaoFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/InterfaceDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkQosDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkQoSModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkQoSModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/RemoveNetworkQoSModel.java M packaging/dbscripts/create_views.sql D packaging/dbscripts/network_qos_sp.sql M packaging/dbscripts/qos_sp.sql A packaging/dbscripts/upgrade/03_06_0330_refactor_network_qos.sql 45 files changed, 381 insertions(+), 576 deletions(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31868 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34f43f9edc10b7b52e096b2b6f1f43d19f129ed5 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: support for adding network QoS
by dfediuck＠redhat.com 31 Aug '14

31 Aug '14

Doron Fediuck has submitted this change and it was merged. Change subject: restapi: support for adding network QoS ...................................................................... restapi: support for adding network QoS Adding a NETWORK type for QoS entity, and adding it to current QoS infra. Adding QoS to Vnic Profile entity. Change-Id: I5104c61b484683fbee0ead9a9d0934ec93a6c4cd Bug-Url: https://bugzilla.redhat.com/1078863 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/QosType.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQosResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQossResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAssignedCpuProfileResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAssignedDiskProfileResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCpuProfileResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDiskProfileResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VnicProfileMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NetworkQosMapperTest.java 13 files changed, 118 insertions(+), 10 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/31869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5104c61b484683fbee0ead9a9d0934ec93a6c4cd Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove redundant message in UpdateVmInterfaceCommand...
by masayag＠redhat.com 31 Aug '14

31 Aug '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove redundant message in UpdateVmInterfaceCommand.canDoAction ...................................................................... engine: Remove redundant message in UpdateVmInterfaceCommand.canDoAction Remove redundant ACTION_TYPE_FAILED_VM_NOT_EXIST message in UpdateVmInterfaceCommand.canDoAction method. Change-Id: I381de1d18f5f094fc1c5d12e06949141d045f525 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/32004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I381de1d18f5f094fc1c5d12e06949141d045f525 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: clone VM from snapshot - validate VirtIO-SCSI
by derez＠redhat.com 31 Aug '14

31 Aug '14

Daniel Erez has submitted this change and it was merged. Change subject: core: clone VM from snapshot - validate VirtIO-SCSI ...................................................................... core: clone VM from snapshot - validate VirtIO-SCSI Validate whether VirtIO-SCSI can be disabled when cloning a VM from snapshot (similar to the validation on UpdateVmCommand): * Added a validation method to VmValidator. * Added appropriate tests. Change-Id: I31d4ebe3a964fb54cb1a905460b9da785a746419 Bug-Url: https://bugzilla.redhat.com/1133475 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmValidatorTest.java 6 files changed, 137 insertions(+), 9 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31d4ebe3a964fb54cb1a905460b9da785a746419 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove unneeded code which might produce NPE
by ofrenkel＠redhat.com 31 Aug '14

31 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: remove unneeded code which might produce NPE ...................................................................... core: remove unneeded code which might produce NPE VdsEventListener#processOnVmPoweringUp contained block of code in a if clause that could never be executed as all the commands that implement the IVdsAsyncCommand interface returned null in their getAutoStartVdsId method, thus the condition in the if statement was always false. Because of a race which is similar to the one which was fixed by Icaca2a3, the check inside the if-condition could produce NPE. So in this patch this block of code is removed. The signature of VdsEventListener#processOnVmPoweringUp and IVdsAsyncCommand interface were cleaned up by removing things which are not needed anymore. Change-Id: Iffef34726c7feb87be1436c003eded2e226d7e5d Bug-Url: https://bugzilla.redhat.com/1134701 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsAsyncCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 5 files changed, 4 insertions(+), 47 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/32107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffef34726c7feb87be1436c003eded2e226d7e5d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Initialize internal lists in IscsiBond
by oourfali＠redhat.com 30 Aug '14

30 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Initialize internal lists in IscsiBond ...................................................................... core: Initialize internal lists in IscsiBond Initialize the storage domains and the networks when fectching IscsiBond from query command, also adding a test to the query. Change-Id: I167b1c6d6c5f83022c18faad555c0ff2e6f1f44b Bug-Url: https://bugzilla.redhat.com/1133279 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetIscsiBondByIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetIscsiBondByIdQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetIscsiBondByIdQueryTest.java 3 files changed, 142 insertions(+), 15 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/32128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I167b1c6d6c5f83022c18faad555c0ff2e6f1f44b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0