Change in ovirt-engine[master]: engine : Second suspend of a vm doesn't work
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine : Second suspend of a vm doesn't work
......................................................................
engine : Second suspend of a vm doesn't work
When the vm is suspended in succession the
second time it is suspended after a run the backend
throws a NPE because the RunVMCommand does not
set the entity info in the action parameters.
Change-Id: Ib6d142ad00e9045a615d5489cb7104a2404bcf08
Bug-Url: https://bugzilla.redhat.com/1128807
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ravi Nori: Verified
Omer Frenkel: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/31525
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6d142ad00e9045a615d5489cb7104a2404bcf08
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Rephrase messages to fit label operations
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Rephrase messages to fit label operations
......................................................................
webadmin: Rephrase messages to fit label operations
Since same errors are used for bonding and for labelling, rephrased
the messages to fit both.
Change-Id: I249b8eebaa1dcec35e4c50c30a8e3f440b952188
Bug-Url: https://bugzilla.redhat.com/1115109
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
3 files changed, 5 insertions(+), 11 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/31518
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I249b8eebaa1dcec35e4c50c30a8e3f440b952188
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Don't trigger event when assigning label
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Don't trigger event when assigning label
......................................................................
webadmin: Don't trigger event when assigning label
Since we're only mocking another operation to assign a label to a NIC,
the code is changed to not trigger an event (that would affect the
status panel).
Change-Id: I676ddff5293d1a7e22a911bb3b03e6da6707c493
Bug-Url: https://bugzilla.redhat.com/1115109
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/31517
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I676ddff5293d1a7e22a911bb3b03e6da6707c493
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Reset status panel on redraw
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Reset status panel on redraw
......................................................................
webadmin: Reset status panel on redraw
A recent regression caused status messages to linger on past a
redraw. This is changed so only warning messages survive
redraws.
Change-Id: Ic110c6dd4198a03c3274dfbb9fe39a8687a9861a
Bug-Url: https://bugzilla.redhat.com/1115109
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/OperationCadidateEventArgs.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/StatusLabel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/StatusPanel.java
6 files changed, 23 insertions(+), 35 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/31516
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic110c6dd4198a03c3274dfbb9fe39a8687a9861a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core:typo in power management health check warning
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core:typo in power management health check warning
......................................................................
core:typo in power management health check warning
Change-Id: I06273bdd9f318930c70b6b5577f2e8b6aa8e2d66
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1129621
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31577
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06273bdd9f318930c70b6b5577f2e8b6aa8e2d66
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin: fixes layout of profiles instance type editor in v...
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: fixes layout of profiles instance type editor in vm dialog
......................................................................
webadmin: fixes layout of profiles instance type editor in vm dialog
Change-Id: I329ccb7b15e1b3252659faf8151648318f05b39d
Bug-Url: https://bugzilla.redhat.com/1129194
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alona Kaplan: Verified
Lior Vernia: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31393
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I329ccb7b15e1b3252659faf8151648318f05b39d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin: Host->Interfaces, shorten column width
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Host->Interfaces, shorten column width
......................................................................
webadmin: Host->Interfaces, shorten column width
Change-Id: Iaeda10b5b93b9b0ebde4ec69c3e7f0de80228be9
Bug-Url: https://bugzilla.redhat.com/1115310
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/StatisticsPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java
5 files changed, 24 insertions(+), 24 deletions(-)
Approvals:
Alona Kaplan: Verified
Lior Vernia: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31291
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaeda10b5b93b9b0ebde4ec69c3e7f0de80228be9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin: The are no splitters in the Host>Interface header
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: The are no splitters in the Host>Interface header
......................................................................
webadmin: The are no splitters in the Host>Interface header
Change-Id: Icb276a805508b5f2729f609ec2861504a561acea
Bug-Url: https://bugzilla.redhat.com/1115310
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java
2 files changed, 11 insertions(+), 1 deletion(-)
Approvals:
Alona Kaplan: Verified
Lior Vernia: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb276a805508b5f2729f609ec2861504a561acea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.4]: core: Remove volume & format check on import VM command
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Remove volume & format check on import VM command
......................................................................
core: Remove volume & format check on import VM command
There's no reason to check validaty of the import VM parameters when not
using collapse snapshots since the image format will be determined by the
command itself according to the destination format
Change-Id: I06dc245db032a427d3aa36f62eaae8edcf93f657
Bug-Url: https://bugzilla.redhat.com/1130761
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31560
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06dc245db032a427d3aa36f62eaae8edcf93f657
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: avoid failover on setVolumeDescription default fail
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: avoid failover on setVolumeDescription default fail
......................................................................
core: avoid failover on setVolumeDescription default fail
failues when executing setVolumeDescription shouldn't
trigger the spm failover.
Change-Id: I1db19b03e53ddaa17a941c373668f157b75665b9
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1126782
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SetVolumeDescriptionVDSCommand.java
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit http://gerrit.ovirt.org/31565
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1db19b03e53ddaa17a941c373668f157b75665b9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months