August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin : Optimise for virt store on volumes
by kmayilsa＠redhat.com 19 Aug '14

19 Aug '14

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : Optimise for virt store on volumes ...................................................................... webadmin : Optimise for virt store on volumes This patch adds a check for eligibility to optimise for virt store and just in case the options are not enabled already, it adds the suggested options. Change-Id: I6f995dec2258a3f5fc9673d5d075866b89f7773c Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumePopupView.ui.xml 5 files changed, 122 insertions(+), 26 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f995dec2258a3f5fc9673d5d075866b89f7773c Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Set image format correctly when creating template imag...
by oourfali＠redhat.com 19 Aug '14

19 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Set image format correctly when creating template image on block domain ...................................................................... core: Set image format correctly when creating template image on block domain When creating a template from a VM with a disk on an NFS domain without snapshots (Raw+Sparse) on a block domain, the copy operation will fail since this image configuration is not supported on block domains, this patch causes the format to be changed from raw to cow in this situations to avoid that problem Change-Id: Icfa0843d3cad69682f6030ed47ec1699c106447a Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1131294 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java 1 file changed, 27 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfa0843d3cad69682f6030ed47ec1699c106447a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Set image format correctly when creating template imag...
by tnisan＠redhat.com 19 Aug '14

19 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Set image format correctly when creating template image on block domain ...................................................................... core: Set image format correctly when creating template image on block domain When creating a template from a VM with a disk on an NFS domain without snapshots (Raw+Sparse) on a block domain, the copy operation will fail since this image configuration is not supported on block domains, this patch causes the format to be changed from raw to cow in this situations to avoid that problem Change-Id: Icfa0843d3cad69682f6030ed47ec1699c106447a Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1131226 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java 1 file changed, 27 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfa0843d3cad69682f6030ed47ec1699c106447a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Set image format correctly when creating template imag...
by tnisan＠redhat.com 19 Aug '14

19 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Set image format correctly when creating template image on block domain ...................................................................... core: Set image format correctly when creating template image on block domain When creating a template from a VM with a disk on an NFS domain without snapshots (Raw+Sparse) on a block domain, the copy operation will fail since this image configuration is not supported on block domains, this patch causes the format to be changed from raw to cow in this situations to avoid that problem Change-Id: Icfa0843d3cad69682f6030ed47ec1699c106447a Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1128776 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java 1 file changed, 27 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfa0843d3cad69682f6030ed47ec1699c106447a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: UI:Adding support for host with connectivity..
by tnisan＠redhat.com 19 Aug '14

19 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: UI:Adding support for host with connectivity.. ...................................................................... UI:Adding support for host with connectivity.. Adding support for host with connectivity issues Change-Id: I7d300b37a49261744d81fd397772f70e56e7a688 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120829 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 6 files changed, 121 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31616 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d300b37a49261744d81fd397772f70e56e7a688 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Skip fencing if host has connectivity issues
by tnisan＠redhat.com 19 Aug '14

19 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Skip fencing if host has connectivity issues ...................................................................... core: Skip fencing if host has connectivity issues Change-Id: I7a9c7db43b50421414ce9596137767b00cbfc2ae Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120829 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FencingPolicy.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/upgrade/03_05_0900_skip_fencing_when_connectivity_broken.sql M packaging/dbscripts/vds_groups_sp.sql 8 files changed, 114 insertions(+), 8 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a9c7db43b50421414ce9596137767b00cbfc2ae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: format StorageListModel
by gchaplik＠redhat.com 19 Aug '14

19 Aug '14

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: format StorageListModel ...................................................................... webadmin: format StorageListModel using eclipse formatter. Change-Id: Iac9b645eb610545d94b117c0b3d007daf304294b Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 28 insertions(+), 28 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/31105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac9b645eb610545d94b117c0b3d007daf304294b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: update support of ppc cpus
by oourfali＠redhat.com 18 Aug '14

18 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: update support of ppc cpus ...................................................................... core: update support of ppc cpus Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131021 Change-Id: I75ea7ce447853f653cc45044cbf8ede64c0a8bb9 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75ea7ce447853f653cc45044cbf8ede64c0a8bb9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: ui: redundant call to vminit when initializing vms template
by tnisan＠redhat.com 18 Aug '14

18 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: ui: redundant call to vminit when initializing vms template ...................................................................... ui: redundant call to vminit when initializing vms template When setting vminit to desktop vm (one that have a template), we call again vminit.init() method - after it has been initialize with the right values. Removing that not influence current code work-flow (ie vm, template and pool) Change-Id: Idc2e40f72b85cd3641c6e5c705438cd217308f91 Bug-Url: https://bugzilla.redhat.com/1126195 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/31600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc2e40f72b85cd3641c6e5c705438cd217308f91 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Implement validation in EntityModelCellTable
by tnisan＠redhat.com 18 Aug '14

18 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Implement validation in EntityModelCellTable ...................................................................... webadmin: Implement validation in EntityModelCellTable Validation accepts a list of errors, and outlines invalid entries (ones which have non-empty errors) with a red outline, as well as adds the invalidity reason as tooltip. Change-Id: I8cddd3a6dbfe3cd9b18b631f4da13865b367d096 Bug-Url: https://bugzilla.redhat.com/1048752 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/CellTableValidation.css 2 files changed, 36 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cddd3a6dbfe3cd9b18b631f4da13865b367d096 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0