Change in ovirt-engine[master]: core: Validate FreeSpaceCriticalLowInGB conf value
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Validate FreeSpaceCriticalLowInGB conf value
......................................................................
core: Validate FreeSpaceCriticalLowInGB conf value
Added a validation that this conf value must be non-negative.
Change-Id: Id558c9bb4eeda5e9a93a933e232bc3c2914734d6
Bug-Url: https://bugzilla.redhat.com/1130030
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M packaging/etc/engine-config/engine-config.properties
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/31511
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id558c9bb4eeda5e9a93a933e232bc3c2914734d6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: Do not convert to preallocated images import to a bloc...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Do not convert to preallocated images import to a block domain
......................................................................
core: Do not convert to preallocated images import to a block domain
Images that are imported to a block domain were converted to
preallocated since block domain does not support a raw-sparse image.
Instead now we convert the volume format from raw to cow only in case
that the original volume is raw-sparse
Bug-Url: https://bugzilla.redhat.com/1116486
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Change-Id: I519cf519857928899bf4cb4b65a862696e3a8aaa
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java
1 file changed, 22 insertions(+), 19 deletions(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31521
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I519cf519857928899bf4cb4b65a862696e3a8aaa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[master]: core: Remove volume & format check on import VM command
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Remove volume & format check on import VM command
......................................................................
core: Remove volume & format check on import VM command
There's no reason to check validaty of the import VM parameters when not
using collapse snapshots since the image format will be determined by the
command itself according to the destination format
Change-Id: I06dc245db032a427d3aa36f62eaae8edcf93f657
Bug-Url: https://bugzilla.redhat.com/1129684
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31522
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06dc245db032a427d3aa36f62eaae8edcf93f657
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: remove job with migration step on engine startup
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: remove job with migration step on engine startup
......................................................................
core: remove job with migration step on engine startup
In I5973c we removed jobs that cannot be tracked after engine restart.
Proper handling for internal migration which is represented as a step
was missing, so it is added in this patch.
Change-Id: If2de0753cf2773b84a3933f8d1b22516b236ee9b
Bug-Url: https://bugzilla.redhat.com/1040952
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M packaging/dbscripts/job_sp.sql
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/31485
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2de0753cf2773b84a3933f8d1b22516b236ee9b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: do not remove execution jobs with ongoing tasks
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: do not remove execution jobs with ongoing tasks
......................................................................
core: do not remove execution jobs with ongoing tasks
In I5973c a mechanism that removes execution jobs that cannot be
tracked after engine restart was added.
A check whether there are ongoing tasks which are related to the jobs
was missing, since if there are such async tasks then the operation
can be tracked and resumed.
Change-Id: I95b1066ca6fc015fd31101e7b551b4fae1d66904
Bug-Url: https://bugzilla.redhat.com/1040952
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M packaging/dbscripts/job_sp.sql
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/31486
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95b1066ca6fc015fd31101e7b551b4fae1d66904
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin: Rephrase messages to fit label operations
by lvernia@redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Rephrase messages to fit label operations
......................................................................
webadmin: Rephrase messages to fit label operations
Since same errors are used for bonding and for labelling, rephrased
the messages to fit both.
Change-Id: I249b8eebaa1dcec35e4c50c30a8e3f440b952188
Bug-Url: https://bugzilla.redhat.com/1115109
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
3 files changed, 5 insertions(+), 11 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I249b8eebaa1dcec35e4c50c30a8e3f440b952188
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin: Don't trigger event when assigning label
by lvernia@redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Don't trigger event when assigning label
......................................................................
webadmin: Don't trigger event when assigning label
Since we're only mocking another operation to assign a label to a NIC,
the code is changed to not trigger an event (that would affect the
status panel).
Change-Id: I676ddff5293d1a7e22a911bb3b03e6da6707c493
Bug-Url: https://bugzilla.redhat.com/1115109
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31283
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I676ddff5293d1a7e22a911bb3b03e6da6707c493
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin: Reset status panel on redraw
by lvernia@redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Reset status panel on redraw
......................................................................
webadmin: Reset status panel on redraw
A recent regression caused status messages to linger on past a
redraw. This is changed so only warning messages survive
redraws.
Change-Id: Ic110c6dd4198a03c3274dfbb9fe39a8687a9861a
Bug-Url: https://bugzilla.redhat.com/1115109
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/OperationCadidateEventArgs.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/StatusLabel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/StatusPanel.java
6 files changed, 23 insertions(+), 35 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30581
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic110c6dd4198a03c3274dfbb9fe39a8687a9861a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: Reduce number of tasks in queue log messages
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Reduce number of tasks in queue log messages
......................................................................
core: Reduce number of tasks in queue log messages
When the engine server is loaded, there is a message printed to the log.
This patch increases the threshold of the number of waiting tasks from 0
to 5.
Change-Id: Ieb061ed29750184bcdd39af7d8c3fc7d0dcacabd
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/threadpool/ThreadPoolUtil.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Liran Zelkha: Verified
Michal Skrivanek: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb061ed29750184bcdd39af7d8c3fc7d0dcacabd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-hosted-engine-ha[master]: try to start the vm even if other hosts have the same score
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: try to start the vm even if other hosts have the same score
......................................................................
try to start the vm even if other hosts have the same score
if there are hosts with the same best score all should try to start the VM
otherwise we might end up in the situation when every host thinks the others
are better and no one will start the VM
Change-Id: Ib1ab72dfd8c4f07268eabe3e6fdc7a74929d9308
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093638
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/states.py
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jiří Moskovčák: Verified
--
To view, visit http://gerrit.ovirt.org/31510
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1ab72dfd8c4f07268eabe3e6fdc7a74929d9308
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months