August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: core: maxVCpus revised
by oourfali＠redhat.com 14 Aug '14

14 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: maxVCpus revised ...................................................................... core: maxVCpus revised we need to make sure must be result of cores * socket otherwise the VM will fail to load by libvirt for: c = 12 // cores maxSocket = 16 //config maxVCpu = 160 // config maxVCpu = c * (min(maxSockets, maxVCpu / c)) // 12 * 13 = 156 prior to this fix vdsm would end up with <vcpu current=12>160</vcpu> <topology cores=12 socket=13 thread=1> and 160 couldn't be fulfilled by cores * socket, 156 Change-Id: I2880c0a1523bf5c4a6b5144860efafb6df82deb4 Bug-Url: https://bugzilla.redhat.com/1126797 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 1 file changed, 12 insertions(+), 8 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31487 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2880c0a1523bf5c4a6b5144860efafb6df82deb4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Treat bonds and VLANs properly in host network usage
by lvernia＠redhat.com 14 Aug '14

14 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: engine: Treat bonds and VLANs properly in host network usage ...................................................................... engine: Treat bonds and VLANs properly in host network usage Previously VLANs and bond slaves would have been included in the search for the "bottleneck" interface in network usage, however VLAN devices' speed is meaningless and bond slaves should be ignored (as the bond itself will be evaluated). Change-Id: I71adf32f76414fe34d433177741e73529959992b Bug-Url: https://bugzilla.redhat.com/1114085 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 2 files changed, 21 insertions(+), 8 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71adf32f76414fe34d433177741e73529959992b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: ProcessOvfUpdate - skip vms/templates without ovf
by tnisan＠redhat.com 14 Aug '14

14 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: ProcessOvfUpdate - skip vms/templates without ovf ...................................................................... core: ProcessOvfUpdate - skip vms/templates without ovf When ovf hasn't been generated yet for a vm/template, avoid trying to add it's ovf to the created tar. Change-Id: I4de180c59e7e82b380bfc12f5d72f9b7c2a4f468 Bug-Url: https://bugzilla.redhat.com/1129258 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/31502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4de180c59e7e82b380bfc12f5d72f9b7c2a4f468 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Validate no duplicate network names on import
by lvernia＠redhat.com 14 Aug '14

14 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Validate no duplicate network names on import ...................................................................... webadmin: Validate no duplicate network names on import It is reasonably easy to detect whether networks with duplicate names are attempted to be imported, so this can be checked before the action is sent to the backend. Change-Id: If63d450bfc8d666ebb383e29fdfe43fcf879db78 Bug-Url: https://bugzilla.redhat.com/1048752 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/provider/ImportNetworksPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java 5 files changed, 65 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If63d450bfc8d666ebb383e29fdfe43fcf879db78 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Implement validation in EntityModelCellTable
by lvernia＠redhat.com 14 Aug '14

14 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Implement validation in EntityModelCellTable ...................................................................... webadmin: Implement validation in EntityModelCellTable Validation accepts a list of errors, and outlines invalid entries (ones which have non-empty errors) with a red outline, as well as adds the invalidity reason as tooltip. Change-Id: I8cddd3a6dbfe3cd9b18b631f4da13865b367d096 Bug-Url: https://bugzilla.redhat.com/1048752 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/CellTableValidation.css 2 files changed, 36 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cddd3a6dbfe3cd9b18b631f4da13865b367d096 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix coverity defect CID 1230277
by lvernia＠redhat.com 14 Aug '14

14 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Fix coverity defect CID 1230277 ...................................................................... webadmin: Fix coverity defect CID 1230277 Not sure why the executeCommand() overload with parameters was overridden here as no command in the dialog accepts parameters. Simplified the code a bit, which should also please Coverity. Change-Id: Ie9fb33a37dd76a27fbc6948018d1ec2a6f495239 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9fb33a37dd76a27fbc6948018d1ec2a6f495239 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ProcessOvfUpdate - skip vms/templates without ovf
by laravot＠redhat.com 14 Aug '14

14 Aug '14

Liron Aravot has submitted this change and it was merged. Change subject: core: ProcessOvfUpdate - skip vms/templates without ovf ...................................................................... core: ProcessOvfUpdate - skip vms/templates without ovf When ovf hasn't been generated yet for a vm/template, avoid trying to add it's ovf to the created tar. Change-Id: I4de180c59e7e82b380bfc12f5d72f9b7c2a4f468 Bug-Url: https://bugzilla.redhat.com/1129258 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31489 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4de180c59e7e82b380bfc12f5d72f9b7c2a4f468 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: maxVCpus revised
by tnisan＠redhat.com 14 Aug '14

14 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: maxVCpus revised ...................................................................... core: maxVCpus revised we need to make sure must be result of cores * socket otherwise the VM will fail to load by libvirt for: c = 12 // cores maxSocket = 16 //config maxVCpu = 160 // config maxVCpu = c * (min(maxSockets, maxVCpu / c)) // 12 * 13 = 156 prior to this fix vdsm would end up with <vcpu current=12>160</vcpu> <topology cores=12 socket=13 thread=1> and 160 couldn't be fulfilled by cores * socket, 156 Change-Id: I2880c0a1523bf5c4a6b5144860efafb6df82deb4 Bug-Url: https://bugzilla.redhat.com/1126797 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 1 file changed, 12 insertions(+), 8 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2880c0a1523bf5c4a6b5144860efafb6df82deb4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: missing vms link under affinity groups
by oourfali＠redhat.com 14 Aug '14

14 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: missing vms link under affinity groups ...................................................................... restapi: missing vms link under affinity groups Change-Id: Ia913bee64669db435be49463821ae68fe61978be Bug-Url: https://bugzilla.redhat.com/1128461 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> (cherry picked from commit b8feb5728bf72b50df230af5915c3c1544ccb3ab) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityGroupsResource.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Ori Liel: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/31302 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia913bee64669db435be49463821ae68fe61978be Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: maxVCpus revised
by ofrenkel＠redhat.com 14 Aug '14

14 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: maxVCpus revised ...................................................................... core: maxVCpus revised we need to make sure must be result of cores * socket otherwise the VM will fail to load by libvirt for: c = 12 // cores maxSocket = 16 //config maxVCpu = 160 // config maxVCpu = c * (min(maxSockets, maxVCpu / c)) // 12 * 13 = 156 prior to this fix vdsm would end up with <vcpu current=12>160</vcpu> <topology cores=12 socket=13 thread=1> and 160 couldn't be fulfilled by cores * socket, 156 Change-Id: I2880c0a1523bf5c4a6b5144860efafb6df82deb4 Bug-Url: https://bugzilla.redhat.com/1070890 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 1 file changed, 12 insertions(+), 8 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2880c0a1523bf5c4a6b5144860efafb6df82deb4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0