August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: engine : Use java naming conventions
by piotr.kliczewski＠gmail.com 08 Aug '14

08 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine : Use java naming conventions ...................................................................... engine : Use java naming conventions Use java naming conventions for method names instead of csharp naming convention Change-Id: I8ab86d97dbf1c94dd887c5ccc2a438a41ccd1f37 Bug-Url: https://bugzilla.redhat.com/1122639 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandAsyncTask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java 2 files changed, 60 insertions(+), 60 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ab86d97dbf1c94dd887c5ccc2a438a41ccd1f37 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Persist command at end of execution
by oourfali＠redhat.com 08 Aug '14

08 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Persist command at end of execution ...................................................................... engine: Persist command at end of execution Persist command at the end of command execution Change-Id: I1610e115fb215b9f2dcd587a41c748580f98260d Bug-Url: https://bugzilla.redhat.com/1127774 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskManagerUtil.java 2 files changed, 28 insertions(+), 12 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1610e115fb215b9f2dcd587a41c748580f98260d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Change text of "Enable optional reason" selection box
by piotr.kliczewski＠gmail.com 08 Aug '14

08 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Change text of "Enable optional reason" selection box ...................................................................... webadmin: Change text of "Enable optional reason" selection box Change the text of the checkbox to enable optional reason Change-Id: I76d514cc795271a50f91185a9be3805768876b84 Bug-Url: https://bugzilla.redhat.com/1126432 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76d514cc795271a50f91185a9be3805768876b84 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix name textbox size/alignment on Clone Vm From S...
by piotr.kliczewski＠gmail.com 08 Aug '14

08 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Fix name textbox size/alignment on Clone Vm From Snapshot ...................................................................... webadmin: Fix name textbox size/alignment on Clone Vm From Snapshot Change-Id: I2f865deab00cab1e56fd39e6b2f9a00f507c4a26 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1126215 Signed-off-by: Martin Betak <mbetak(a)redhat.com> Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 2 files changed, 26 insertions(+), 15 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Martin Betak: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31159 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f865deab00cab1e56fd39e6b2f9a00f507c4a26 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin, userportal: JUnit rule for testing UiCommon models
by vszocs＠redhat.com 07 Aug '14

07 Aug '14

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: JUnit rule for testing UiCommon models ...................................................................... webadmin,userportal: JUnit rule for testing UiCommon models This patch adds a JUnit TestRule used to set up the necessary UiCommon infrastructure in order to test individual UiCommon models. This TestRule ensures that hidden expectations of UiCommon models (represented by static method calls) are satisfied and provides a 'Mocks' interface for stubbing the infrastructure behavior, if necessary. Example - UiCommon infrastructure setup per test class: public class MyTest { @ClassRule public static UiCommonSetup setup = new UiCommonSetup(); // This is optional, but often necessary @BeforeClass public static void stubUiCommonInfra() { AsyncDataProvider adp = setup.getMocks().asyncDataProvider(); when(adp.isWindowsOsType(anyInt())).thenReturn(true); } // Actual test code to exercise model instance(s) } Example - UiCommon infrastructure setup per test method: public class MyTest { @Rule public UiCommonSetup setup = new UiCommonSetup(); // This is optional, but often necessary @Before public void stubUiCommonInfra() { AsyncDataProvider adp = setup.getMocks().asyncDataProvider(); when(adp.isWindowsOsType(anyInt())).thenReturn(true); } // Actual test code to exercise model instance(s) } Existing test code was modified to utilize UiCommonSetup rule. Change-Id: Ifca6bf6a6b77813fa90f419ccfe2ef9f2cd09561 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/junit/UiCommonSetup.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmModelBehaviorTest.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmTest.java 3 files changed, 173 insertions(+), 39 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Allon Mureinik: Verified Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifca6bf6a6b77813fa90f419ccfe2ef9f2cd09561 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: task monitoring for import glance image
by derez＠redhat.com 07 Aug '14

07 Aug '14

Daniel Erez has submitted this change and it was merged. Change subject: core: task monitoring for import glance image ...................................................................... core: task monitoring for import glance image In order for import glance image task to be monitored correctly, internal action invocation should get enclosingCommand's original context (see tasks tab screenshot [1]). [1] http://i.imgur.com/aFIA1p0.jpg Change-Id: I6780e8a18934bcd22e099dd5ea9d7e726ed60193 Bug-Url: https://bugzilla.redhat.com/1119325 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCreateTaskHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31191 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6780e8a18934bcd22e099dd5ea9d7e726ed60193 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup in ovf readers
by ofrenkel＠redhat.com 07 Aug '14

07 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: cleanup in ovf readers ...................................................................... core: cleanup in ovf readers - Changed OvfReader#readVmDevice so it will only create VmDevice from the given XML node - Introduced two new methods, one for reading managed device and another one for reading unmanaged device - Extracted the code that adds a given managed VmDevice to separate method, addManagedVmDevice (this method will be used in later patches) Change-Id: I01133cc483252683893d79d403c29aabff6701f5 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java 3 files changed, 26 insertions(+), 16 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/29842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01133cc483252683893d79d403c29aabff6701f5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup in ovf readers where hardware is read
by ofrenkel＠redhat.com 07 Aug '14

07 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: cleanup in ovf readers where hardware is read ...................................................................... core: cleanup in ovf readers where hardware is read This patch reduces the duplicated code in template's OVF reader and VM's OVF reader which is related to the reads of the hardware section. The common code is now in OvfReader, and OvfTemplateReader & OvfVmReader overrides it when needed. Change-Id: Ia44e11f4c6eca2dc47ed2ee24bd855d7888fe015 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java 3 files changed, 144 insertions(+), 213 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/29841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia44e11f4c6eca2dc47ed2ee24bd855d7888fe015 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: coverity issue fix.
by lvernia＠redhat.com 07 Aug '14

07 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: core: coverity issue fix. ...................................................................... core: coverity issue fix. Change-Id: Icf39bb13920df91e9707f861ea7c345cddd79902 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolPerDcTest.java 1 file changed, 4 insertions(+), 8 deletions(-) Approvals: Martin Mucha: Verified Allon Mureinik: Looks good to me, approved Lior Vernia: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31067 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf39bb13920df91e9707f861ea7c345cddd79902 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove job with migration step on engine startup
by ofrenkel＠redhat.com 07 Aug '14

07 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: remove job with migration step on engine startup ...................................................................... core: remove job with migration step on engine startup In I5973c we removed jobs that cannot be tracked after engine restart. Proper handling for internal migration which is represented as a step was missing, so it is added in this patch. Change-Id: If2de0753cf2773b84a3933f8d1b22516b236ee9b Bug-Url: https://bugzilla.redhat.com/1040952 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M packaging/dbscripts/job_sp.sql 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/31153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2de0753cf2773b84a3933f8d1b22516b236ee9b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0