Change in ovirt-engine[master]: webadmin: Add FencingPolicy to cluster configuration
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: webadmin: Add FencingPolicy to cluster configuration
......................................................................
webadmin: Add FencingPolicy to cluster configuration
Adds Fencing Policy tab to cluster detail.
Adds option to skip fencing of host if it's connected to at least one
storage domain to Fencing Policy tab.
Change-Id: Iaecc1662324ce3d3072c9e850fcf8026ccfab0b2
Bug-Url: https://bugzilla.redhat.com/1090799
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
9 files changed, 111 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30195
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaecc1662324ce3d3072c9e850fcf8026ccfab0b2
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: Introduce FencingPolicy
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Introduce FencingPolicy
......................................................................
core: Introduce FencingPolicy
Adds FencingPolicy as a part of cluster configuration. The 1st option
added to FencingPolicy is the ability to skip fencing of host if it's
connected to at least one storage domain
Change-Id: I7dfcd571b8329174f8d3acccf7136d0b5f83cacc
Bug-Url: https://bugzilla.redhat.com/1090799
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FencingPolicy.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/FencingPolicyHelper.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
A packaging/dbscripts/upgrade/03_06_0120_skip_fencing_when_sd_is_alive.sql
M packaging/dbscripts/vds_groups_sp.sql
7 files changed, 151 insertions(+), 7 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Verified; Looks good to me, approved
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30194
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7dfcd571b8329174f8d3acccf7136d0b5f83cacc
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[master]: core: Add config value to enable to skip fencing if SD is ac...
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Add config value to enable to skip fencing if SD is active
......................................................................
core: Add config value to enable to skip fencing if SD is active
Adds config value to enable feature to skip fencing of host when it's
connected to at least one storage domain.
Change-Id: If9f1e480a5cedb7988eba37701c3db7b3950c010
Bug-Url: https://bugzilla.redhat.com/1090799
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
4 files changed, 25 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/30193
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9f1e480a5cedb7988eba37701c3db7b3950c010
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin: Fix name textbox size/alignment on Clone Vm From S...
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: Fix name textbox size/alignment on Clone Vm From Snapshot
......................................................................
webadmin: Fix name textbox size/alignment on Clone Vm From Snapshot
Change-Id: I2f865deab00cab1e56fd39e6b2f9a00f507c4a26
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1126215
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
2 files changed, 26 insertions(+), 15 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit http://gerrit.ovirt.org/31034
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f865deab00cab1e56fd39e6b2f9a00f507c4a26
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.4]: core: Change how Affinity behaves if the assumptions are inv...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Change how Affinity behaves if the assumptions are invalid
......................................................................
core: Change how Affinity behaves if the assumptions are invalid
This fixes the situation when VMs belonging to the same hard
constraint positive affinity group are actually running on
more than one host.
It used to fail the scheduling task for any VM belonging to
the same affinity group (both new VMs and migrating ones).
This patch just passes all hosts with VM from that group
to the weighting mechanism making it possible for the
balancer or administrator to recover from this situation.
This change also makes it easier to report per host scheduling
information which we need for the following patches.
Change-Id: I506bcb6e96c622694e6bf7b8ce7a0f54a82e5713
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1122446
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
(cherry picked from commit 08971784344624f526287d510adc5cb0ef297403)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java
1 file changed, 43 insertions(+), 48 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30627
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I506bcb6e96c622694e6bf7b8ce7a0f54a82e5713
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.4]: core: calculating the maxVcpus in the limits of qemu
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: calculating the maxVcpus in the limits of qemu
......................................................................
core: calculating the maxVcpus in the limits of qemu
calulate the right maxVCpus we send to VDSM to be in the limits of qemu
max number of sockets.
this eliminates the need to send an extra argument to VDSM
maxNumberOfSockets and eliminates an API change.
Change-Id: I452d0614406ed5e9e20ac3212a5d07e7a4e4b269
Bug-Url: https://bugzilla.redhat.com/1070890
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
1 file changed, 15 insertions(+), 6 deletions(-)
Approvals:
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31128
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I452d0614406ed5e9e20ac3212a5d07e7a4e4b269
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: calculating the maxVcpus in the limits of qemu
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: calculating the maxVcpus in the limits of qemu
......................................................................
core: calculating the maxVcpus in the limits of qemu
calulate the right maxVCpus we send to VDSM to be in the limits of qemu
max number of sockets.
this eliminates the need to send an extra argument to VDSM
maxNumberOfSockets and eliminates an API change.
Change-Id: I452d0614406ed5e9e20ac3212a5d07e7a4e4b269
Bug-Url: https://bugzilla.redhat.com/1070890
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
2 files changed, 8 insertions(+), 9 deletions(-)
Approvals:
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31127
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I452d0614406ed5e9e20ac3212a5d07e7a4e4b269
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: restapi : Create user API fails in SDK & CLI fails
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: restapi : Create user API fails in SDK & CLI fails
......................................................................
restapi : Create user API fails in SDK & CLI fails
Create user fails with error HTTP 400
Request syntactically incorrect from
SDK and CLI
Change-Id: I308f5ebe3a7bcd4d980c7186fa995c704938ec93
Bug-Url: https://bugzilla.redhat.com/1122589
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/JobMapper.java
2 files changed, 10 insertions(+), 3 deletions(-)
Approvals:
Ori Liel: Looks good to me, approved
Ravi Nori: Verified
--
To view, visit http://gerrit.ovirt.org/31107
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I308f5ebe3a7bcd4d980c7186fa995c704938ec93
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: engine: search: vms.uptime is not working
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: search: vms.uptime is not working
......................................................................
engine: search: vms.uptime is not working
when searching for vms: vms.uptime > 01:00 we use the
TimeSpan.TotalSeconds which is always zero (we never pass the seconds
only days, hours and minutes) instead of using the
TimeSpan.TotalMilliseconds which hold the true total time.
Bug-Url: https://bugzilla.redhat.com/1005805
Change-Id: I322a253557c71888307a60e7ae685dd38d637543
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Shahar Havivi: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I322a253557c71888307a60e7ae685dd38d637543
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: increment the vm generation when disk is being unplugged
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: increment the vm generation when disk is being unplugged
......................................................................
core: increment the vm generation when disk is being unplugged
When a disk is being detached from a vm the vm generation should be
incremented otherwise the vm's ovf won't be updated.
Change-Id: I91bb0b562907e8d5be4daa8bed97acbf148fae34
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057108
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31009
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I91bb0b562907e8d5be4daa8bed97acbf148fae34
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months