August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine : Zombie tasks should endWithFailure
by oourfali＠redhat.com 06 Aug '14

06 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : Zombie tasks should endWithFailure ...................................................................... engine : Zombie tasks should endWithFailure Zombie tasks that are stopped and cleared should be marked so they end in failure Change-Id: I01125b507ab116440277bebdd7190a7daecbd810 Bug-Url: https://bugzilla.redhat.com/1122639 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/SPMTask.java 3 files changed, 16 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Verified Liron Aravot: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01125b507ab116440277bebdd7190a7daecbd810 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core[iSCSI multipath]: Add audit log when encounter connecti...
by tnisan＠redhat.com 06 Aug '14

06 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core[iSCSI multipath]: Add audit log when encounter connection issues ...................................................................... core[iSCSI multipath]: Add audit log when encounter connection issues Adding an audit log when updating/adding an iSCSI multipath and some of the hosts encounter some connection issues to the Storage Domain through some of the netwokrs interfaces. Also adding a log to indicate which connections were problematic. Change-Id: I8951c9b6667abb33ee6dbd0d7d8c4c98d53a3227 Bug-Url: https://bugzilla.redhat.com/1094033 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddIscsiBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseIscsiBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/EditIscsiBondCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 40 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/31109 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8951c9b6667abb33ee6dbd0d7d8c4c98d53a3227 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core[iSCSI multipath]: Add audit log when encounter connecti...
by mlipchuk＠redhat.com 05 Aug '14

05 Aug '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core[iSCSI multipath]: Add audit log when encounter connection issues ...................................................................... core[iSCSI multipath]: Add audit log when encounter connection issues Adding an audit log when updating/adding an iSCSI multipath and some of the hosts encounter some connection issues to the Storage Domain through some of the netwokrs interfaces. Also adding a log to indicate which connections were problematic. Change-Id: I8951c9b6667abb33ee6dbd0d7d8c4c98d53a3227 Bug-Url: https://bugzilla.redhat.com/1094033 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddIscsiBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseIscsiBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/EditIscsiBondCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 40 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8951c9b6667abb33ee6dbd0d7d8c4c98d53a3227 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : Transaction issues in CommandsCacheImpl updateStatus
by tnisan＠redhat.com 05 Aug '14

05 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: engine : Transaction issues in CommandsCacheImpl updateStatus ...................................................................... engine : Transaction issues in CommandsCacheImpl updateStatus When async tasks are executed the updateCommandStatus is being performed from two different transaction resulting in transcation lock. Transaction needs to be suspended before updating command status. Change-Id: I3e29d516b4cdf1509ae7838731869684004e5ee9 Bug-Url: https://bugzilla.redhat.com/1126957 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java 1 file changed, 16 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e29d516b4cdf1509ae7838731869684004e5ee9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Set read only in the CDA instead the constructor
by mlipchuk＠redhat.com 05 Aug '14

05 Aug '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Set read only in the CDA instead the constructor ...................................................................... core: Set read only in the CDA instead the constructor Setting read only property in the disk at the CDA phase in the constructor to avoid NPE when there is no disk in the DB. Change-Id: Ib70637b4fc29a95bb73aa57a6f3f0c74d4d16ca1 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified Vered Volansky: Looks good to me, but someone else must approve Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30900 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib70637b4fc29a95bb73aa57a6f3f0c74d4d16ca1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: checking only x.y.z part of release version
by tnisan＠redhat.com 05 Aug '14

05 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: checking only x.y.z part of release version ...................................................................... packaging: setup: checking only x.y.z part of release version Checking only x.y.z part of release version ignoring any suffix Change-Id: I69bb4f8c401c8e3eead8249d50f91ae9771122b0 Bug-Url: https://bugzilla.redhat.com/1118360 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 564089aea4d3ccd4922d12b1dbe160009b3ecf39) --- M packaging/setup/plugins/ovirt-engine-remove/base/core/misc.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/31077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69bb4f8c401c8e3eead8249d50f91ae9771122b0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Enable single-entry MAC range in engine-config
by tnisan＠redhat.com 05 Aug '14

05 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Enable single-entry MAC range in engine-config ...................................................................... core: Enable single-entry MAC range in engine-config This was previously wrongly blocked. It also seems like the utility class blocking this had another logical issue - in cases where multiple ranges need to be handled (I don't see that this can happen at the moment but the code seems to take that into consideration), true would be returned if at least one of the ranges were valid - instead of false being returned if at least one of the ranges were invalid. Change-Id: I0e439d1b60cc15792ad7e3ce6596f65a78c81b48 Bug-Url: https://bugzilla.redhat.com/1126181 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelperTest.java 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e439d1b60cc15792ad7e3ce6596f65a78c81b48 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: builtin: remove redundant dependency
by tnisan＠redhat.com 05 Aug '14

05 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: aaa: builtin: remove redundant dependency ...................................................................... aaa: builtin: remove redundant dependency Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: I5c8ff04052585ae1bea2ab051172dcb1645918b0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/modules/org/ovirt/engine/extensions/builtin/main/module.xml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c8ff04052585ae1bea2ab051172dcb1645918b0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: ldap-core is not required outside of builtin extensions
by tnisan＠redhat.com 05 Aug '14

05 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: aaa: ldap-core is not required outside of builtin extensions ...................................................................... aaa: ldap-core is not required outside of builtin extensions Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: I3bbf363996d098e9dfba3b1b810a1884bb8d00f9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dependencies/pom.xml A backend/manager/dependencies/src/main/modules/org/springframework/ldap/main/module.xml M backend/manager/dependencies/src/main/modules/org/springframework/main/module.xml M backend/manager/modules/builtin-extensions/src/main/modules/org/ovirt/engine/extensions/builtin/main/module.xml M backend/manager/modules/utils/pom.xml M ovirt-engine.spec.in 6 files changed, 20 insertions(+), 11 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bbf363996d098e9dfba3b1b810a1884bb8d00f9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Interface up/down events should be displayed in real...
by tnisan＠redhat.com 05 Aug '14

05 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Interface up/down events should be displayed in real time ...................................................................... engine: Interface up/down events should be displayed in real time And not only one event per 30 minutes. Change-Id: I70dc0968583e40aa712c15b6b1e5a3fa8802775b Bug-Url: https://bugzilla.redhat.com/987299 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70dc0968583e40aa712c15b6b1e5a3fa8802775b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0