August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Use validation only if Template is not blank
by ofrenkel＠redhat.com 03 Aug '14

03 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: Use validation only if Template is not blank ...................................................................... core: Use validation only if Template is not blank The validation of, same DC when creating a VM from a Template, should only be validated when creating a VMs which does not have Blank Template as their based on image. Blank Template is the default Template for every new created VM, and it is hosted on the default Data Center Change-Id: I06a0c911c50f6ff25d9dca358c6a199fa0cdbb59 Bug Url: https://bugzilla.redhat.com/1125196 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java 2 files changed, 2 insertions(+), 7 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/30888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06a0c911c50f6ff25d9dca358c6a199fa0cdbb59 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: sync: copy isAdmin from existing user
by piotr.kliczewski＠gmail.com 02 Aug '14

02 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: sync: copy isAdmin from existing user ...................................................................... aaa: sync: copy isAdmin from existing user in role based security there should be no duplication of roles, but in ovirt-engine schema we have isAdmin marker, although the role can be queried. temporary solution is to copy existing user's bit into synced user. long term solution is to remove this duplication. Topic: AAA Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: Id62a2a774c102e3e31c022456809b4b2eb2319b2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SyncUsers.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id62a2a774c102e3e31c022456809b4b2eb2319b2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: sync: cleanup: remove unused variable
by piotr.kliczewski＠gmail.com 02 Aug '14

02 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: sync: cleanup: remove unused variable ...................................................................... aaa: sync: cleanup: remove unused variable Topic: AAA Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: I03e06a92a2696607045ec9bae3875a2dad9c6396 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SyncUsers.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03e06a92a2696607045ec9bae3875a2dad9c6396 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: populate display group earlier at login
by piotr.kliczewski＠gmail.com 02 Aug '14

02 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: populate display group earlier at login ...................................................................... aaa: populate display group earlier at login we have a mess between groups that we display and group that we actually use (uuid), populate display group earlier in login. Topic: AAA Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: I01da660c44899eabc85da5c23540ca6a9e8ec433 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30941 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01da660c44899eabc85da5c23540ca6a9e8ec433 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: sync: cleanup: remove unused variable
by oourfali＠redhat.com 02 Aug '14

02 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: sync: cleanup: remove unused variable ...................................................................... aaa: sync: cleanup: remove unused variable Topic: AAA Change-Id: I03e06a92a2696607045ec9bae3875a2dad9c6396 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SyncUsers.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30939 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03e06a92a2696607045ec9bae3875a2dad9c6396 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: sync: copy isAdmin from existing user
by oourfali＠redhat.com 02 Aug '14

02 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: sync: copy isAdmin from existing user ...................................................................... aaa: sync: copy isAdmin from existing user in role based security there should be no duplication of roles, but in ovirt-engine schema we have isAdmin marker, although the role can be queried. temporary solution is to copy existing user's bit into synced user. long term solution is to remove this duplication. Topic: AAA Change-Id: Id62a2a774c102e3e31c022456809b4b2eb2319b2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SyncUsers.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id62a2a774c102e3e31c022456809b4b2eb2319b2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: populate display group earlier at login
by oourfali＠redhat.com 02 Aug '14

02 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: populate display group earlier at login ...................................................................... aaa: populate display group earlier at login we have a mess between groups that we display and group that we actually use (uuid), populate display group earlier in login. Topic: AAA Change-Id: I01da660c44899eabc85da5c23540ca6a9e8ec433 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Ravi Nori: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30930 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01da660c44899eabc85da5c23540ca6a9e8ec433 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Added ovirt-engine-extension-logger-log4j rpm jobs
by dcaroest＠redhat.com 01 Aug '14

01 Aug '14

David Caro has submitted this change and it was merged. Change subject: Added ovirt-engine-extension-logger-log4j rpm jobs ...................................................................... Added ovirt-engine-extension-logger-log4j rpm jobs Change-Id: Ice0c6c4fb89d1cab2e8a02d19baf5b611cf3ac6d Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A jobs/confs/yaml/jobs/ovirt-engine-extension-logger-log4j/ovirt-engine-extension-logger-log4j_create-rpms.yaml A jobs/confs/yaml/scms/ovirt-engine-extension-logger-log4j.yaml 2 files changed, 38 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice0c6c4fb89d1cab2e8a02d19baf5b611cf3ac6d Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Added ovirt-engine-extension-aaa-misc rpm jobs
by dcaroest＠redhat.com 01 Aug '14

01 Aug '14

David Caro has submitted this change and it was merged. Change subject: Added ovirt-engine-extension-aaa-misc rpm jobs ...................................................................... Added ovirt-engine-extension-aaa-misc rpm jobs Change-Id: I9dc594e2f800c59c61703a126797013930612856 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A jobs/confs/yaml/jobs/ovirt-engine-extension-aaa-misc/ovirt-engine-extension-aaa-misc_create-rpms.yaml A jobs/confs/yaml/scms/ovirt-engine-extension-aaa-misc.yaml 2 files changed, 38 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9dc594e2f800c59c61703a126797013930612856 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Added ovirt-engine-extension-aaa-ldap rpm jobs
by dcaroest＠redhat.com 01 Aug '14

01 Aug '14

David Caro has submitted this change and it was merged. Change subject: Added ovirt-engine-extension-aaa-ldap rpm jobs ...................................................................... Added ovirt-engine-extension-aaa-ldap rpm jobs Change-Id: I2762dbefbb7eff0c874b3751d2aae1197e741cc4 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A jobs/confs/yaml/jobs/ovirt-engine-extension-aaa-ldap/ovirt-engine-extension-aaa-ldap_create-rpms.yaml A jobs/confs/yaml/scms/ovirt-engine-extension-aaa-ldap.yaml 2 files changed, 38 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2762dbefbb7eff0c874b3751d2aae1197e741cc4 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0