Change in ovirt-engine[master]: packaging: setup: do not update RedirectServletReportsPage
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: do not update RedirectServletReportsPage
......................................................................
packaging: setup: do not update RedirectServletReportsPage
It is not the engine's job to update this, but rather Reports'.
Currently if setting up both of them at same engine-setup run, there is
a race condition. A first solution was http://gerrit.ovirt.org/29640 ,
which works when both on same host but fails if separate.
Change-Id: I203fda5fc153df608db559f6e627c7ccd4a8f24f
Bug-Url: https://bugzilla.redhat.com/1080998
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/options.py
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
Yaniv Dary: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/31001
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I203fda5fc153df608db559f6e627c7ccd4a8f24f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-reports[ovirt-engine-reports-3.4]: reports: remove war file for new db
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: remove war file for new db
......................................................................
reports: remove war file for new db
updated abort, when clean install will remove
deployed files.
Change-Id: Ief7abeee5c139ccd5877c013b4cf7f55a3521782
Bug-Url: https://bugzilla.redhat.com/1124383
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Shirly Radco: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31003
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief7abeee5c139ccd5877c013b4cf7f55a3521782
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-engine-reports-3.4
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in gerrit-admin[master]: Not moving bugs to MODIFIED when branch is master
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Not moving bugs to MODIFIED when branch is master
......................................................................
Not moving bugs to MODIFIED when branch is master
Change-Id: Ic016cd4fbb9043b82c6c0004fe6f3e57a5bb84b8
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M hooks/custom_hooks/change-merged.set_MODIFIED
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
David Caro: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30765
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic016cd4fbb9043b82c6c0004fe6f3e57a5bb84b8
Gerrit-PatchSet: 1
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: core: allow read-only for VirtIO-SCSI DirectLUN disks
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: allow read-only for VirtIO-SCSI DirectLUN disks
......................................................................
core: allow read-only for VirtIO-SCSI DirectLUN disks
In order to support read-only property for VirtIO-SCSI
DirectLUN disks, the device type for such disks should
be 'disk' (SCSI emulation) instead of 'lun' (SCSI pass-through).
I.e. representation in the domain xml sent to libvirt should
look like [1] instead of [2].
Note that this limitation (enabling pass-through for read-only
VirtIO-SCSI DirectLUN disks) could be removed once 'Support
read only VirtIO-SCSI direct LUNs in QEMU' bug [3] is resolved.
To provide full flexibility, added a new check-box for enabling
pass-through (see screenshot [4]). I.e. the user can choose between
emulated and pass-through ('disk' vs. 'lun'); read-only is
currently supported only for emulated.
[1] <disk type='block' device='disk'>...</disk>
[2] <disk type='block' device='lun'>...</disk>
[3] https://bugzilla.redhat.com/1110396
[4] screenshot: http://i.imgur.com/5mS3xSk.jpg
Change-Id: Ic317722be9ef8978b50352c12bc06ea8c906dcd0
Bug-Url: https://bugzilla.redhat.com/1118847
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
A packaging/dbscripts/upgrade/03_05_0810_update_sgio_for_readonly_disks.sql
17 files changed, 135 insertions(+), 27 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/30885
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic317722be9ef8978b50352c12bc06ea8c906dcd0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: core: fixing nfs mountpoint FQDN regex
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: fixing nfs mountpoint FQDN regex
......................................................................
core: fixing nfs mountpoint FQDN regex
*the regex now supports fqdn similar to: "foo.example.f7:/<export>"
*minor structural fixes of the regex
Change-Id: Iba3121b602d9e2e21bc120875cdfc4298f872841
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1126342
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NfsMountPointConstraint.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/NFSMountPointConstraintTest.java
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit http://gerrit.ovirt.org/30995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba3121b602d9e2e21bc120875cdfc4298f872841
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: core: audit log unknown values
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: audit log unknown values
......................................................................
core: audit log unknown values
Previous fix renamed the "unknown" to "non-interactive user"... however,
that doesn't fit the needs, as this value is being used for generic
issues, so "unknown" is a better fit.
Change-Id: Id77e70f09a05e57ee00718de1c925a9e90c48b4b
Bug-Url: https://bugzilla.redhat.com/1123828
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
(cherry picked from commit b691d7251950f26d835716254b058e8032483953)
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Oved Ourfali: Verified
--
To view, visit http://gerrit.ovirt.org/30997
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id77e70f09a05e57ee00718de1c925a9e90c48b4b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: core: compatibility version support on DC search
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: compatibility version support on DC search
......................................................................
core: compatibility version support on DC search
Added compatibility_version support on DC search TAB.
Change-Id: Ia5d9f18545483ec51c360b78cdd4de220f7d35c5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1124375
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
(cherry picked from commit c39f6bce43aafa5d3f05d539629f744bb7d2a60f)
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StoragePoolFieldAutoCompleter.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30989
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5d9f18545483ec51c360b78cdd4de220f7d35c5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: core: db squash 3.2 upgrade scripts
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: db squash 3.2 upgrade scripts
......................................................................
core: db squash 3.2 upgrade scripts
This patch squashes all 03_02_* upgrade scripts into the main database
creation scripts.
1) Creating a git branch and removing all upgrade scripts except
those with 03_02_*
2) Creating a new 3_2 database based on 1)
3) Using pg_dump to export 3_2 schema & data
4) Replacing the create_tables.sql with the schema file generated on 3)
5) Editing manually insert_data.sql and insert_predefined_roles.sql
to have all changes from data exported at step 3)
6) Creating a database engine_db_squash_3_2 on this patch branch
7) Creating a database engine_master on the master branch
8) Use pg_dump to export db from step 6) schema & data
9) Use pg_dump to export db from step 7) schema & data
10) Compare schema & data from steps 8) & 9)
Change-Id: I1ce390403c6133b66726089ff3b1e0c91ec4a2c8
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1126319
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/dbscripts/common_sp.sql
M packaging/dbscripts/create_functions.sql
M packaging/dbscripts/create_tables.sql
M packaging/dbscripts/dbfunc-common.sh
M packaging/dbscripts/insert_data.sql
M packaging/dbscripts/insert_predefined_roles.sql
D packaging/dbscripts/upgrade/03_02_0010_delete_action_version_map.sql
D packaging/dbscripts/upgrade/03_02_0020_add_libvirt_version_col.sql
D packaging/dbscripts/upgrade/03_02_0030_delete_permissions_on_vnic.sql
D packaging/dbscripts/upgrade/03_02_0040_add_permissions_on_networks.sql
D packaging/dbscripts/upgrade/03_02_0050_add_vm_guest_agent_interfaces_table.sql
D packaging/dbscripts/upgrade/03_02_0060_change_host_to_server_event_map.sql
D packaging/dbscripts/upgrade/03_02_0070_ha_vm_event_notifications.sql
D packaging/dbscripts/upgrade/03_02_0080_add_user_vm_manager_to_vm_power_users.sql
D packaging/dbscripts/upgrade/03_02_0090_cpuhost_support.sql
D packaging/dbscripts/upgrade/03_02_0100_add_cpu_thread_columns.sql
D packaging/dbscripts/upgrade/03_02_0110_add_nic_hash_column_to_vm_dynamic.sql
D packaging/dbscripts/upgrade/03_02_0120_add_index_to_vm_guest_agent_interfaces.sql
D packaging/dbscripts/upgrade/03_02_0130_add_linked_to_vm_interface.sql
D packaging/dbscripts/upgrade/03_02_0140_allow_null_network_name_in_vm_interfaces.sql
D packaging/dbscripts/upgrade/03_02_0150_add_console_cur_user_name.sql
D packaging/dbscripts/upgrade/03_02_0160_drop_guest_user_id_column.sql
D packaging/dbscripts/upgrade/03_02_0170_add_admin_internal_user_role_system.sql
D packaging/dbscripts/upgrade/03_02_0180_add_pm_proxy_preferences.sql
D packaging/dbscripts/upgrade/03_02_0190_add_vds_hardware_info.sql
D packaging/dbscripts/upgrade/03_02_0200_add_vm_generation_columns.sql
D packaging/dbscripts/upgrade/03_02_0210_add_external_events.sql
D packaging/dbscripts/upgrade/03_02_0220_add_pm_multi_agent_support.sql
D packaging/dbscripts/upgrade/03_02_0230_extend_lun_size.sql
D packaging/dbscripts/upgrade/03_02_0240_add_gluster_action_version_map.sql
D packaging/dbscripts/upgrade/03_02_0250_delete_actiongroups_uservmmanager.sql
D packaging/dbscripts/upgrade/03_02_0260_add_delete_protection.sql
D packaging/dbscripts/upgrade/03_02_0270_gluster_volume_name_unique_constraint.sql
D packaging/dbscripts/upgrade/03_02_0280_drop_licenses.sql
D packaging/dbscripts/upgrade/03_02_0290_change_vm_guest_agent_interface_mac_address_type.sql
D packaging/dbscripts/upgrade/03_02_0300_add_quota_consume_action_group_link.sql
D packaging/dbscripts/upgrade/03_02_0310_add_disabled_to_vm_static.sql
D packaging/dbscripts/upgrade/03_02_0320_fix_principal_name_in_users_for_ad_users.sql
D packaging/dbscripts/upgrade/03_02_0330_add_vds_event_notifications.sql
D packaging/dbscripts/upgrade/03_02_0340_gluster_volume_status_events.sql
D packaging/dbscripts/upgrade/03_02_0350_add_console_address.sql
D packaging/dbscripts/upgrade/03_02_0360_add_secondary_index_to_network.sql
D packaging/dbscripts/upgrade/03_02_0370_add_vds_performance_notifications.sql
D packaging/dbscripts/upgrade/03_02_0380_gluster_option_changed_event.sql
D packaging/dbscripts/upgrade/03_02_0390_align_lun_volume_group_id.sql
D packaging/dbscripts/upgrade/03_02_0400_add_login_permission_to_network_user_role.sql
D packaging/dbscripts/upgrade/03_02_0410_remove_user_session.sql
D packaging/dbscripts/upgrade/03_02_0420_materialized_views_extensions.sql
D packaging/dbscripts/upgrade/03_02_0430_dummy.sql
D packaging/dbscripts/upgrade/03_02_0440_dummy.sql
D packaging/dbscripts/upgrade/03_02_0450_dummy.sql
D packaging/dbscripts/upgrade/03_02_0460_add_async_task_task_parameters.sql
D packaging/dbscripts/upgrade/03_02_0470_lsm_version_support.sql
D packaging/dbscripts/upgrade/03_02_0480_fix_stateless_snapshot.sql
D packaging/dbscripts/upgrade/03_02_0490_add_update_column_to_statistics_tables.sql
D packaging/dbscripts/upgrade/03_02_0500_add_gluster_hooks_table.sql
R packaging/dbscripts/upgrade/03_03_0000_set_version.sql
M packaging/dbscripts/upgrade/03_03_0450_add_external_tasks_support.sql
58 files changed, 532 insertions(+), 624 deletions(-)
Approvals:
Eli Mesika: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30971
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ce390403c6133b66726089ff3b1e0c91ec4a2c8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: audit log unknown values
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: audit log unknown values
......................................................................
core: audit log unknown values
Previous fix renamed the "unknown" to "non-interactive user"... however,
that doesn't fit the needs, as this value is being used for generic
issues, so "unknown" is a better fit.
Change-Id: Id77e70f09a05e57ee00718de1c925a9e90c48b4b
Bug-Url: https://bugzilla.redhat.com/1123828
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Oved Ourfali: Verified
--
To view, visit http://gerrit.ovirt.org/30996
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id77e70f09a05e57ee00718de1c925a9e90c48b4b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-reports[master]: reports: remove war file for new db
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: remove war file for new db
......................................................................
reports: remove war file for new db
updated abort, when clean install will remove
deployed files.
Change-Id: I4dc78b70df372d83c04d9eb4a47989925f9705d7
Bug-Url: https://bugzilla.redhat.com/1072357
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Shirly Radco: Verified
Yedidyah Bar David: Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30967
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4dc78b70df372d83c04d9eb4a47989925f9705d7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
