September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: restapi: allow no parent element for Profile
by tnisan＠redhat.com 03 Sep '14

03 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: allow no parent element for Profile ...................................................................... restapi: allow no parent element for Profile Since profile is used as a ref in VM/Template or disk, we need to allow no inner elements within profile. Change-Id: I1ae61a0815fa66d907ee65eda274a76b036b9023 Bug-Url: https://bugzilla.redhat.com/1135761 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/32390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ae61a0815fa66d907ee65eda274a76b036b9023 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: select first element on changing list
by tnisan＠redhat.com 03 Sep '14

03 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: userportal,webadmin: select first element on changing list ...................................................................... userportal,webadmin: select first element on changing list - When removing all elements except one, the code that tries to auto select kicked in and would select the first element of the old list giving an illusion of duplicates for a split second. This patch fixes this by not auto selecting the only element immediately, but deferring it until the operation has completed and the list has been updated. Change-Id: Ib1ccea11f00bbf21e5fd63d4293075152d25cb1d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131881 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1ccea11f00bbf21e5fd63d4293075152d25cb1d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: explicitly set locale for unit test.
by awels＠redhat.com 03 Sep '14

03 Sep '14

Alexander Wels has submitted this change and it was merged. Change subject: engine: explicitly set locale for unit test. ...................................................................... engine: explicitly set locale for unit test. - When running the unit tests on a machine set with a locale to fr_FR it would cause the unit test to fail as the alternate locale was loaded by default instead of en_US. This patch sets the VM locale to en_US before the test run. Change-Id: I7b3d766413ba095e4543ad3f8c3e6d4af7591cf9 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/branding/src/test/java/org/ovirt/engine/core/branding/BrandingManagerTest.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Verified Greg Sheremeta: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b3d766413ba095e4543ad3f8c3e6d4af7591cf9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: allow no parent element for Profile
by gchaplik＠redhat.com 03 Sep '14

03 Sep '14

Gilad Chaplik has submitted this change and it was merged. Change subject: restapi: allow no parent element for Profile ...................................................................... restapi: allow no parent element for Profile Since profile is used as a ref in VM/Template or disk, we need to allow no inner elements within profile. Change-Id: I1ae61a0815fa66d907ee65eda274a76b036b9023 Bug-Url: https://bugzilla.redhat.com/1135761 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ae61a0815fa66d907ee65eda274a76b036b9023 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: refresh system tree when removing last leaf
by tnisan＠redhat.com 03 Sep '14

03 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: refresh system tree when removing last leaf ...................................................................... webadmin: refresh system tree when removing last leaf - When removing the last element of a list the system tree would not refresh. For instance removing the last cluster from a data center. This patch fixes that issue. Change-Id: If9e47bb6cbc5beb4da04b98c8f4b1c38c2932445 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127600 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeItemModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9e47bb6cbc5beb4da04b98c8f4b1c38c2932445 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix vNIC widget behavior
by lvernia＠redhat.com 03 Sep '14

03 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Fix vNIC widget behavior ...................................................................... webadmin: Fix vNIC widget behavior The relatively recent adjustment of the widget to allow arbitrary-length labels caused labels to always appear as enabled - this patch properly renders them again. Change-Id: I76cf6c99f5e894470396751fee533e67f04bbcb3 Bug-Url: https://bugzilla.redhat.com/1086259 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/LabelWithTextOverflow.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java 2 files changed, 17 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76cf6c99f5e894470396751fee533e67f04bbcb3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: select first element on changing list
by awels＠redhat.com 03 Sep '14

03 Sep '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: select first element on changing list ...................................................................... userportal,webadmin: select first element on changing list - When removing all elements except one, the code that tries to auto select kicked in and would select the first element of the old list giving an illusion of duplicates for a split second. This patch fixes this by not auto selecting the only element immediately, but deferring it until the operation has completed and the list has been updated. Change-Id: Ib1ccea11f00bbf21e5fd63d4293075152d25cb1d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131881 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1ccea11f00bbf21e5fd63d4293075152d25cb1d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: update vms on update of instance type
by tnisan＠redhat.com 03 Sep '14

03 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: update vms on update of instance type ...................................................................... core: update vms on update of instance type when instance type values are updated, we need to update also all the vms that are using this instance type. also, added audit log for vm update that is done internaly (by system) otherwise log will show "user <unknown>" Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1136372 Change-Id: Ic229a677bdd61a7f522548d9abf68476fbe219e7 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 26 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic229a677bdd61a7f522548d9abf68476fbe219e7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Adjust network panel height to fit arrows
by lvernia＠redhat.com 03 Sep '14

03 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Adjust network panel height to fit arrows ...................................................................... webadmin: Adjust network panel height to fit arrows The network panels were a little short compared to the arrows in the Setup Networks dialog, which caused them to go out of alignment (more noticeable as more networks are attached to the same interface). Change-Id: I55a74d41c71e7153169e077fb61813b916e5d7c6 Bug-Url: https://bugzilla.redhat.com/1120660 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/arrow_right_bottom.png M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/arrow_right_top.png 3 files changed, 2 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55a74d41c71e7153169e077fb61813b916e5d7c6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove remains of version 2.2 from FencingPolicyHelper
by oourfali＠redhat.com 03 Sep '14

03 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Remove remains of version 2.2 from FencingPolicyHelper ...................................................................... core: Remove remains of version 2.2 from FencingPolicyHelper Removes unnecessary condtions from FencingPolicyHelper class which was needed when 2.2 was containt in Version.ALL list. Change-Id: Iba815fc8a35969917360fea1eccc646e679426b8 Bug-Url: https://bugzilla.redhat.com/1127590 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/FencingPolicyHelper.java 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Martin Peřina: Verified Allon Mureinik: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32235 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba815fc8a35969917360fea1eccc646e679426b8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0