September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: rest: adding logicalName to Disk
by laravot＠redhat.com 23 Sep '14

23 Sep '14

Liron Aravot has submitted this change and it was merged. Change subject: rest: adding logicalName to Disk ...................................................................... rest: adding logicalName to Disk Change-Id: I61590c59cd0b85ebdda0f4a2c98de83983b0dccc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063597 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DiskMapperTest.java 3 files changed, 7 insertions(+), 0 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61590c59cd0b85ebdda0f4a2c98de83983b0dccc Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: db: add logical_name to vm_device
by laravot＠redhat.com 23 Sep '14

23 Sep '14

Liron Aravot has submitted this change and it was merged. Change subject: db: add logical_name to vm_device ...................................................................... db: add logical_name to vm_device This patch adds the logical_name column to the vm_device table, the intention is to store in it the device logical name as retrieved from the guest. Change-Id: If9b5a8e771a05c1fe44834adfe998cf921f6ae52 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063597 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetWatchdogQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_0390_add_logical_name_to_vm_device.sql M packaging/dbscripts/vm_device_sp.sql 16 files changed, 74 insertions(+), 20 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9b5a8e771a05c1fe44834adfe998cf921f6ae52 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: adding logicalName to Disk
by laravot＠redhat.com 23 Sep '14

23 Sep '14

Liron Aravot has submitted this change and it was merged. Change subject: core: adding logicalName to Disk ...................................................................... core: adding logicalName to Disk Change-Id: I29a51446b7821b2f1ea2840d44adaff2542bfa0f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063597 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29a51446b7821b2f1ea2840d44adaff2542bfa0f Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: GetAllDisksByVmIdQuery - set logical name
by laravot＠redhat.com 23 Sep '14

23 Sep '14

Liron Aravot has submitted this change and it was merged. Change subject: core: GetAllDisksByVmIdQuery - set logical name ...................................................................... core: GetAllDisksByVmIdQuery - set logical name Change-Id: Id35fac4c3b2d7441928fb69001498984dde03457 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063597 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQuery.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31755 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id35fac4c3b2d7441928fb69001498984dde03457 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: HotUnplug - clear device logical name
by laravot＠redhat.com 23 Sep '14

23 Sep '14

Liron Aravot has submitted this change and it was merged. Change subject: core: HotUnplug - clear device logical name ...................................................................... core: HotUnplug - clear device logical name Change-Id: Ib770de4c901ad29badfdb2544865283bbf1a6e3b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063597 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotUnPlugDiskFromVmCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib770de4c901ad29badfdb2544865283bbf1a6e3b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: VdsUpdateRunTimeInfo - update device logical name
by laravot＠redhat.com 23 Sep '14

23 Sep '14

Liron Aravot has submitted this change and it was merged. Change subject: core: VdsUpdateRunTimeInfo - update device logical name ...................................................................... core: VdsUpdateRunTimeInfo - update device logical name This patch adds support to update disks logical names as retrieved from vdsm. Change-Id: I08b13ba18ded824d7c62f72766fa7055da6ec49c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063597 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 6 files changed, 71 insertions(+), 5 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08b13ba18ded824d7c62f72766fa7055da6ec49c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: config remote engine host access
by tnisan＠redhat.com 23 Sep '14

23 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: config remote engine host access ...................................................................... packaging: setup: config remote engine host access Ask user whether to use ssh as root to access remote engine host, or provide instructions to do actions there. Allow signing a certificate by remote engine ca either way. Change-Id: I67d709ba2b0138b8d372deb0b6de5e7a9836f417 Bug-Url: https://bugzilla.redhat.com/1118328 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in M packaging/setup/ovirt_engine_setup/constants.py A packaging/setup/ovirt_engine_setup/remote_engine.py A packaging/setup/ovirt_engine_setup/remote_engine_base.py M packaging/setup/plugins/ovirt-engine-common/base/core/__init__.py A packaging/setup/plugins/ovirt-engine-common/base/remote_engine/__init__.py A packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine.py A packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine_manual_files.py A packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine_root_ssh.py 9 files changed, 1,133 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/33231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67d709ba2b0138b8d372deb0b6de5e7a9836f417 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: frontend: Fix typo with IO vs I/O
by tnisan＠redhat.com 23 Sep '14

23 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Fix typo with IO vs I/O ...................................................................... frontend: Fix typo with IO vs I/O Change-Id: I44ea6361fa379e4523e42a1693d141e27af05cef Bug-Url: https://bugzilla.redhat.com/1145197 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/33217 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44ea6361fa379e4523e42a1693d141e27af05cef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Improve wording of the memory optimization options
by gchaplik＠redhat.com 23 Sep '14

23 Sep '14

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Improve wording of the memory optimization options ...................................................................... webadmin: Improve wording of the memory optimization options Our memory optimization radios in Cluster / Optimization referenced memory page sharing. Since KSM is not the only technology we use to achieve this it was confusing our users. The text is changed to refer to physical memory overcommit. Change-Id: If1242b0b2314ff615a02baa98ecd58421c500b42 Bug-Url: https://bugzilla.redhat.com/1090576 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1242b0b2314ff615a02baa98ecd58421c500b42 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix scheduling failed message for hosted engine policy...
by gchaplik＠redhat.com 23 Sep '14

23 Sep '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix scheduling failed message for hosted engine policy units ...................................................................... core: Fix scheduling failed message for hosted engine policy units Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1142130 Change-Id: Ie91308fb0037298496cf2733f42b7e46148c653a Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/HostedEngineHAClusterFilterPolicyUnit.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 8 insertions(+), 5 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie91308fb0037298496cf2733f42b7e46148c653a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0