Change in ovirt-engine[master]: core : JBoss Servlet Exception at Page Loads :: no protocol:...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core : JBoss Servlet Exception at Page Loads :: no protocol: /ovirt/reports-interface
......................................................................
core : JBoss Servlet Exception at Page Loads :: no protocol: /ovirt/reports-interface
When reports server is not installed and the
reports base url is empty the redirect url
does not have a protocal associated with it.
So the url "/ovirt/reports-interface" throws an
exception in server logs
Change-Id: I485dff572fe8ce1ffb61d77b5032b540735f93f2
Bug-Url: https://bugzilla.redhat.com/1142748
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/ProxyServlet.java
1 file changed, 11 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Ravi Nori: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I485dff572fe8ce1ffb61d77b5032b540735f93f2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-reports[ovirt-engine-reports-3.5]: ovirt-reports: Reports should use current sessionID
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: ovirt-reports: Reports should use current sessionID
......................................................................
ovirt-reports: Reports should use current sessionID
Reports should use the new sessionID
to get session user from engine if
the sessionID has changed
Change-Id: I2e7a83b80144696639228889494a929fe4480d0a
Bug-Url: https://bugzilla.redhat.com/1116851
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
(cherry picked from commit 8a7a818c0dbb53e7c499002e662c948beeffa85c)
---
M ovirt-engine-reports/EngineAuthentication/src/main/java/org/ovirt/authentication/EngineSimplePreAuthFilter.java
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py
2 files changed, 11 insertions(+), 1 deletion(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33512
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e7a83b80144696639228889494a929fe4480d0a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-engine-reports-3.5
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 5 months
Change in ovirt-reports[ovirt-engine-reports-3.5]: packaging: setup: pep8 fixes
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: pep8 fixes
......................................................................
packaging: setup: pep8 fixes
Change-Id: I46d8bd70a852b0551caf7908e775b9cc161d8556
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit 7ca6461330a42c558700030ae8871c368babb9e5)
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/jboss.py
3 files changed, 6 insertions(+), 13 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33511
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46d8bd70a852b0551caf7908e775b9cc161d8556
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-engine-reports-3.5
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 5 months
Change in ovirt-reports[master]: ovirt-reports: Reports should use current sessionID
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: ovirt-reports: Reports should use current sessionID
......................................................................
ovirt-reports: Reports should use current sessionID
Reports should use the new sessionID
to get session user from engine if
the sessionID has changed
Change-Id: I2e7a83b80144696639228889494a929fe4480d0a
Bug-Url: https://bugzilla.redhat.com/1116851
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M ovirt-engine-reports/EngineAuthentication/src/main/java/org/ovirt/authentication/EngineSimplePreAuthFilter.java
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py
2 files changed, 11 insertions(+), 1 deletion(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33307
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e7a83b80144696639228889494a929fe4480d0a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: core: ImportVmTemplateCommand storage allocation
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: ImportVmTemplateCommand storage allocation
......................................................................
core: ImportVmTemplateCommand storage allocation
This patch is a part of a series of patches, adding storage allocation
validations to the system when they're missing, and replacing old
verification usage with unified, new, correct and tested verification.
This patch did this for ImportVmTemplateCommand, using only existing
validations. Removing old verification in this command resulted in
unused old validation and validation aids, which were also removed in
this patch.
Added tests to MoveOrCopyTemplateCommand.validateSpaceRequirements()
in MoveMoveOrCopyTemplateCommandTest.
Change-Id: I6ffc5c00905bb03c9cb3cbffa481e78c9b0ab87a
Bug-Url: https://bugzilla.redhat.com/1136721
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommandTest.java
5 files changed, 95 insertions(+), 65 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/33478
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ffc5c00905bb03c9cb3cbffa481e78c9b0ab87a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Use Collections instead of Lists
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Use Collections instead of Lists
......................................................................
core: Use Collections instead of Lists
In storage allocation-related methods, use Collections instead if lists
when possible. Further validations will be on top of this, specifically
storage allocation validation in ImportVmTemplateCommand, hence the bz
url bellow.
Change-Id: Ic89752086a68ca2f87bc58cefc33d5373c7f8eef
Bug-Url: https://bugzilla.redhat.com/1136721
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidator.java
2 files changed, 17 insertions(+), 17 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/33477
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic89752086a68ca2f87bc58cefc33d5373c7f8eef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: core: Fix raw type warning
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fix raw type warning
......................................................................
core: Fix raw type warning
Change-Id: I41ecdb4e6f08d72af876b441ee0fe8540986253a
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Yaniv Bronhaim: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33413
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41ecdb4e6f08d72af876b441ee0fe8540986253a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: mismatch in dialog header
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: mismatch in dialog header
......................................................................
webadmin: mismatch in dialog header
edit CPU QoS dialog.
Change-Id: I04da25eda198e2e4e59e51ce854dddf9a4ddaef4
Bug-Url: https://bugzilla.redhat.com/1142336
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
(cherry picked from commit 87469bf7cd814b8bfcee350880eaf59ac33c0da1)
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/EditCpuQosModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/33470
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04da25eda198e2e4e59e51ce854dddf9a4ddaef4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: core: create default disk profile for attached SD
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: create default disk profile for attached SD
......................................................................
core: create default disk profile for attached SD
Disk profile wasn't created for 'old' storage domain that
is attached to 3.5 data center.
Also added compensation support for disk profile.
Change-Id: Ic59d6f38096fb5e20fee5b9b4705b4603fdf0d4f
Bug-Url: https://bugzilla.redhat.com/1146073
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
2 files changed, 26 insertions(+), 0 deletions(-)
Approvals:
Gilad Chaplik: Verified
Roy Golan: Looks good to me, but someone else must approve
Maor Lipchuk: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33463
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic59d6f38096fb5e20fee5b9b4705b4603fdf0d4f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.4]: engine: don't allow to create VM with balloon on ppc64
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: don't allow to create VM with balloon on ppc64
......................................................................
engine: don't allow to create VM with balloon on ppc64
Change-Id: Iee077b08a825e65de2cddce85bc88573e89da4ab
Bug-Url: https://bugzilla.redhat.com/1135939
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
12 files changed, 100 insertions(+), 12 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, but someone else must approve
Jiří Moskovčák: Verified
Roy Golan: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee077b08a825e65de2cddce85bc88573e89da4ab
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months