September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Small logic fix when reassigning roles
by masayag＠redhat.com 15 Sep '14

15 Sep '14

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Small logic fix when reassigning roles ...................................................................... webadmin: Small logic fix when reassigning roles Previous fix implicitly relied on the state of the sent entity too much, now comparison is made with the entity as stored in the DB. Change-Id: I99bceea9f35f2356897a21c6e6e7f2f051f3f37d Bug-Url: https://bugzilla.redhat.com/1135785 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99bceea9f35f2356897a21c6e6e7f2f051f3f37d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Add AddVmTemplateCommand to command executer framework
by tnisan＠redhat.com 15 Sep '14

15 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Add AddVmTemplateCommand to command executer framework ...................................................................... engine: Add AddVmTemplateCommand to command executer framework By adding AddVmTemplateCommand we can determine whether we need to delete the template if the command failed. Bug-Url: https://bugzilla.redhat.com/1105211 Change-Id: Ib47982264f535dcf38cd4f9319f842d75ebccd5d Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Shahar Havivi: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib47982264f535dcf38cd4f9319f842d75ebccd5d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: make AuthenticationProfileRepository observable
by yzaslavs＠redhat.com 15 Sep '14

15 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: make AuthenticationProfileRepository observable ...................................................................... aaa: make AuthenticationProfileRepository observable cleanup negotiation filter to update dynamically, as it is not enough to do lazy, per early requests. modify observer usage to use local inline object instead of effecting entire class. Topic: AAA Change-Id: I04db3fcb60a2199d5a4af042b589a30023e29ff5 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java 2 files changed, 47 insertions(+), 51 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04db3fcb60a2199d5a4af042b589a30023e29ff5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: add authn negotiation priority
by yzaslavs＠redhat.com 15 Sep '14

15 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: add authn negotiation priority ...................................................................... aaa: add authn negotiation priority Topic: AAA Change-Id: I1bb8803e44fbc75ff91c0b6791491ced58eff6d5 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfile.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authn.java 3 files changed, 27 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bb8803e44fbc75ff91c0b6791491ced58eff6d5 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: extapi: move authn config keys into api
by yzaslavs＠redhat.com 15 Sep '14

15 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: extapi: move authn config keys into api ...................................................................... extapi: move authn config keys into api sync with Base. Topic: AAA Change-Id: I5f9104dae94d5992690efbb89b0867ba77926384 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfile.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authn.java 3 files changed, 18 insertions(+), 8 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f9104dae94d5992690efbb89b0867ba77926384 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: iSCSI login button arrow not properly aligned
by tjelinek＠redhat.com 15 Sep '14

15 Sep '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: iSCSI login button arrow not properly aligned ...................................................................... webadmin: iSCSI login button arrow not properly aligned Login button of the iSCSI storage domain dialog was misplaced after introducing the http://gerrit.ovirt.org/#/c/32521/ This patch fixes it. Change-Id: I609b4cb800e75a76ffacfe9a515bf495ccf281c2 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I609b4cb800e75a76ffacfe9a515bf495ccf281c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: filters: cleanup: use profile object directly
by yzaslavs＠redhat.com 15 Sep '14

15 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: filters: cleanup: use profile object directly ...................................................................... aaa: filters: cleanup: use profile object directly Change-Id: I2ba90ceadbcca5e63c85bf6b6f913dd0f5a147b0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java 1 file changed, 6 insertions(+), 9 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ba90ceadbcca5e63c85bf6b6f913dd0f5a147b0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: cleanup: remove unused function
by yzaslavs＠redhat.com 14 Sep '14

14 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: cleanup: remove unused function ...................................................................... aaa: cleanup: remove unused function Topic: AAA Change-Id: I03ce61dbddc74704e641c43b0aa037c1b49c5319 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03ce61dbddc74704e641c43b0aa037c1b49c5319 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: ImportVmCommand storage allocation checks
by tnisan＠redhat.com 14 Sep '14

14 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: ImportVmCommand storage allocation checks ...................................................................... core: ImportVmCommand storage allocation checks This patch is a part of a series of patches, adding storage allocation validations to the system when they're missing, and replacing old verification usage with unified, new, correct and tested verification. This patch did this for ImportVmCommand, while added new space allocation validation to storage domain validators regarding snapshoted disks to be cloned with the spnapshots. Tests were amended accordingly. Change-Id: Ifbb1d985f9afa476452d1d2b78be1fd18c128c8f Bug-Url: https://bugzilla.redhat.com/1053746 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorFreeSpaceTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageBase.java 9 files changed, 322 insertions(+), 62 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/32898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbb1d985f9afa476452d1d2b78be1fd18c128c8f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add AddVmTemplateCommand to command executer framework
by shavivi＠redhat.com 14 Sep '14

14 Sep '14

Shahar Havivi has submitted this change and it was merged. Change subject: engine: Add AddVmTemplateCommand to command executer framework ...................................................................... engine: Add AddVmTemplateCommand to command executer framework By adding AddVmTemplateCommand we can determine whether we need to delete the template if the command failed. Bug-Url: https://bugzilla.redhat.com/1105211 Change-Id: Ib47982264f535dcf38cd4f9319f842d75ebccd5d Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Shahar Havivi: Verified Omer Frenkel: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib47982264f535dcf38cd4f9319f842d75ebccd5d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0