September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: changing error severity of illegal search
by oourfali＠redhat.com 12 Sep '14

12 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: changing error severity of illegal search ...................................................................... core: changing error severity of illegal search WARN message logged versus DEBUG or INFO message with rhevm-shell provided bogus search This patch changes the severity of illegal searches done by the user from WARN to INFO Change-Id: Ic6abcdc24e1538937cc317c2fc13a913cb542786 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133553 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6abcdc24e1538937cc317c2fc13a913cb542786 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Add HttpOnly flag to session cookie
by piotr.kliczewski＠gmail.com 12 Sep '14

12 Sep '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Add HttpOnly flag to session cookie ...................................................................... restapi: Add HttpOnly flag to session cookie The CSRF protection mechanism has been implemented in a way that doesn't require reading the value of this cookie, so the flag can be enabled now. Change-Id: Id0a315fda675ec2c606589f9028d7284d68496d5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0a315fda675ec2c606589f9028d7284d68496d5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>

1 0

Change in ovirt-engine[master]: restapi: Add HttpOnly flag to session cookie
by juan.hernandez＠redhat.com 12 Sep '14

12 Sep '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add HttpOnly flag to session cookie ...................................................................... restapi: Add HttpOnly flag to session cookie The CSRF protection mechanism has been implemented in a way that doesn't require reading the value of this cookie, so the flag can be enabled now. Change-Id: Id0a315fda675ec2c606589f9028d7284d68496d5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0a315fda675ec2c606589f9028d7284d68496d5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: use Authn.Capabilities.AUTHENTICATE_CREDENTIALS correctly
by piotr.kliczewski＠gmail.com 12 Sep '14

12 Sep '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: use Authn.Capabilities.AUTHENTICATE_CREDENTIALS correctly ...................................................................... aaa: use Authn.Capabilities.AUTHENTICATE_CREDENTIALS correctly Topic: AAA Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: I8ed1d4523ddf2bcefb3f1b1be868e4caf6c04ad7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthn.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthn.java 3 files changed, 30 insertions(+), 11 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32804 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ed1d4523ddf2bcefb3f1b1be868e4caf6c04ad7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: frontend: Fix validation of UnitVmModel
by piotr.kliczewski＠gmail.com 12 Sep '14

12 Sep '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: frontend: Fix validation of UnitVmModel ...................................................................... frontend: Fix validation of UnitVmModel Individual entity models were validated but the validate() method always returned true since the validity of individual tabs was not taken into account. This resulted in submitting invalid edits and subsequent backend validation errors. Change-Id: Iabba7f93a0541292a1a4c82b675ab0faf141b9b2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128444 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 18 insertions(+), 13 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/32694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabba7f93a0541292a1a4c82b675ab0faf141b9b2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: packaging: updated dependencies
by sbonazzo＠redhat.com 12 Sep '14

12 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: updated dependencies ...................................................................... packaging: updated dependencies updated dependencies with packages released in 3.5.0 RC2. Change-Id: I10b888f6a307256a4227cb013610064037d732f8 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 11 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10b888f6a307256a4227cb013610064037d732f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: packaging: updated dependencies on vdsm
by msivak＠redhat.com 12 Sep '14

12 Sep '14

Martin Sivák has submitted this change and it was merged. Change subject: packaging: updated dependencies on vdsm ...................................................................... packaging: updated dependencies on vdsm Require latest vdsm in order to ensure it's updated. Change-Id: I5c5de8ab42a6640da25e1ddbfc3c0020340cd306 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 8 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified Martin Sivák: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c5de8ab42a6640da25e1ddbfc3c0020340cd306 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[master]: cli: Generate empty list for empty option
by juan.hernandez＠redhat.com 12 Sep '14

12 Sep '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Generate empty list for empty option ...................................................................... cli: Generate empty list for empty option Currently when a command receives an option that represents a list of values but without any value the CLI automatically adds the string "None" as the only value. This can cause issues. What the CLI should generate in this cases is an empty list. Change-Id: Ic95dadcbfd7f77b49524df0ffd05dcdcf7af8f1e Bug-Url: https://bugzilla.redhat.com/1085463 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic95dadcbfd7f77b49524df0ffd05dcdcf7af8f1e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: db: separating seq creation from table creation.
by emesika＠redhat.com 12 Sep '14

12 Sep '14

Eli Mesika has submitted this change and it was merged. Change subject: db: separating seq creation from table creation. ...................................................................... db: separating seq creation from table creation. Separating sequence creation from table creation script. this will have in future version squashing and review of patches. Change-Id: Icfec6b09ea1e7a045f3e3d491c1a10e08a3c6188 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- A packaging/dbscripts/create_sequences.sql M packaging/dbscripts/create_tables.sql M packaging/dbscripts/dbfunc-common.sh 3 files changed, 8 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfec6b09ea1e7a045f3e3d491c1a10e08a3c6188 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: Update mom version to 0.4.2
by alitke＠redhat.com 11 Sep '14

11 Sep '14

Adam Litke has submitted this change and it was merged. Change subject: Update mom version to 0.4.2 ...................................................................... Update mom version to 0.4.2 Change-Id: Ifabf01bfc9d5b4d7b9c5109860f6604189b2d695 Signed-off-by: Adam Litke <alitke(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/32834 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Adam Litke: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32834 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifabf01bfc9d5b4d7b9c5109860f6604189b2d695 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0