September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: engine_page: use augeas instead of Management()
by dougsland＠redhat.com 11 Sep '14

11 Sep '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: use augeas instead of Management() ...................................................................... engine_page: use augeas instead of Management() To manage values in /etc/default/ovirt we use Management() which oVirt Node provides. However, for such task, we should manage the values to be added into /etc/default/ovirt directly in the Plugin VDSM to avoid any possible issue involving other layer. Change-Id: I063836cd373bcf81a4b3f07848d6e0240d4ef959 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1088875 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I063836cd373bcf81a4b3f07848d6e0240d4ef959 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: use augeas instead of Management()
by fabiand＠redhat.com 11 Sep '14

11 Sep '14

Fabian Deutsch has submitted this change and it was merged. Change subject: engine_page: use augeas instead of Management() ...................................................................... engine_page: use augeas instead of Management() To manage values in /etc/default/ovirt we use Management() which oVirt Node provides. However, for such task, we should manage the values to be added into /etc/default/ovirt directly in the Plugin VDSM to avoid any possible issue involving other layer. Change-Id: I063836cd373bcf81a4b3f07848d6e0240d4ef959 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1088875 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved Douglas Schilling Landgraf: Verified -- To view, visit http://gerrit.ovirt.org/32148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I063836cd373bcf81a4b3f07848d6e0240d4ef959 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: do not display non password authn profiles within login
by piotr.kliczewski＠gmail.com 11 Sep '14

11 Sep '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: do not display non password authn profiles within login ...................................................................... aaa: do not display non password authn profiles within login they are useless in this location. Topic: AAA Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: I74df82dcead1b88124b44cbec2ea43ef85768fce Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAAAProfileListQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/ProfileEntry.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java 6 files changed, 22 insertions(+), 14 deletions(-) Approvals: Alon Bar-Lev: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74df82dcead1b88124b44cbec2ea43ef85768fce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: Fix group population for legacy provider
by piotr.kliczewski＠gmail.com 11 Sep '14

11 Sep '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: Fix group population for legacy provider ...................................................................... aaa: Fix group population for legacy provider Legacy provider did not populate groups for added users in a correct way. Change-Id: Id1066170758ecddd296b6f253c5bd386cea22008 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapBrokerCommandBase.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapSearchByQueryParameters.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapSearchUserByQueryCommand.java 4 files changed, 29 insertions(+), 11 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32812 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1066170758ecddd296b6f253c5bd386cea22008 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: ovirt-engine_upgrade_stable_to_3.4: more cleanups
by eedri＠redhat.com 11 Sep '14

11 Sep '14

Eyal Edri has submitted this change and it was merged. Change subject: ovirt-engine_upgrade_stable_to_3.4: more cleanups ...................................................................... ovirt-engine_upgrade_stable_to_3.4: more cleanups Added cleanup of /etc/ovirt-engine and /etc/ovirt-engine-setup.conf.d. Change-Id: I80678687af42de43ee45505c2817a7d2c57faa64 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/ovirt-engine_upgrade_stable_to_3.4/upgrade.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified Eyal Edri: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80678687af42de43ee45505c2817a7d2c57faa64 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine:slave's mac in Broker, to lower case
by masayag＠redhat.com 11 Sep '14

11 Sep '14

Moti Asayag has submitted this change and it was merged. Change subject: engine:slave's mac in Broker, to lower case ...................................................................... engine:slave's mac in Broker, to lower case slave's mac in older vdsm versions, is in upper case, resulting slave's mac is saved and repressent in upper case Change-Id: Ibfebc2aea4bc3605253bfb072fc4ad19c0fd2270 Bug-Url: https://bugzilla.redhat.com/1132422 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Eliraz Levi: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfebc2aea4bc3605253bfb072fc4ad19c0fd2270 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Added Exec. Msg. for AddPosixFsStorageDomain
by tnisan＠redhat.com 11 Sep '14

11 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Added Exec. Msg. for AddPosixFsStorageDomain ...................................................................... core: Added Exec. Msg. for AddPosixFsStorageDomain Added an execution message for AddPosixFsStorageDomain. Change-Id: I1b2bdc2199988785dd37b8b9dcf361fbab387496 Bug-Url: https://bugzilla.redhat.com/1139169 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> (cherry picked from commit 4c6e7b684c91e25bdcf877ec74c0d44a51bfb622) --- M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b2bdc2199988785dd37b8b9dcf361fbab387496 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: chnaged the translated messages to match the new ones
by tnisan＠redhat.com 11 Sep '14

11 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: chnaged the translated messages to match the new ones ...................................................................... webadmin: chnaged the translated messages to match the new ones ApplicationMessages.vlanNetwork used to be: "{0} (VLAN {1})" while it has been changed to "(VLAN {0})" But this change has not been reflected in the translated propery files, e.g. ApplicationMessages_de_DE.properties ApplicationMessages_es_ES.properties ApplicationMessages_fr_FR.properties ApplicationMessages_ja_JP.properties ApplicationMessages_ko_KR.properties ApplicationMessages_pt_BR.properties ApplicationMessages_zh_CN.properties which causes the compilation to fail if you enable the language permutations. This patch corrects this property files. Change-Id: Id62a4b4b5339e78c8cd047917189fd07beaeab5c Bug-Url: https://bugzilla.redhat.com/1140550 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_de_DE.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_es_ES.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_fr_FR.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_ja_JP.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_ko_KR.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_pt_BR.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_zh_CN.properties 7 files changed, 7 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Verified Alona Kaplan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id62a4b4b5339e78c8cd047917189fd07beaeab5c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Revert "engine: Forbid Bootable and Shareable Disks"
by amureini＠redhat.com 11 Sep '14

11 Sep '14

Allon Mureinik has submitted this change and it was merged. Change subject: Revert "engine: Forbid Bootable and Shareable Disks" ...................................................................... Revert "engine: Forbid Bootable and Shareable Disks" This reverts commit 673e7b876b13650f5b5cec794486bfef1b0fd565. Following the decision to allow disks to be both bootable and shareable at the same time, this patch is no longer relevant. (See the discussion at: https://bugzilla.redhat.com/1084103) Change-Id: I6d8357e51e3c4364fd44754537150eb21d0acba4 Relates-To: https://bugzilla.redhat.com/1084103 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/upgrade/03_06_0240_update_disk_bootable_shareable.sql 14 files changed, 26 insertions(+), 152 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d8357e51e3c4364fd44754537150eb21d0acba4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Added Exec. Msg. for AddPosixFsStorageDomain
by amureini＠redhat.com 11 Sep '14

11 Sep '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Added Exec. Msg. for AddPosixFsStorageDomain ...................................................................... core: Added Exec. Msg. for AddPosixFsStorageDomain Added an execution message for AddPosixFsStorageDomain. Change-Id: I1b2bdc2199988785dd37b8b9dcf361fbab387496 Bug-Url: https://bugzilla.redhat.com/1139169 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/32771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b2bdc2199988785dd37b8b9dcf361fbab387496 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0