September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: fail when trying to remove labeled VLAN network.
by tnisan＠redhat.com 11 Sep '14

11 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: fail when trying to remove labeled VLAN network. ...................................................................... core: fail when trying to remove labeled VLAN network. Vlan related nics cannot have labels, but when I have VLAN enabled non vm network added to nic via label, then this nic will have associated label, and vlan related nic will have associated network. So I have to remove Vlan related nic when updating via setupnetworks, to remove network. So I have to check base interface for label presence when removing network with vlan enabled via removing of vlan related nic. Also it seemed to me like a bug, that if isVlan(nic) is true, but it's base interface nic is present in setupnetworks request(ie. vlan related nic was deleted but base interface was not), vlan related nic is checked for label presence, although it's base resource should have been validated. Change-Id: I132f4ae124e45144beee21f81f69e55ed25cd540 Bug-Url: https://bugzilla.redhat.com/1134380 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java 1 file changed, 14 insertions(+), 12 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I132f4ae124e45144beee21f81f69e55ed25cd540 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: chnaged the translated messages to match the new ones
by alkaplan＠redhat.com 11 Sep '14

11 Sep '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: chnaged the translated messages to match the new ones ...................................................................... webadmin: chnaged the translated messages to match the new ones ApplicationMessages.vlanNetwork used to be: "{0} (VLAN {1})" while it has been changed to "(VLAN {0})" But this change has not been reflected in the translated propery files, e.g. ApplicationMessages_de_DE.properties ApplicationMessages_es_ES.properties ApplicationMessages_fr_FR.properties ApplicationMessages_ja_JP.properties ApplicationMessages_ko_KR.properties ApplicationMessages_pt_BR.properties ApplicationMessages_zh_CN.properties which causes the compilation to fail if you enable the language permutations. This patch corrects this property files. Change-Id: Id62a4b4b5339e78c8cd047917189fd07beaeab5c Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_de_DE.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_es_ES.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_fr_FR.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_ja_JP.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_ko_KR.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_pt_BR.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_zh_CN.properties 7 files changed, 7 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id62a4b4b5339e78c8cd047917189fd07beaeab5c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: need to consider Vlan when getting name from nic.
by tnisan＠redhat.com 11 Sep '14

11 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: need to consider Vlan when getting name from nic. ...................................................................... core: need to consider Vlan when getting name from nic. Change-Id: Ie504a99aa31c279fc9b3304ca6a860c5d0cf7943 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1134380 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie504a99aa31c279fc9b3304ca6a860c5d0cf7943 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: Fix group name issues for legacy provider
by tnisan＠redhat.com 11 Sep '14

11 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: aaa: Fix group name issues for legacy provider ...................................................................... aaa: Fix group name issues for legacy provider Chagning format from - authz/a/b/c/d to - a/b/c/d@authz to conform to the users format. Removed specific code at rest-api that handled old format Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: I8c1feed08e33156c794b230fa04f33f2ebd82240 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapBrokerUtils.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/aaa/AuthzUtils.java 7 files changed, 125 insertions(+), 58 deletions(-) Approvals: Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32779 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c1feed08e33156c794b230fa04f33f2ebd82240 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: check storage domains status on master deactivation
by tnisan＠redhat.com 11 Sep '14

11 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: check storage domains status on master deactivation ...................................................................... core: check storage domains status on master deactivation When deactivating the master storage domain we should make sure that the other domains are not in transition. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128824 Change-Id: I28228f2ad3ce555aafc9ea03d44aebeb12bbf0cf Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Federico Simoncelli: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28228f2ad3ce555aafc9ea03d44aebeb12bbf0cf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Fix group population for legacy provider
by yzaslavs＠redhat.com 11 Sep '14

11 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Fix group population for legacy provider ...................................................................... aaa: Fix group population for legacy provider Legacy provider did not populate groups for added users in a correct way. Change-Id: Id1066170758ecddd296b6f253c5bd386cea22008 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapBrokerCommandBase.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapSearchByQueryParameters.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapSearchUserByQueryCommand.java 4 files changed, 29 insertions(+), 11 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1066170758ecddd296b6f253c5bd386cea22008 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: use Authn.Capabilities.AUTHENTICATE_CREDENTIALS correctly
by yzaslavs＠redhat.com 11 Sep '14

11 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: use Authn.Capabilities.AUTHENTICATE_CREDENTIALS correctly ...................................................................... aaa: use Authn.Capabilities.AUTHENTICATE_CREDENTIALS correctly Topic: AAA Change-Id: I8ed1d4523ddf2bcefb3f1b1be868e4caf6c04ad7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthn.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthn.java 3 files changed, 30 insertions(+), 11 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ed1d4523ddf2bcefb3f1b1be868e4caf6c04ad7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: repoclosure: epel7 is not in beta anymore
by eedri＠redhat.com 11 Sep '14

11 Sep '14

Eyal Edri has submitted this change and it was merged. Change subject: repoclosure: epel7 is not in beta anymore ...................................................................... repoclosure: epel7 is not in beta anymore epel7 is not in beta anymore, updated the url of the repo. Change-Id: Ic2af0ee28e92949a8b05b347d61976fecc90d141 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/packaging/repo_closure_check.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified Eyal Edri: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2af0ee28e92949a8b05b347d61976fecc90d141 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: hooks: Add 02-sanlock-check into on-boot
by dougsland＠redhat.com 11 Sep '14

11 Sep '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: hooks: Add 02-sanlock-check into on-boot ...................................................................... hooks: Add 02-sanlock-check into on-boot Add 02-sanlock-check into on-boot to create sanlock user/group ifmissing during upgrade. Change-Id: I63101a8811978afe33b4152335e62bf5c3b54e00 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127122 Signed-off-by: hadong <hadong(a)redhat.com> --- M hooks/Makefile.am A hooks/on-boot/02-sanlock-check M ovirt-node-plugin-vdsm.spec.in 3 files changed, 29 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63101a8811978afe33b4152335e62bf5c3b54e00 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: hadong <hadong0720(a)gmail.com>

1 0

Change in ovirt-engine[master]: core: refactoring in CommandsFactory
by yzaslavs＠redhat.com 11 Sep '14

11 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: refactoring in CommandsFactory ...................................................................... core: refactoring in CommandsFactory Extract the code that instantiate the command to separate method Change-Id: Ib1d15d69afad9cefad95d0d266a495e3d95cd6e4 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/Injector.java 2 files changed, 17 insertions(+), 15 deletions(-) Approvals: Arik Hadas: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1d15d69afad9cefad95d0d266a495e3d95cd6e4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0