September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: extmgr: raise config exception if requested extension is null
by yzaslavs＠redhat.com 09 Sep '14

09 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: extmgr: raise config exception if requested extension is null ...................................................................... extmgr: raise config exception if requested extension is null Topic: AAA Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1139671 Change-Id: Ie32e829d4a8c0790b2769169e0c8c793d4d71ba3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie32e829d4a8c0790b2769169e0c8c793d4d71ba3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[ovirt-live-3.4]: build: oVirt Live 3.4.4 RC
by sbonazzo＠redhat.com 09 Sep '14

09 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: oVirt Live 3.4.4 RC ...................................................................... build: oVirt Live 3.4.4 RC Change-Id: I123ad37b6353fdc85862804b08f89b58238f66e7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile M centos/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I123ad37b6353fdc85862804b08f89b58238f66e7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: VM dialog- nic name and vnic profile drop down sho...
by tnisan＠redhat.com 09 Sep '14

09 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: VM dialog- nic name and vnic profile drop down should be aligned ...................................................................... webadmin: VM dialog- nic name and vnic profile drop down should be aligned Change-Id: I327c85d42b61b83ce0bf5cdc203a97f34cb719f8 Bug-Url: https://bugzilla.redhat.com/1131436 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> (cherry picked from commit 2dae71732abe3c578f71a39b58d070c8cd90e7a8) --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I327c85d42b61b83ce0bf5cdc203a97f34cb719f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: wrong nesting: not detecting label & VmNetwork changes
by tnisan＠redhat.com 09 Sep '14

09 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: wrong nesting: not detecting label & VmNetwork changes ...................................................................... core: wrong nesting: not detecting label & VmNetwork changes this equality checks are badly nested causing the last two lines does not do what intended. Instead: oldNetwork.isVmNetwork() is compared to newNetwork.isVmNetwork()) && Objects.equals(oldNetwork.getLabel(), newNetwork.getLabel()); which wasn't probably wanted. Change-Id: I50c748071e09fb062ce08aedd1af71db6c4e280d Bug-Url: https://bugzilla.redhat.com/1139590 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50c748071e09fb062ce08aedd1af71db6c4e280d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fix CVE-2014-3573
by tnisan＠redhat.com 09 Sep '14

09 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: fix CVE-2014-3573 ...................................................................... core: fix CVE-2014-3573 single place in which DocumentBuilderFactory is constructed to apply security settings. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1139000 Change-Id: Icf27db1ec13b6a16d9b7c77fd9710e8e6f6ec3c9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java M backend/manager/modules/restapi/interface/definition/src/main/modules/org/ovirt/engine/api/restapi-definition/main/module.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/XmlUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlDocument.java A backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/xml/SecureDocumentBuilderFactory.java 7 files changed, 36 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf27db1ec13b6a16d9b7c77fd9710e8e6f6ec3c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: utils: ovf: move compat xml to ovf as it is the only consumer
by tnisan＠redhat.com 09 Sep '14

09 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: utils: ovf: move compat xml to ovf as it is the only consumer ...................................................................... utils: ovf: move compat xml to ovf as it is the only consumer Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1139000 Change-Id: Iae2b6e697f82702cfb211c670a079f2da14994de Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/compat/exclude-filters.xml M backend/manager/modules/utils/exclude-filters.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfParser.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlAttribute.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlAttributeCollection.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlDocument.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlNamespaceManager.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlNode.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlNodeList.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlTextWriter.java 16 files changed, 53 insertions(+), 53 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32610 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae2b6e697f82702cfb211c670a079f2da14994de Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: host-deploy: installer-messages: remove usage of compat
by tnisan＠redhat.com 09 Sep '14

09 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: host-deploy: installer-messages: remove usage of compat ...................................................................... host-deploy: installer-messages: remove usage of compat Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1139000 Change-Id: Iaf8e15885168f3ebebfede459affa7e518a3624e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java 1 file changed, 19 insertions(+), 17 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf8e15885168f3ebebfede459affa7e518a3624e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: VM dialog- nic name and vnic profile drop down sho...
by alkaplan＠redhat.com 09 Sep '14

09 Sep '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: VM dialog- nic name and vnic profile drop down should be aligned ...................................................................... webadmin: VM dialog- nic name and vnic profile drop down should be aligned Change-Id: I327c85d42b61b83ce0bf5cdc203a97f34cb719f8 Bug-Url: https://bugzilla.redhat.com/1131436 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I327c85d42b61b83ce0bf5cdc203a97f34cb719f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Re-assign display/migration roles to mgmt network
by tnisan＠redhat.com 09 Sep '14

09 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Re-assign display/migration roles to mgmt network ...................................................................... engine: Re-assign display/migration roles to mgmt network While we recently started marking the management network explicitly as display and migration by default, we did not take care of the scenario where the roles are assigned to another network which is then removed - in which case we're left with no explicit display/migration network, and only fall back to the management network implicitly. Now when a network holding the role is removed, it is re-assigned to the management network. Change-Id: I1fe94bdfda672ddf51b075415a02a80ff634a90a Bug-Url: https://bugzilla.redhat.com/1135785 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworksFromClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java 4 files changed, 60 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fe94bdfda672ddf51b075415a02a80ff634a90a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Finalizing step typo
by tnisan＠redhat.com 09 Sep '14

09 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Finalizing step typo ...................................................................... core: Finalizing step typo Removed the full stop from "Finalizing." in order to match "Validating" and "Executing" steps. Change-Id: Icf9d4372f99e65d5b113aabcc87777beae85bed2 Bug-Url: https://bugzilla.redhat.com/1139311 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> (cherry picked from commit e77903e1ef18b9b12391e8d3332dfd6c509efb1c) --- M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/32690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf9d4372f99e65d5b113aabcc87777beae85bed2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0