September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Re-assign roles when network is detached
by lvernia＠redhat.com 09 Sep '14

09 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Re-assign roles when network is detached ...................................................................... webadmin: Re-assign roles when network is detached When a network is detached from a cluster, we make sure to visibly re-assign those roles to the management network. Change-Id: I72a9b4a46a32014b31f8981fbe0e8750352dd80e Bug-Url: https://bugzilla.redhat.com/1135785 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java 2 files changed, 54 insertions(+), 16 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72a9b4a46a32014b31f8981fbe0e8750352dd80e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: fix CVE-2014-3573
by oourfali＠redhat.com 09 Sep '14

09 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix CVE-2014-3573 ...................................................................... core: fix CVE-2014-3573 single place in which DocumentBuilderFactory is constructed to apply security settings. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1139000 Change-Id: Icf27db1ec13b6a16d9b7c77fd9710e8e6f6ec3c9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SecureDocumentBuilderFactory.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/XmlUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlDocument.java 4 files changed, 26 insertions(+), 4 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf27db1ec13b6a16d9b7c77fd9710e8e6f6ec3c9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: utils: ovf: move compat xml to ovf as it is the only consumer
by oourfali＠redhat.com 09 Sep '14

09 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: utils: ovf: move compat xml to ovf as it is the only consumer ...................................................................... utils: ovf: move compat xml to ovf as it is the only consumer Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1139000 Change-Id: Iae2b6e697f82702cfb211c670a079f2da14994de Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/compat/exclude-filters.xml M backend/manager/modules/utils/exclude-filters.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfParser.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlAttribute.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlAttributeCollection.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlDocument.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlNamespaceManager.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlNode.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlNodeList.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlTextWriter.java 15 files changed, 51 insertions(+), 50 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae2b6e697f82702cfb211c670a079f2da14994de Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: wrong nesting: not detecting label & VmNetwork changes
by lvernia＠redhat.com 09 Sep '14

09 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: core: wrong nesting: not detecting label & VmNetwork changes ...................................................................... core: wrong nesting: not detecting label & VmNetwork changes this equality checks are badly nested causing the last two lines does not do what intended. Instead oldNetwork.isVmNetwork() is compared to newNetwork.isVmNetwork()) && Objects.equals(oldNetwork.getLabel(), newNetwork.getLabel()); which wasn't probably wanted. Change-Id: I50c748071e09fb062ce08aedd1af71db6c4e280d Bug-Url: https://bugzilla.redhat.com/1139590 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32658 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50c748071e09fb062ce08aedd1af71db6c4e280d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: clone vm - if the vm has only sharable disks they are ...
by tnisan＠redhat.com 09 Sep '14

09 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: clone vm - if the vm has only sharable disks they are not attached ...................................................................... core: clone vm - if the vm has only sharable disks they are not attached The problem was that the attachDisks() was called only from endSuccessfully() which was called only after the async tasks ended. But when there were no disks to copy, there were no async tasks so this method was not called. Fixed by moving the logic into the overridden addVmImages() method and detaching the disks in case of an error during copying the disks. Change-Id: Ie2a8f4c35c68721e59c0b7e35c9148f148589794 Bug-Url: https://bugzilla.redhat.com/1124340 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java 1 file changed, 23 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2a8f4c35c68721e59c0b7e35c9148f148589794 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[sdk_3.4]: sdk: Prepare for next development iteration
by juan.hernandez＠redhat.com 09 Sep '14

09 Sep '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Prepare for next development iteration ...................................................................... sdk: Prepare for next development iteration In preparation for the next development iteration this patch increases the version number, adds the SNAPSHOT suffix to the maven version and sets the RPM release number to 0.1. Change-Id: I21fa1aef87b56f10c1f8d3c74f6c740073bb58bf Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java/Makefile M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in M ovirt-engine-sdk-java/pom.xml 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32684 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21fa1aef87b56f10c1f8d3c74f6c740073bb58bf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk-java[sdk_3.4]: sdk: Release 3.4.4.0
by juan.hernandez＠redhat.com 09 Sep '14

09 Sep '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Release 3.4.4.0 ...................................................................... sdk: Release 3.4.4.0 Change-Id: Ic4f17f067af95295dd53a9391f138a5a6cb889db Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java/Makefile M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in M ovirt-engine-sdk-java/pom.xml 3 files changed, 8 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4f17f067af95295dd53a9391f138a5a6cb889db Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk-java[sdk_3.4]: sdk: Regenerate against the latest API
by juan.hernandez＠redhat.com 09 Sep '14

09 Sep '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Regenerate against the latest API ...................................................................... sdk: Regenerate against the latest API This patch regenerates the SDK using the latest API obtained from the engine built from commit 3d257b0, tag ovirt-engine-3.4.4_rc. Change-Id: I2c9513bade0fe4d09441cd32c3b6fd3b0b1fb947 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/src/main/resources/api.rsdl M ovirt-engine-sdk-java-codegen/src/main/resources/api.xsd M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenter.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterIscsiBond.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterIscsiBondNetwork.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterIscsiBondNetworkLabel.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterIscsiBondNetworkLabels.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterIscsiBondNetworkPermission.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterIscsiBondNetworkPermissions.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterIscsiBondNetworkVnicProfile.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterIscsiBondNetworkVnicProfilePermission.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterIscsiBondNetworkVnicProfilePermissions.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterIscsiBondNetworkVnicProfiles.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterIscsiBondNetworks.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterIscsiBondStorageConnection.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterIscsiBondStorageConnections.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterIscsiBonds.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VM.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/BaseResource.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/BaseResources.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/IscsiBond.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/IscsiBonds.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java 23 files changed, 2,673 insertions(+), 10 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c9513bade0fe4d09441cd32c3b6fd3b0b1fb947 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[sdk_3.4]: sdk: Prepare for next development iteration
by juan.hernandez＠redhat.com 09 Sep '14

09 Sep '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Prepare for next development iteration ...................................................................... sdk: Prepare for next development iteration In preparation for the next development iteration this patch increases the version number and sets the RPM relase number to 0.1. Change-Id: I4b31fa313f7b9b496582076dc8ec5a7425ccad55 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M setup.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b31fa313f7b9b496582076dc8ec5a7425ccad55 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[sdk_3.4]: sdk: Release 3.4.4.0
by juan.hernandez＠redhat.com 09 Sep '14

09 Sep '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Release 3.4.4.0 ...................................................................... sdk: Release 3.4.4.0 Change-Id: If2e0e87b5d1dd7265316f30d60961f2ffb5e0168 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M ovirt-engine-sdk-python.spec.in M setup.py 3 files changed, 6 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2e0e87b5d1dd7265316f30d60961f2ffb5e0168 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0