September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: aaa: Fix principal presentation at UI
by piotr.kliczewski＠gmail.com 05 Sep '14

05 Sep '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: Fix principal presentation at UI ...................................................................... aaa: Fix principal presentation at UI Bug-Url: https://bugzilla.redhat.com/1120720 Change-Id: Ie7b79325f7c6a2da0300e2a253b15044113a4b3f Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/DirectoryUser.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainUserResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResourceTest.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/aaa/DirectoryUser_CustomFieldSerializer.java 5 files changed, 9 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32475 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7b79325f7c6a2da0300e2a253b15044113a4b3f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: disabling "go" search button when there are no namespaces
by piotr.kliczewski＠gmail.com 05 Sep '14

05 Sep '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: disabling "go" search button when there are no namespaces ...................................................................... aaa: disabling "go" search button when there are no namespaces Bug-Url: https://bugzilla.redhat.com/1120720 Change-Id: I4eb1ed2648f3dccc39af9adf409d8c0ec73b2a6f Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAvailableNamespacesQuery.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/permissions/AbstractPermissionsPopupPresenterWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java 4 files changed, 57 insertions(+), 26 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4eb1ed2648f3dccc39af9adf409d8c0ec73b2a6f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.4]: ovirt-image-uploader: fixing usage of API SDK insecure param...
by sbonazzo＠redhat.com 05 Sep '14

05 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-image-uploader: fixing usage of API SDK insecure parameter ...................................................................... ovirt-image-uploader: fixing usage of API SDK insecure parameter Python SDK insecure parameter simply skips hostname validation, it still gives errors if we also pass an unmatching CA cert. Change-Id: I02f96fb2053c543e1c54dc84921da75823282509 Bug-Url: https://bugzilla.redhat.com/1138558 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 956d1d3e4c839bccbdbfe027daa212bf39f92957) --- M src/__main__.py 1 file changed, 16 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/32355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02f96fb2053c543e1c54dc84921da75823282509 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.4 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Fixing events search with from keyword
by piotr.kliczewski＠gmail.com 05 Sep '14

05 Sep '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Fixing events search with from keyword ...................................................................... core: Fixing events search with from keyword using from filter in an event search doesn't work Restoring support of 'from' clause for event search. Change-Id: I1c31ae7953fa4921fd912e4a7b94d3081d4e09a1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131030 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c31ae7953fa4921fd912e4a7b94d3081d4e09a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: Failure to add user name in rest-api due to wrong username
by piotr.kliczewski＠gmail.com 05 Sep '14

05 Sep '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: Failure to add user name in rest-api due to wrong username ...................................................................... aaa: Failure to add user name in rest-api due to wrong username Change-Id: Ic3354f48ebd1027e2d15675b27811931dcbdbe1e Topic: AAA Bug-Url: https://bugzilla.redhat.com/1138253 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/32511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3354f48ebd1027e2d15675b27811931dcbdbe1e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: changeing vm_type and os_type did reset the dialog
by tjelinek＠redhat.com 05 Sep '14

05 Sep '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: changeing vm_type and os_type did reset the dialog ...................................................................... webadmin: changeing vm_type and os_type did reset the dialog For change of os type: The problem was that the change of the vm_type in the vm dialog triggered the InstanceTypeManager.updateFields(). It was not correct since this caused the whole dialog to be re-inited from the selected instance type/template (depending on the actual selection) and that should happen only after "big" changes like cluster change which changes availability of some fields. Since the vm type only provides some defaults for the fields and not the availability of the fields, there is no need to go through the instance type manager - just simply set the fields up. For the os type: Similar but a bit more tricky. There are some fields which are actually provided from instance type. So if the os type changes, in case the selected instance type is not custom, it should set the "IsChangable" flag and let the instance type manager to copy the corresponding fields. But not all to avoid the dialog will be reset again - only the ones related to the os change. Change-Id: I5859ca02ddcbeb60583a0e79b94f7b9f2647596a Bug-Url: https://bugzilla.redhat.com/1125344 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/NewPoolInstanceTypeManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/NewVmInstanceTypeManager.java 6 files changed, 95 insertions(+), 37 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5859ca02ddcbeb60583a0e79b94f7b9f2647596a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.5]: ovirt-image-uploader: fixing usage of API SDK insecure param...
by sbonazzo＠redhat.com 05 Sep '14

05 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-image-uploader: fixing usage of API SDK insecure parameter ...................................................................... ovirt-image-uploader: fixing usage of API SDK insecure parameter Python SDK insecure parameter simply skips hostname validation, it still gives errors if we also pass an unmatching CA cert. Change-Id: I02f96fb2053c543e1c54dc84921da75823282509 Bug-Url: https://bugzilla.redhat.com/1136434 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 956d1d3e4c839bccbdbfe027daa212bf39f92957) --- M src/__main__.py 1 file changed, 16 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02f96fb2053c543e1c54dc84921da75823282509 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.5 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Failure to add user name in rest-api due to wrong username
by yzaslavs＠redhat.com 05 Sep '14

05 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Failure to add user name in rest-api due to wrong username ...................................................................... aaa: Failure to add user name in rest-api due to wrong username Change-Id: Ic3354f48ebd1027e2d15675b27811931dcbdbe1e Topic: AAA Bug-Url: https://bugzilla.redhat.com/1138253 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3354f48ebd1027e2d15675b27811931dcbdbe1e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Added tests for validation on managed custom mount option
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Added tests for validation on managed custom mount option ...................................................................... core: Added tests for validation on managed custom mount option Change-Id: I678e116b8a534b69f87be59f9be8813b08cb6910 Bug-Url: https://bugzilla.redhat.com/1129597 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionTestCommon.java 3 files changed, 92 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32490 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I678e116b8a534b69f87be59f9be8813b08cb6910 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Added validation on managed custom mount option
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Added validation on managed custom mount option ...................................................................... core: Added validation on managed custom mount option When adding a new NFS/Posix storage server connection, if the custom mount options contains a managed option (i.e. property that the engine is managing directly), the command will fail with a CDA Change-Id: Icc5a74379de55aa81194298be634f689efd331d5 Bug-Url: https://bugzilla.redhat.com/1129597 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 40 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32489 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc5a74379de55aa81194298be634f689efd331d5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0