September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Consolidated similar validations in add/update storage...
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Consolidated similar validations in add/update storage connection CDA ...................................................................... core: Consolidated similar validations in add/update storage connection CDA AddStorageServerConnection & UpdateStorageServerConnection command both contained a lot of similar validations in the CDA part, all those validations were extracted to the parent class for better readability and easier maintenance Change-Id: Id90cea934e0a9c10c5df435f564530b8658a64bb Bug-Url: https://bugzilla.redhat.com/1129597 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java 3 files changed, 31 insertions(+), 45 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id90cea934e0a9c10c5df435f564530b8658a64bb Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fixed context-sensitive help icon
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fixed context-sensitive help icon ...................................................................... webadmin: fixed context-sensitive help icon commit 42e9396 broke the context-sensitive help icon. Fixed. Also moved the header text up one pixel to align with the fixed icon. Bug-Url: https://bugzilla.redhat.com/1119027 Change-Id: Iff8f6605a89dad1f57b15a63de2ffa8e67825418 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.ui.xml M packaging/branding/ovirt.brand/common.css M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 4 files changed, 22 insertions(+), 10 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/32426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff8f6605a89dad1f57b15a63de2ffa8e67825418 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: call validation when creating/editing Provider URL for Netwo...
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: call validation when creating/editing Provider URL for Network Provider ...................................................................... call validation when creating/editing Provider URL for Network Provider added call to validate connection details when testing settings from ProviderModel. Change-Id: I0b9e9a6b66d800c973334629fa34b3b5443290df Bug-Url: https://bugzilla.redhat.com/1111974 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java 1 file changed, 18 insertions(+), 3 deletions(-) Approvals: Martin Mucha: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b9e9a6b66d800c973334629fa34b3b5443290df Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fix alignment in New Cluster dialog / Optimization
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix alignment in New Cluster dialog / Optimization ...................................................................... webadmin: fix alignment in New Cluster dialog / Optimization New Cluster dialog / Optimization tab had alignment and spacing issues. Fixed. Change-Id: Iae1712442dec2988e51312461df4c8669441f4ea Bug-Url: https://bugzilla.redhat.com/1123319 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 3 files changed, 18 insertions(+), 15 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/32433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae1712442dec2988e51312461df4c8669441f4ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Adjust network panel height to fit arrows
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Adjust network panel height to fit arrows ...................................................................... webadmin: Adjust network panel height to fit arrows The network panels were a little short compared to the arrows in the Setup Networks dialog, which caused them to go out of alignment (more noticeable as more networks are attached to the same interface). Change-Id: I55a74d41c71e7153169e077fb61813b916e5d7c6 Bug-Url: https://bugzilla.redhat.com/1120660 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> (cherry picked from commit fa4138234896897c96db904e6863fee44f7cd4df) --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/arrow_right_bottom.png M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/arrow_right_top.png 3 files changed, 2 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55a74d41c71e7153169e077fb61813b916e5d7c6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: correctly writing pg_hba.conf
by sbonazzo＠redhat.com 04 Sep '14

04 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: correctly writing pg_hba.conf ...................................................................... packaging: setup: correctly writing pg_hba.conf Fixing the parameter order writing pg_hba.conf Change-Id: I6a75084ec5134570f0c27b60214db00813651370 Bug-Url: http://bugzilla.redhat.com/1134444 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/postgres.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a75084ec5134570f0c27b60214db00813651370 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: honouring engine DB parameters from answer...
by sbonazzo＠redhat.com 04 Sep '14

04 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: honouring engine DB parameters from answer file ...................................................................... packaging: setup: honouring engine DB parameters from answer file Honouring engine DB parameters if present in the answer file. Change-Id: I9a7f79f3da05d89b34fa2cc4f74ed628fb44e3b4 Bug-Url: https://bugzilla.redhat.com/1133621 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/postgres.py 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a7f79f3da05d89b34fa2cc4f74ed628fb44e3b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[ovirt-live-3.5]: reduce size of the iso
by sbonazzo＠redhat.com 04 Sep '14

04 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: reduce size of the iso ...................................................................... reduce size of the iso dropped some utilities for saving space Change-Id: I6d5d3b4457a56e42515cd687a0ad0f0dd0f87f6f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/kickstart/ovirt-live-ovirt-custom.ks.in 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Ohad Basan: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d5d3b4457a56e42515cd687a0ad0f0dd0f87f6f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.5]: fix reference to constants moved to other files
by sbonazzo＠redhat.com 04 Sep '14

04 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: fix reference to constants moved to other files ...................................................................... fix reference to constants moved to other files - fix missing import forgot in a previous commit - fix references to constants moved to other files Change-Id: Id0ce87b7d8eaf2f5e0a1b8646a76fb530dd690cf Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/core.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0ce87b7d8eaf2f5e0a1b8646a76fb530dd690cf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.5]: packaging: refactored on original SL6.5 kickstart
by sbonazzo＠redhat.com 04 Sep '14

04 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: refactored on original SL6.5 kickstart ...................................................................... packaging: refactored on original SL6.5 kickstart Refactored kickstart files in order to be closer to the original kickstart files taken from SL6.5. This allow us to understand the changes needed for oVirt Live in order to ease the rebase for upcoming 6.6 and existing 7.0. Also restored some lines from the original kickstart after asking Ohad: they were removed accidentally Change-Id: I0eecc9a5f9fb730f94c56f85141c0a725105daf9 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile R centos/kickstart/ovirt-live-base.ks M centos/kickstart/ovirt-live-gnome.ks A centos/kickstart/ovirt-live-ovirt-custom.ks.in 4 files changed, 201 insertions(+), 78 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0eecc9a5f9fb730f94c56f85141c0a725105daf9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0